Skip to content

Commit 357f50e

Browse files
committed
edited slack-notify workflow
1 parent 76b6724 commit 357f50e

File tree

4 files changed

+21
-6
lines changed

4 files changed

+21
-6
lines changed

.eslintignore

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
# don't lint build or dist output
22
dist
33
build
4-
tsconfig.json
4+
tsconfig.json

.github/workflows/npm-publish.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,7 @@ jobs:
1818
- name: Publish npm package when version is updated
1919
uses: JS-DevTools/npm-publish@v3
2020
with:
21-
token: ${{ secrets.NPM_TOKEN }}
22-
strategy: upgrade
21+
token: ${{ secrets.NPM_TOKEN }} # This works BUT it shows up as problem for some unknown reason ("Context access might be invalid: NPM_TOKEN") and there should not be any errors
2322

2423

2524
# https://github.com/JS-DevTools/npm-publish

.github/workflows/rtconnect-test.yml

Lines changed: 18 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,4 +29,21 @@ jobs:
2929
- run: npm run lint
3030
- run: npm test
3131
# env:
32-
# CI: true
32+
# CI: true
33+
34+
35+
# slackNotification:
36+
# name: Slack CI status - notify on failure
37+
# runs-on: ubuntu-latest
38+
# steps:
39+
# - name: Slack Notify on Failure
40+
# if: ${{ failure() }}
41+
# id: slack
42+
# uses: slackapi/slack-github-action@v1.24.0
43+
# with:
44+
# channel-id: 'C067F896WG5'
45+
# slack-message: "Github CI Result: ${{ job.status }}\nGithub PR/Commit URL: ${{ github.event.pull_request.html_url || github.event.head_commit.url }}"
46+
# env:
47+
# SLACK_BOT_TOKEN: ${{ secrets.SLACK_BOT_TOKEN }}
48+
# # SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK }}
49+
# # SLACK_WEBHOOK_TYPE: INCOMING_WEBHOOK

.github/workflows/slack-notify.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,8 @@ jobs:
1919
channel-id: 'C067F896WG5'
2020
slack-message: "Github CI Result: ${{ job.status }}\nGithub PR/Commit URL: ${{ github.event.pull_request.html_url || github.event.head_commit.url }}"
2121
env:
22-
SLACK_BOT_TOKEN: ${{ secrets.SLACK_BOT_TOKEN }}
22+
SLACK_BOT_TOKEN: ${{ secrets.SLACK_BOT_TOKEN }} # This works BUT it shows up as problem for some unknown reason ("Context access might be invalid: NPM_TOKEN") and there should not be any errors
2323
# SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK }}
24-
# SLACK_WEBHOOK_TYPE: INCOMING_WEBHOOK
2524

2625

2726
# https://github.com/slackapi/slack-github-action

0 commit comments

Comments
 (0)