Fix collecting an array of tuples (JuliaArrays#20)

Author: Pietro Vertechi

src/structarray.jl

@@ -44,7 +44,7 @@ end
 @generated function StructArray(v::AbstractArray{T, N}; unwrap = t -> false) where {T, N}
     syms = [gensym() for i in 1:fieldcount(T)]
     init = Expr(:block, [:($(syms[i]) = _similar(v, $(fieldtype(T, i)); unwrap = unwrap)) for i in 1:fieldcount(T)]...)
-    push = Expr(:block, [:($(syms[i])[j] = f.$(fieldname(T, i))) for i in 1:fieldcount(T)]...)
+    push = Expr(:block, [:($(syms[i])[j] = getfield(f, $i)) for i in 1:fieldcount(T)]...)
     quote
         $init
         for (j, f) in enumerate(v)

test/runtests.jl

@@ -100,11 +100,16 @@ unwrap(::Type) = false
 unwrap(::Type{<:NamedTuple}) = true
 
 g_infer() = StructArray([(a=(b=1,), c=2)], unwrap = unwrap)
+tup_infer() = StructArray([(1, 2), (3, 4)])
 
 @testset "inferrability" begin
     @inferred f_infer()
     @inferred g_infer()
     @test g_infer().a.b == [1]
+    s = @inferred tup_infer()
+    @test Tables.columns(s) == (x1 = [1, 3], x2 = [2, 4])
+    @test s[1] == (1, 2)
+    @test s[2] == (3, 4)
 end
 
 @testset "propertynames" begin