switch to iseltype (JuliaArrays#25)

Author: Pietro Vertechi

src/collect.jl

@@ -47,7 +47,7 @@ function collect_to_columns!(dest::AbstractArray{T}, itr, offs, st) where {T}
         elem = iterate(itr, st)
         elem === nothing && break
         el, st = elem
-        if isa(el, T)
+        if iseltype(el, dest)
             @inbounds dest[i] = el
             i += 1
         else
@@ -74,7 +74,7 @@ function grow_to_columns!(dest::AbstractArray{T}, itr, elem = iterate(itr)) wher
     i = length(dest)+1
     while elem !== nothing
         el, st = elem
-        if isa(el, T)
+        if iseltype(el, dest)
             push!(dest, el)
             elem = iterate(itr, st)
             i += 1

src/utils.jl

@@ -9,6 +9,15 @@ end
 map_types(f, ::Type{NamedTuple{names, types}}) where {names, types} =
     NamedTuple{names, map_types(f, types)}
 
+all_types(f, ::Type{Tuple{}}, ::Type{T}) where {T<:Tuple} = true
+
+function all_types(f, ::Type{S}, ::Type{T}) where {S<:Tuple, T<:Tuple}
+    f(tuple_type_head(S), tuple_type_head(T)) && all_types(f, tuple_type_tail(S), tuple_type_tail(T))
+end
+
+all_types(f, ::Type{NamedTuple{n1, t1}}, ::Type{NamedTuple{n2, t2}}) where {n1, t1, n2, t2} =
+    all_types(f, t1, t2)
+
 map_params(f, ::Type{Tuple{}}) = ()
 function map_params(f, ::Type{T}) where {T<:Tuple}
     (f(tuple_type_head(T)), map_params(f, tuple_type_tail(T))...)
@@ -58,3 +67,11 @@ function createtype(::Type{<:Pair}, names, types)
     tp = types.parameters
     Pair{tp[1], tp[2]}
 end
+
+iseltype(::S, ::T) where {S, T<:AbstractArray} = iscompatible(S, T)
+
+iscompatible(::Type{S}, ::Type{<:AbstractArray{T}}) where {S, T} = S<:T
+
+function iscompatible(::Type{S}, ::Type{StructArray{T, N, C}}) where {S, T, N, C}
+    all_types(iscompatible, staticschema(S), C)
+end