refactor: clean dummy ConvolverRendererInner

Author: b-ma

src/node/constant_source.rs

@@ -11,10 +11,11 @@ use super::{AudioNode, AudioScheduledSourceNode, ChannelConfig};
 // dictionary ConstantSourceOptions {
 //   float offset = 1;
 // };
+// https://webaudio.github.io/web-audio-api/#ConstantSourceOptions
+//
 // @note - Does not extend AudioNodeOptions because AudioNodeOptions are
-// useless for source nodes as they instruct how to upmix the inputs.
-// This is a common source of confusion, see e.g. https://github.com/mdn/content/pull/18472
->>>>>>> 83a0107 (refactor: renaming variables)
+// useless for source nodes, because they instruct how to upmix the inputs.
+// This is a common source of confusion, see e.g. mdn/content#18472
 #[derive(Clone, Debug)]
 pub struct ConstantSourceOptions {
     /// Initial parameter value of the constant signal

src/node/convolver.rs

@@ -12,7 +12,8 @@ use crate::RENDER_QUANTUM_SIZE;
 use super::{AudioNode, ChannelConfig, ChannelConfigOptions, ChannelInterpretation};
 
 /// Scale buffer by an equal-power normalization
-fn normalization(buffer: &AudioBuffer) -> f32 {
+// see - <https://webaudio.github.io/web-audio-api/#dom-convolvernode-normalize>
+fn normalize_buffer(buffer: &AudioBuffer) -> f32 {
     let gain_calibration = 0.00125;
     let gain_calibration_sample_rate = 44100.;
     let min_power = 0.000125;
@@ -198,7 +199,7 @@ impl ConvolverNode {
 
         // normalize before padding because the length of the buffer affects the scale
         let scale = if self.normalize() {
-            normalization(&buffer)
+            normalize_buffer(&buffer)
         } else {
             1.
         };
@@ -346,9 +347,13 @@ impl ConvolverRendererInner {
 
     // dummy convolver used to init renderer
     fn tombstone() -> Self {
-        // just use arbitrary common sample rate
-        let padded_buffer = AudioBuffer::from(vec![vec![0.; 0]; 1], 48000.);
-        Self::new(padded_buffer)
+        Self {
+            num_ir_blocks: Default::default(),
+            h: Default::default(),
+            fdl: Default::default(),
+            out: Default::default(),
+            fft2: Fft::new(0),
+        }
     }
 
     fn process(&mut self, input: &[f32], output: &mut [f32]) {