Merge pull request #358 from orottier/clippy-fixes-1.72

Clippy fixes rust version 1.72

Author: orottier

src/analysis.rs

@@ -781,7 +781,7 @@ mod tests {
         analyser.set_fft_size(RENDER_QUANTUM_SIZE);
 
         // get data, should be zero (negative infinity decibel)
-        let mut bins = vec![255; RENDER_QUANTUM_SIZE];
+        let mut bins = [255; RENDER_QUANTUM_SIZE];
         analyser.get_byte_frequency_data(&mut bins[..], 0.);
 
         // only N / 2 values should contain frequency data, rest is unaltered

src/io/cpal.rs

@@ -20,6 +20,9 @@ use crate::{AtomicF64, MAX_CHANNELS};
 
 use crossbeam_channel::Receiver;
 
+// I doubt this construct is entirely safe. Stream is not Send/Sync (probably for a good reason) so
+// it should be managed from a single thread instead.
+// <https://github.com/orottier/web-audio-api-rs/issues/357>
 mod private {
     use super::*;
 
@@ -28,6 +31,7 @@ mod private {
 
     impl ThreadSafeClosableStream {
         pub fn new(stream: Stream) -> Self {
+            #[allow(clippy::arc_with_non_send_sync)]
             Self(Arc::new(Mutex::new(Some(stream))))
         }
 

src/io/cubeb.rs

@@ -34,6 +34,9 @@ impl<F> CubebStream for Stream<F> {
     }
 }
 
+// I doubt this construct is entirely safe. Stream is not Send/Sync (probably for a good reason) so
+// it should be managed from a single thread instead.
+// <https://github.com/orottier/web-audio-api-rs/issues/357>
 mod private {
     use super::*;
     use std::sync::Mutex;
@@ -44,6 +47,7 @@ mod private {
     impl ThreadSafeClosableStream {
         pub fn new<F: 'static>(stream: Stream<F>) -> Self {
             let boxed_stream = BoxedStream(Box::new(stream));
+            #[allow(clippy::arc_with_non_send_sync)]
             Self(Arc::new(Mutex::new(Some(boxed_stream))))
         }
 

src/node/convolver.rs

@@ -473,7 +473,7 @@ mod tests {
         let ir = vec![1.];
         let calibration = 0.00125;
         let channel_data = vec![0., 1., 0., -1., 0.];
-        let expected = vec![0., calibration, 0., -calibration, 0., 0., 0., 0., 0., 0.];
+        let expected = [0., calibration, 0., -calibration, 0., 0., 0., 0., 0., 0.];
 
         // identity ir
         let ir = AudioBuffer::from(vec![ir; 1], sample_rate);
@@ -518,23 +518,23 @@ mod tests {
     #[test]
     fn test_passthrough() {
         let output = test_convolve(&[0., 1., 0., -1., 0.], None, 10);
-        let expected = vec![0., 1., 0., -1., 0., 0., 0., 0., 0., 0.];
+        let expected = [0., 1., 0., -1., 0., 0., 0., 0., 0., 0.];
         assert_float_eq!(output.get_channel_data(0), &expected[..], abs_all <= 1E-6);
     }
 
     #[test]
     fn test_empty() {
         let ir = vec![];
         let output = test_convolve(&[0., 1., 0., -1., 0.], Some(ir), 10);
-        let expected = vec![0.; 10];
+        let expected = [0.; 10];
         assert_float_eq!(output.get_channel_data(0), &expected[..], abs_all <= 1E-6);
     }
 
     #[test]
     fn test_zeroed() {
         let ir = vec![0., 0., 0., 0., 0., 0.];
         let output = test_convolve(&[0., 1., 0., -1., 0.], Some(ir), 10);
-        let expected = vec![0.; 10];
+        let expected = [0.; 10];
         assert_float_eq!(output.get_channel_data(0), &expected[..], abs_all <= 1E-6);
     }
 
@@ -543,7 +543,7 @@ mod tests {
         let ir = vec![1.];
         let calibration = 0.00125;
         let output = test_convolve(&[0., 1., 0., -1., 0.], Some(ir), 10);
-        let expected = vec![0., calibration, 0., -calibration, 0., 0., 0., 0., 0., 0.];
+        let expected = [0., calibration, 0., -calibration, 0., 0., 0., 0., 0., 0.];
         assert_float_eq!(output.get_channel_data(0), &expected[..], abs_all <= 1E-6);
     }
 
@@ -552,7 +552,7 @@ mod tests {
         let ir = vec![1., 1.];
         let calibration = 0.00125;
         let output = test_convolve(&[0., 1., 0., -1., 0.], Some(ir), 10);
-        let expected = vec![
+        let expected = [
             0.,
             calibration,
             calibration,