WiX Official Builds vs Private Builds

[chrpai]

According to the OSMF:

2. Monthly Fee and Payment Terms

Revenue-generating Users required to pay the Fee shall follow the payment
terms set forth by the Project. Failure to comply with these terms may result
in suspending access to the Binary Release. However, this does not restrict
the User from obtaining or redistributing binaries from other sources or
self-compiling them.

4. Conflicts with OSI License

To the extent any term of this Agreement conflicts with User's rights
under the OSI License regarding the Software, the OSI License shall govern.
This Agreement applies only to the Binary Release and does not limit User's
ability to access, modify, or distribute the Software's source code or
self-compiled binaries. User may independently compile binaries from the
Software's source code without this Agreement, subject to OSI License terms.
User may redistribute the Binary Release received under this Agreement,
provided such redistribution complies with the OSI License (e.g., including
copyright and permission notices). This Agreement imposes no additional
restrictions on such rights.

As such I've noticed a few things about the wix official builds that makes this difficult. There should be ways to override:

Authors
Company (but not Copyright as Copyright is the .NET Foundation and contributors.)
PackageEulaSource
PackageLicenseFile
PackageRequireLicenseAcceptance
Product
PackageIcon
PackageIconSource

Remove checks that verify the org\repos is wixtoolset\wix

Design the signing to support more variations then an azure keystore.

SigningToolExe (may not be nessecary)
SigningCommand
SigningConfiguration

Thoughts? I'm happy to file issues and submit PRs for this. I think this would help deflect any concern/criticism anyone may have. Also I think it's inevitable that discussions and issues will have to become restricted to sponsors only to keep certain types of users at bay.

[chrpai]

It might also be a good idea to record in the Creating Application Summary property of the build MSI (and similiar for burn EXE) whether an OSMF build created it or not or some similiar variation point. (WiXToolSet Official 6.0...)

[chrpai]

All of the .nuspec files are hard coding the license to OSMFEULA.txt instead of using $VAR$ like all the other attributes are. If you override DirectoryBuild.props and set PackageEualSource and PackageLicenseFile setting it back to LICENSE.TXT the build fails saying the package doesn't contain OSMFEULA.txt.

[chrpai]

The more I look at this the bigger problem I have with OSMFEULA.txt /OSMFEULA.rtf and any reference to it in the repos. This completely contaminates the respos which is covered by the MS-RL license which says you have to redistribute everything. Additionally it completely watermarks all private/developer builds with the OSMF which I am sure is not the intention. I feel like this is something that should get applied to the sources after the clone during the official build only.