Cashed component instance

[vytautas-pranskunas-]

Hello,

have interestign bug reported from QA.
we have modal

this.dialog
            .open<IncomeByAccountingDocumentsComponentResponse>({
                content: new PolymorpheusComponent(IncomeByAccountingDocumentsComponent, this.injector),
                label: this.translate.instant('income-edit.incomeByAccountingDocuments'),
                data: {
                    id,
                    residentId: this.residentId(),
                    applicantName: this.residentName(),
                } as IncomeByAccountingDocumentsComponentData,
            })
            .subscribe((result) => {
                this.addOrUpdateItem(result);
            });

inside component we have form

form = this.formBuilder.group({
        applicationDate: [
            new Date(),
            [
                Validator.required(),
                Validator.greaterThan(
                    'dateFrom',
                    `${this.translate.instant('income-edit.incomeForRange')} - ${this.translate.instant('general.dateFrom')}`,
                ),
            ],
        ],
    });

when modal is opened applicationDate gets current date but if system is left opened for 24 hours and without refresh QA opens modal applicationDate gets previous date value.

Something is cashing the component? Because form is initialized no in ngOnInit... but new PolymorpheusComponent should ensure that it is not cached or?

thanks for any idea

[waterplea]

Dialogs component are only created when you subscribe to the Observable returned from open and are not cached anywhere, each subscription would create a new instance:
https://github.com/taiga-family/taiga-ui/blob/main/projects/cdk/services/popover.service.ts#L63
https://github.com/taiga-family/taiga-ui/blob/main/projects/core/components/dialog/dialogs.template.html#L16

All new PolymorpheusComponent does are those 2 things:

1. Allows storing Injector together with the component class.
2. Allows for instanceof check so that we can differentiate functions from component classes.

Something else must be going on there.

[vytautas-pranskunas-]

so basically you are saying that compnent each time is recreated from scratch and actual date should be inserted?

[waterplea]

Yes. It is essentially equivalent to running createComponent every time you call .subscribe().

[vytautas-pranskunas-]

thank you