Proposal: enable "Require conversation resolution before merging" in GitHub

[304NotModified]

Sometimes it's hard to see if all conversions are resolved. Luckily GitHub could check that (and you could also bypass it AFAIK)
It the setting "Require conversation resolution before merging" under the "Branch protection rule"

(I also like the linear history)

[gasparnagy]

We currently don't have a "classic branch protection rule", but a "branch ruleset" that is filtered for the main branch. Would it cause any conflicts if I would add a new classic branch protection rule as well? Which one would have the higher priority?

This is what we have (the conversation resolution option is unfortunately is not available for "branch rulesets")

[304NotModified]

Is this not correctly saved? I don't see it in any PR 😅

[304NotModified]

Or isn't it enforced?

[304NotModified]

It tested it on another repo and it works immediately

[gasparnagy]

I have seen it working for one of the PRs.

It is harder to repro it, because you need an approved pr with an open review note. I did a test now:

[304NotModified]

ow yes indeed! Cool!

I got it also working now :)