exec/spawn gets killed but the command still running in background

[yahu1031]

Version

v19.1.0

Platform

Darwin Mrs-MacBook-Air.local 22.1.0 Darwin Kernel Version 22.1.0: Sun Oct 9 20:14:30 PDT 2022; root:xnu-8792.41.9~2/RELEASE_ARM64_T8103 arm64

Subsystem

child_process

What steps will reproduce the bug?

import { exec, spawn} from 'child_process';
import { join } from 'path';

var execution = exec('ping', { maxBuffer: 1024 * 1024 * 10 });

var spawning = spawn('ping');

// var spawning = spawn('dart', [join('bin', 'main.dart')]);


execution.kill();

In my case, I'm running a server. This shows it killed the execution but I can still see the server is up after I killed it. And it also shows that a process in services manager(generic).

How often does it reproduce? Is there a required condition?

every time.

What is the expected behavior?

must kill the process.

What do you see instead?

manually killing it.

Additional information

NOTE: This is in VS code extension development.

[bnoordhuis]

Not a bug so converted to a discussion. Pass { killSignal: "SIGKILL" }. The default signal is SIGTERM and a process is free to ignore that.

[yahu1031]

See the PIDs

[yahu1031]

using spawn()

[yahu1031]

killing the parent doesn't kill the grandchild process but leaves it idle.

[yahu1031]

Fixed by using PID ranges - in process.kill(-PID)