Nitrite/Java: Apache Fury Serializer NitriteDocument access level

[jaredmdobson]

I'm trying to add Apache Fury as the Serializer for my project and I was wondering if it would be feasible to open up the NitriteDocument access level? Or am i doing something wrong? :)

2024-05-04 07:17:56 WARN  ObjectStreamSerializer:92 [main] - class org.dizitart.no2.collection.NitriteDocument customized jdk serialization, which is inefficient. Please replace it with a org.apache.fury.serializer.Serializer or implements java.io.Externalizable
2024-05-04 07:17:56 INFO  CompileUnit:55 [main] - Generate code for org.dizitart.no2.collection.NitriteDocumentFuryCompatibleCodec_1_118352462_1413623320 took 9 ms

I can share or do a pull request of the fury serializers if that interests anyone for this project.

[anidotnet]

Hello, thanks for trying out Nitrite. May I know what exactly are you expecting here? What do you mean by open up NitriteDocument access level exactly?

[anidotnet]

I see the build has failed here also. Upon quick checking, it looks like you need to add guava as a compile dependency into the pom. @NotThreadSafe is coming from jsr305. Currently, guava is added as a test dependency in rocksdb adapter from the Nitrite parent pom. I hope if you remove the test scope, the build will run fine.

[anidotnet]

@anidotnet good point, i'll make it backwards compatible. the pr is definitely not ready at all, its definitely broken. I'll mark it ready when its ready :)

I am going to release it in a minor version upgrade - 4.3.0. So may be you can deprecate the existing ObjectFormatter and introduce ObjectSerializer as you did here. And a note in the changelog would suffice I guess. In the next upgrade, I'll remove just the ObjectFormatter class.

[jaredmdobson]

@anidotnet this did it!!!

@NotThreadSafe is coming from jsr305. Currently, guava is added as a test dependency in rocksdb adapter from the Nitrite parent pom. I hope if you remove the test scope, the build will run fine.

🎆 🥳 Thank you so much!

Now i'll work on some specs and review it and will ping you when done, thanks. 👍🏿

[jaredmdobson]

Hey @anidotnet i'm trying to figure out the best way to refactor/organize the tests to support testing of both the Fury and Kyro serializers. If you have any suggestions i'm all ears, if not i'll come up with an idea tomorrow.

[anidotnet]

Just an idea, you may have to introduce parameterized test setup. Based on parameter you can either use fury or kryo serializer while setting up Nitrite database using RocksDbModuleBuilder.