Question / Bug(?) in test case SegmentDisplay

[worldpeace-germany]

Hello,

I would like to understand something about this test https://github.com/missionpinball/mpf/blob/dev/mpf/tests/test_SegmentDisplay.py#L1310

At the moment I am only seeking for confirmation on my understanding, not where the bug lies in the code (if my understanding is correct). Once we agree on an understanding I will investigate the code itself further.

TEST 1:

        display1.add_text("FIRST")
        self.assertEqual("     FIRST", display1.text)
        self.assertEqual([RGBColor("white")] * 10, display1.colors)
        self.assertEqual([RGBColor("white")] * 10, display1.hw_display.colors)
        self.assertEqual(FlashingType.NO_FLASH, display1.flashing)

Add entry with priority 0 and key “None” (since no key is given), color of the text is white.

TEST 2:

        display1.add_text_entry(
            "SECOND", [RGBColor("red")], FlashingType.FLASH_ALL, "", None, None, 10, "2nd")
        self.assertEqual("    SECOND", display1.text)
        self.assertEqual([RGBColor("red")] * 10, display1.colors)
        self.assertEqual(FlashingType.FLASH_ALL, display1.flashing)

Add text with key “2nd” and priority 10

TEST 3:

        display1.add_text_entry(
            "THIRD", [RGBColor("yellow")], FlashingType.FLASH_MASK, "F F F ", None, None, 5, "3rd")
        self.assertEqual("    SECOND", display1.text)
        self.assertEqual([RGBColor("red")] * 10, display1.colors)
        self.assertEqual(FlashingType.FLASH_ALL, display1.flashing)

Add text with key “3rd” and priority 5

TEST 4:

        display1.remove_text_by_key("2nd")
        self.assertEqual("     THIRD", display1.text)
        self.assertEqual([RGBColor("yellow")] * 10, display1.colors)
        self.assertEqual(FlashingType.FLASH_MASK, display1.flashing)
        self.assertEqual("F F F ", display1.flash_mask)

Remove entry from TEST 2 (key= "2nd")

TEST 5:

        display1.add_text("3rd", 5, "3rd")
        self.assertEqual("       3rd", display1.text)
        self.assertEqual([RGBColor("yellow")] * 10, display1.colors)
        self.assertEqual(FlashingType.FLASH_MASK, display1.flashing)
        self.assertEqual("F F F ", display1.flash_mask)

Update text from TEST 3

TEST 6:

        display1.add_text("1st")
        self.assertEqual("       3rd", display1.text)
        self.assertEqual([RGBColor("yellow")] * 10, display1.colors)
        self.assertEqual(FlashingType.FLASH_MASK, display1.flashing)
        self.assertEqual("F F F ", display1.flash_mask)

Updating the text from TEST 1 (due to lower priority it is not shown on display, which is correct)

TEST 7:

        display1.add_text_entry(
            "FIRST", [RGBColor("blue")], FlashingType.NO_FLASH, "", None, None, 20, None)
        self.assertEqual("     FIRST", display1.text)
        self.assertEqual([RGBColor("blue")] * 10, display1.colors)

Updating again the text from TEST 1 and TEST 6, plus the priority, key is “None” which is the indicator that it is the same entry we touched in TEST 1 and 6. Part of the update is to change the color to blue (previously white from TEST 1)

TEST 8:

        display1.remove_text_by_key(None)
        self.assertEqual("       3rd", display1.text)
        self.assertEqual([RGBColor("blue")] * 10, display1.colors)
        self.assertEqual(FlashingType.NO_FLASH, display1.flashing)

Now we remove the entry with key “None”, which is the entry from TEST 1,6,7.

Let me summarize what has happened so far. We have worked with entries having the keys None, 2nd and 3rd . Sorted by these keys:

None:
TEST 1 --> added, color white
TEST 6 --> text changed, no color change
TEST 7 --> text changed, color changed to blue
TEST 8 --> removed that entry

2nd:
TEST 2 --> created, color red
TEST 4 --> removed that entry

3rd:
TEST 3 --> created color yellow
TEST 5 --> updated text, no color change

Which means on the stack is only the entry left with key “3rd" and this one should be shown. If you look at the asserts in test 8

self.assertEqual(" 3rd", display1.text)

--> Yes fully agree, correct

self.assertEqual([RGBColor("blue")] * 10, display1.colors)

--> No I don’t agree, why blue shouldn’t it be yellow?

Can either someone confirm my point of view or explain to me why the color should be blue?

Thanks!