Transit vehicle is not yet at last stop!

[Lshanah]

Struggling to pin this down. I'm using v2024.0 with a java launcher. Context is I have created a network of two grids connected by three bridges, and have transit lines running east to west and north south. I remove 10% of internal lines but should have full access to each node for all vehicles and have two links one-way links connecting each node. Every stop facility gets its link set for each direction, so inbound stops use the incoming link, outbound stops the outgoing one

I am trying to run a simulation of a multi-fleet taxi through multiModeTaxi which competes with cars and public transit.

My QSim crashes early in iteration 0 with:

java.lang.RuntimeException: Transit vehicle is not yet at last stop!  
 vehicle-id = NS_H_26_to_H_9_26_veh_21600; next-stop = stop_H_9_26

I build my departures with this in the same script that builds the network:

private static void addDepartures(TransitScheduleFactory tf,
                                      TransitLine line,
                                      String suffix,
                                      List<Id<Link>> links,
                                      List<TransitRouteStop> stops,
                                      int headway,
                                      int first,
                                      int last,
                                      Vehicles vehicles,
                                      VehiclesFactory vf,
                                      VehicleType busType) {
    	// for stop i, use link i  (and for the very last stop, re-use the last link)
    	for (int i = 0; i < stops.size(); i++) {
    	    TransitStopFacility tsf = stops.get(i).getStopFacility();
    	    Id<Link> linkForThisStop = links.get( Math.min(i, links.size() - 1) );
    	    tsf.setLinkId(linkForThisStop);
    	}


        // ② build and add the route
        Id<TransitRoute> rid = Id.create(line.getId()+"_"+suffix,TransitRoute.class);
        TransitRoute tr = tf.createTransitRoute(
            rid,
            RouteUtils.createNetworkRoute(links),
            stops,
            "bus"
        );
        line.addRoute(tr);

        // ③ add departures
        for (int t = first; t <= last; t += headway) {
            Departure d = tf.createDeparture(
                Id.create(line.getId()+"_"+suffix+"_dep_"+t,Departure.class),
                t);
            Id<Vehicle> vid = Id.create(line.getId()+"_"+suffix+"_veh_"+t,Vehicle.class);
            vehicles.addVehicle(vf.createVehicle(vid,busType));
            d.setVehicleId(vid);
            tr.addDeparture(d);
        }

    I also try build with: ```    	   for (int i = 0; i < stops.size(); i++) {
		       TransitStopFacility tsf = stops.get(i).getStopFacility();
		       // stop i uses link i, or last link for final stop
		      Id<Link> linkForThisStop = links.get(Math.min(i, links.size() - 1));
		      tsf.setLinkId(linkForThisStop);
	   } 

    	   

Here are xml extracts: Network links: 

```

Transit stops:

              x="5200.0" y="1800.0"
              linkRefId="H_9_26_H_8_26"
              isBlocking="false"/> 

Inbound route for line NS_H_26

<transitRoute id="NS_H_26_to_H_9_26">
  <routeProfile>
    …
    <stop refId="stop_H_9_26" …/>          <!-- final stop -->
  </routeProfile>
  <route>
    …
    <link refId="H_8_26_H_9_26"/>           <!-- inbound last link -->
  </route>
</transitRoute> 

And my config is as follows:

  <module name="controller">
    <!-- run from iteration 0 up to iteration 25 -->
    <param name="firstIteration"     value="0"/>
    <param name="lastIteration"      value="1"/>
    <!-- write events & plans each iteration -->
    <param name="writeEventsInterval"  value="1"/>
    <param name="writePlansInterval"   value="5"/>
    <!-- where to put results -->
    <param name="outputDirectory"      value="00_base_output/"/>
    <!-- overwrite behavior -->
    <param name="overwriteFiles"       value="deleteDirectoryIfExists"/>
  </module>
  <module name="network">
    <param name="inputNetworkFile"      value=final_network.xml"/>
  </module>
  <module name="dvrp">
    <param name="networkModes" value="car,taxi"/>
  </module>
  <module name="plans">
    <param name="inputPlansFile"        value="twogridringclasses_plans.xml"/>
  </module>

	<module name="transit">    
  	<param name="useTransit" value="true"/>  
    <param name="transitScheduleFile"   value="final_transitSchedule.xml"/>
      <param name="vehiclesFile"
            value="final_vehicles.xml"/>
  </module>

  <module name="multiModeTaxi">
    <parameterset type="taxi">
      <param name="mode" value="taxi"/>
      <param name="taxisFile" value="autonomousTaxiFleet.xml"/>
      <param name="destinationKnown" value="true"/>
      <param name="pickupDuration" value="120"/>
      <param name="dropoffDuration" value="60"/>
      <param name="changeStartLinkToLastLinkInSchedule" value="true"/>
		    <parameterset type="RuleBasedTaxiOptimizer"/>
    	</parameterset>
  </module>


  <module name="facilities">
    <param name="inputFacilitiesFile"
      value="final_facilities.xml"/>
  </module>


  <module name="transitRouter">
    <param name="maxBeelineWalkConnectionDistance" value="1500"/>
    <param name="extensionRadius"                  value="2000"/>
    <param name="searchRadius"                     value="1000"/>
  </module>

  <module name="qsim">
    <param name="mainMode" value="car,taxi,bus"/>
    <param name="flowCapacityFactor"    value="1.0"/>
    <param name="storageCapacityFactor" value="1.0"/>
    <param name="trafficDynamics"       value="kinematicWaves"/>
    <param name="startTime"             value="00:00:00"/>
    <param name="endTime"               value="32:00:00"/>
    <param name="simStarttimeInterpretation" value="onlyUseStarttime"/>
    <param name="insertingWaitingVehiclesBeforeDrivingVehicles" value="false"/>
  </module>

Please, any help would be so appreciated. Can share more context or code if needed! Thanks!

[kainagel]

I don't know enough about public transit to say this without running it myself. What I can say is that there is a public transit schedule validator which can be used from the GUI. See attached picture. Does that maybe help?

---

Outside of that, and just guessing: It reads like the pt vehicle cannot reach stop stop_H_9_26. From your XML snippets, that stop is at link H_9_26_H_8_26, and the last link of your pt route is H_8_26_H_9_26. Without all the links in the file I cannot debug this completely, but at least I note that they are not the same.

Please let us know how it goes.

[Lshanah]

Hi kainagel, thank you using the validator sped things up significantly isolating the issue.

I had built my transit stops using one shared facility ID per node, so both the outbound and inbound directions all pointed at “stop_H_2_0”, “stop_H_2_1”, etc. That meant that when I generated the inbound route, every TransitStopFacility object got its linkRefId overwritten to the inbound link. The stops were sitting on the last link of the inbound diredction and the outbound stops were lost.

I fixed it by creating two seperate facilities for each stop node: one for outbound, one for inbound. The key change was going from something like:

Id<TransitStopFacility> sf0 = Id.create("stop_"+fromId, TransitStopFacility.class);

to

	        Id<TransitStopFacility> sfB = Id.create(
	                "stop_" + b + "_" + lineId + "_" + direction,
	                TransitStopFacility.class
	            )

By appending the lineId and a suffix (“out” or “in”), every single TransitStopFacility becomes unique though they sit on the same network node, they each carry the correct linkRefId for their one and only route direction. Phew!

Here is my full network and transit builder for completeness, issue was resolved in the second-to-last section BuildRoute:

package org.thesis;

import java.util.*;

import org.matsim.api.core.v01.Coord;
import org.matsim.api.core.v01.Id;
import org.matsim.api.core.v01.Scenario;
import org.matsim.api.core.v01.network.Link;
import org.matsim.api.core.v01.network.Network;
import org.matsim.api.core.v01.network.Node;

import org.matsim.core.config.Config;
import org.matsim.core.config.ConfigUtils;
import org.matsim.core.network.NetworkUtils;
import org.matsim.core.network.io.NetworkWriter;
import org.matsim.core.scenario.ScenarioUtils;

import org.matsim.facilities.ActivityFacilities;
import org.matsim.facilities.ActivityFacilitiesFactory;
import org.matsim.facilities.ActivityFacility;
import org.matsim.facilities.FacilitiesUtils;
import org.matsim.facilities.FacilitiesWriter;

import org.matsim.pt.transitSchedule.api.Departure;
import org.matsim.pt.transitSchedule.api.TransitLine;
import org.matsim.pt.transitSchedule.api.TransitRoute;
import org.matsim.pt.transitSchedule.api.TransitRouteStop;
import org.matsim.pt.transitSchedule.api.TransitSchedule;
import org.matsim.pt.transitSchedule.api.TransitScheduleFactory;
import org.matsim.pt.transitSchedule.api.TransitStopFacility;
import org.matsim.pt.transitSchedule.api.TransitScheduleWriter;

import org.matsim.vehicles.Vehicle;
import org.matsim.vehicles.VehicleType;
import org.matsim.vehicles.Vehicles;
import org.matsim.vehicles.VehiclesFactory;
import org.matsim.vehicles.MatsimVehicleWriter;

import org.matsim.core.population.routes.RouteUtils;

public class NetworktransitBuilder {

    // output files 
    private static final String NETWORK_FILE          =
        "";
    private static final String FACILITIES_FILE       =
        "";
    private static final String TRANSIT_SCHEDULE_FILE =
        "";
    private static final String VEHICLES_FILE         =
        "";

    //grid geometry
    private static final int    ROWS_H    = 10, COLS_H = 40;
    private static final int    ROWS_B    = 10, COLS_B = 40;
    private static final double SPACING   = 200.0;
    private static final double GAP       = 1500.0;

    //  link parameters 
    private static final double LOCAL_SPEED         = 30_000/3_600.0;
    private static final double COLLECTOR_SPEED     = 50_000/3_600.0;
    private static final double CONNECTOR_SPEED     = 50_000/3_600.0;
    private static final double LOCAL_CAP_PER_L     =    900.0;
    private static final double COLLECTOR_CAP_PER_L =  1_800.0;
    private static final double CONNECTOR_CAP_PER_L =    600.0;
    private static final double BIKE_SPEED          = 16_000/3_600.0;

    private static final Set<String> MODES_ALL    =
        Set.of("car","taxi","bus","bike","walk","pt");
    private static final Set<String> MODES_BIKEARC =
        Set.of("bike","walk");

    public static void main(String[] args) {
        Config   config   = ConfigUtils.createConfig();
        Scenario scenario = ScenarioUtils.createScenario(config);
        Network  net      = scenario.getNetwork();

        // 1. build network
        buildNodes(net);
        buildRoadLinks(net);
        new NetworkWriter(net).write(NETWORK_FILE);
        System.out.println("Wrote network → " + NETWORK_FILE);

        // 1. build facilities
        ActivityFacilities facs = buildFacilities(scenario);
        new FacilitiesWriter(facs).write(FACILITIES_FILE);
        System.out.println("Wrote facilities → " + FACILITIES_FILE);

        // 3. build transit + vehicles
        buildTransit(scenario);
        new TransitScheduleWriter(scenario.getTransitSchedule())
            .writeFile(TRANSIT_SCHEDULE_FILE);
        new MatsimVehicleWriter(scenario.getTransitVehicles())
            .writeFile(VEHICLES_FILE);
        System.out.println("Wrote transit schedule → " + TRANSIT_SCHEDULE_FILE);
        System.out.println("Wrote vehicles → " + VEHICLES_FILE);
    }

    private static void buildNodes(Network net) {
        // H-grid
        for (int r = 0; r < ROWS_H; r++) {
            for (int c = 0; c < COLS_H; c++) {
                String id = "H_"+r+"_"+c;
                Coord  xy = new Coord(c*SPACING, r*SPACING);
                net.addNode(NetworkUtils.createNode(Id.create(id,Node.class), xy));
            }
        }
        // B-grid (shifted right)
        double x0 = COLS_H*SPACING + GAP;
        for (int r = 0; r < ROWS_B; r++) {
            for (int c = 0; c < COLS_B; c++) {
                String id = "B_"+r+"_"+c;
                Coord  xy = new Coord(x0 + c*SPACING, r*SPACING);
                net.addNode(NetworkUtils.createNode(Id.create(id,Node.class), xy));
            }
        }
    }

    private static void buildRoadLinks(Network net) {
        // 1) H↔B connectors
        for (int r : List.of(3,5,7)) {
            Node h = net.getNodes().get(Id.create("H_"+r+"_"+(COLS_H-1),Node.class));
            Node b = net.getNodes().get(Id.create("B_"+r+"_0",       Node.class));
            createLinkPair(net,h,b,1800,"CONNECTOR",
                           CONNECTOR_SPEED,1,CONNECTOR_CAP_PER_L,MODES_ALL);
        }

        // 2) arterials on central row
        int central = ROWS_H/2;
        for (String g : List.of("H","B")) {
            int cols = g.equals("H")?COLS_H:COLS_B;
            for (int c = 0; c < cols-1; c++) {
                Node n = net.getNodes().get(Id.create(g+"_"+central+"_"+c,   Node.class));
                Node e = net.getNodes().get(Id.create(g+"_"+central+"_"+(c+1),Node.class));
                createLinkPair(net,n,e,200,"ARTERIAL",
                               COLLECTOR_SPEED,2,COLLECTOR_CAP_PER_L,MODES_ALL);
            }
        }

        // 3) full grid of LOCAL links
        for (String g : List.of("H","B")) {
            int rows = g.equals("H")?ROWS_H:ROWS_B;
            int cols = g.equals("H")?COLS_H:COLS_B;
            for (int r = 0; r < rows; r++) {
                for (int c = 0; c < cols; c++) {
                    Node n = net.getNodes().get(Id.create(g+"_"+r+"_"+c,Node.class));
                    if (c < cols-1) {
                        Node e = net.getNodes().get(Id.create(g+"_"+r+"_"+(c+1),Node.class));
                        createLinkPair(net,n,e,SPACING,"LOCAL",
                                       LOCAL_SPEED,1,LOCAL_CAP_PER_L,MODES_ALL);
                    }
                    if (r < rows-1) {
                        Node s = net.getNodes().get(Id.create(g+"_"+(r+1)+"_"+c,Node.class));
                        createLinkPair(net,n,s,SPACING,"LOCAL",
                                       LOCAL_SPEED,1,LOCAL_CAP_PER_L,MODES_ALL);
                    }
                }
            }
        }
    }

    private static void createLinkPair(Network net,
                                       Node from, Node to,
                                       double length,
                                       String type,
                                       double freespeed,
                                       int lanes,
                                       double capPerLane,
                                       Set<String> modes) {
        Id<Link> idF = Id.create(from.getId()+"_"+to.getId(), Link.class);
        if (!net.getLinks().containsKey(idF)) {
            Link f = net.getFactory().createLink(idF, from, to);
            f.setLength(length);
            f.setFreespeed(freespeed);
            f.setNumberOfLanes(lanes);
            f.setCapacity(capPerLane*lanes);
            f.setAllowedModes(modes);
            f.getAttributes().putAttribute("linkType", type);
            net.addLink(f);
        }
        Id<Link> idB = Id.create(to.getId()+"_"+from.getId(), Link.class);
        if (!net.getLinks().containsKey(idB)) {
            Link b = net.getFactory().createLink(idB, to, from);
            b.setLength(length);
            b.setFreespeed(freespeed);
            b.setNumberOfLanes(lanes);
            b.setCapacity(capPerLane*lanes);
            b.setAllowedModes(modes);
            b.getAttributes().putAttribute("linkType", type);
            net.addLink(b);
        }
    }

    private static ActivityFacilities buildFacilities(Scenario sc) {
        ActivityFacilities facs = FacilitiesUtils.createActivityFacilities();
        ActivityFacilitiesFactory ff = facs.getFactory();
        Random rng = new Random(42);

        // collect all node‐coordinates
        List<Coord> coords = new ArrayList<>();
        for (int r=0; r<ROWS_H; r++)
            for (int c=0; c<COLS_H; c++)
                coords.add(new Coord(c*SPACING, r*SPACING));
        double x0 = COLS_H*SPACING + GAP;
        for (int r=0; r<ROWS_B; r++)
            for (int c=0; c<COLS_B; c++)
                coords.add(new Coord(x0 + c*SPACING, r*SPACING));

        // 10 000 homes (70 % H, 30 % B)
        for (int i=0; i<10_000; i++) {
            Coord xy = coords.get(rng.nextInt(coords.size()));
            ActivityFacility f = ff.createActivityFacility(
                Id.create("home_"+i,ActivityFacility.class), xy);
            f.addActivityOption(ff.createActivityOption("home"));
            facs.addActivityFacility(f);
        }

        // 10 000 work (70 % B, 30 % H)
        for (int i=0; i<10_000; i++) {
            Coord xy = coords.get(rng.nextInt(coords.size()));
            ActivityFacility f = ff.createActivityFacility(
                Id.create("work_"+i,ActivityFacility.class), xy);
            f.addActivityOption(ff.createActivityOption("work"));
            facs.addActivityFacility(f);
        }

        // 2 000 leisure (uniform)
        for (int i=0; i<2_000; i++) {
            Coord xy = coords.get(rng.nextInt(coords.size()));
            ActivityFacility f = ff.createActivityFacility(
                Id.create("leisure_"+i,ActivityFacility.class), xy);
            f.addActivityOption(ff.createActivityOption("leisure"));
            facs.addActivityFacility(f);
        }

        return facs;
    }

    private static void buildTransit(Scenario sc) {
        TransitSchedule        schedule = sc.getTransitSchedule();
        TransitScheduleFactory tf       = schedule.getFactory();
        Vehicles               vehicles = sc.getTransitVehicles();
        VehiclesFactory        vf       = vehicles.getFactory();

        // create one bus type
        VehicleType busType = vf.createVehicleType(
            Id.create("busType",VehicleType.class));
        busType.getCapacity().setSeats(100);
        vehicles.addVehicleType(busType);

        // add 6 lines exactly as before
        addLine(tf,schedule,sc.getNetwork(),vehicles,vf,busType,
                "EW_upper","H_7_0","B_7_39",10*60,6*3600,22*3600);
        addLine(tf,schedule,sc.getNetwork(),vehicles,vf,busType,
                "EW_lower","H_2_0","B_2_39",10*60,6*3600,22*3600);

        addLine(tf,schedule,sc.getNetwork(),vehicles,vf,busType,
                "NS_H_13","H_9_13","H_0_13",15*60,6*3600,22*3600);
        addLine(tf,schedule,sc.getNetwork(),vehicles,vf,busType,
                "NS_H_26","H_9_26","H_0_26",15*60,6*3600,22*3600);
        addLine(tf,schedule,sc.getNetwork(),vehicles,vf,busType,
                "NS_B_13","B_9_13","B_0_13",15*60,6*3600,22*3600);
        addLine(tf,schedule,sc.getNetwork(),vehicles,vf,busType,
                "NS_B_26","B_9_26","B_0_26",15*60,6*3600,22*3600);
    }

    private static void addLine( TransitScheduleFactory tf,
            TransitSchedule schedule,
            Network net,
            Vehicles vehicles,
            VehiclesFactory vf,
            VehicleType busType,
            String lineId,
            String from, String to,
            int headway, int first, int last ) {
	TransitLine line = tf.createTransitLine(Id.create(lineId, TransitLine.class));
	schedule.addTransitLine(line);

		//  OUTBOUND 
		List<TransitRouteStop> stopsOut = new ArrayList<>();
		List<Id<Link>>         linksOut = buildRoute(
		net, from, to, stopsOut, tf, schedule, lineId, "out"
		);
		addDepartures(
		tf, line, "to_" + to + "_out",
		linksOut, stopsOut,
		headway, first, last,
		vehicles, vf, busType
		);

	    List<TransitRouteStop> stopsIn = new ArrayList<>();
	    List<Id<Link>>         linksIn = buildRoute(
	        net, to, from, stopsIn, tf, schedule, lineId, "in"
	    );
	    addDepartures(
	        tf, line, "to_" + from + "_in",
	        linksIn, stopsIn,
	        headway, first, last,
	        vehicles, vf, busType
	    );
	}

    private static List<Id<Link>> buildRoute( Network net,
            String fromId,
            String toId,
            List<TransitRouteStop> stops,
            TransitScheduleFactory tf,
            TransitSchedule schedule,
            String lineId,
            String direction ) {
		// 1) figure out whether it's a “horizontal” or “vertical” run
		String[] s1 = fromId.split("_"), s2 = toId.split("_");
		boolean horizontal = s1[1].equals(s2[1]);
		int fixed    = Integer.parseInt(horizontal ? s1[1] : s1[2]);
		int startIdx = Integer.parseInt(horizontal ? s1[2] : s1[1]);
		int endIdx   = Integer.parseInt(horizontal ? s2[2] : s2[1]);
		int step     = endIdx > startIdx ? +1 : -1;
		String prefix = s1[0];  // “H” or “B”

	    // 2) START‐OF‐LINE stop with its own facility ID
	    Id<TransitStopFacility> sf0 = Id.create(
	        "stop_" + fromId + "_" + lineId + "_" + direction,
	        TransitStopFacility.class
	    );
	    if (!schedule.getFacilities().containsKey(sf0)) {
	        Coord c = net.getNodes().get(Id.create(fromId, Node.class)).getCoord();
	        TransitStopFacility tsf = tf.createTransitStopFacility(sf0, c, false);
	        schedule.addStopFacility(tsf);
	    }
	    stops.add(tf.createTransitRouteStop(schedule.getFacilities().get(sf0), 0, 0));

	    // 3) build all the links and the downstream stops
	    List<Id<Link>> linkIds = new ArrayList<>();
	    for (int i = startIdx; i != endIdx; i += step) {
	        String a = horizontal
	                   ? prefix + "_" + fixed + "_" + i
	                   : prefix + "_" + i + "_" + fixed;
	        String b = horizontal
	                   ? prefix + "_" + fixed + "_" + (i + step)
	                   : prefix + "_" + (i + step) + "_" + fixed;
	        Id<Link> lid = Id.create(a + "_" + b, Link.class);
	        linkIds.add(lid);
	        Id<TransitStopFacility> sfB = Id.create(
	                "stop_" + b + "_" + lineId + "_" + direction,
	                TransitStopFacility.class
	            );
	            if (!schedule.getFacilities().containsKey(sfB)) {
	                Coord c = net.getNodes().get(Id.create(b, Node.class)).getCoord();
	                TransitStopFacility tsf = tf.createTransitStopFacility(sfB, c, false);
	                schedule.addStopFacility(tsf);
	            }
	            stops.add(tf.createTransitRouteStop(schedule.getFacilities().get(sfB), 0, 0));
	        }

	        return linkIds;
	    }

    private static void addDepartures(TransitScheduleFactory tf,
            TransitLine line,
            String suffix,
            List<Id<Link>> links,
            List<TransitRouteStop> stops,
            int headway,
            int first,
            int last,
            Vehicles vehicles,
            VehiclesFactory vf,
            VehicleType busType) {
    	// for stop i, use link i  (and for the very last stop, re-use the last link)
        for (int i = 0; i < stops.size(); i++) {
            TransitStopFacility tsf = stops.get(i).getStopFacility();
            // set its link:
            if (tsf.getLinkId() == null) {
                // stop i → link i (or final link for last stop)
                Id<Link> linkForThisStop = links.get(Math.min(i, links.size() - 1));
                tsf.setLinkId(linkForThisStop);
            }
        }

        // build and add the route
        Id<TransitRoute> rid = Id.create(line.getId() + "_" + suffix, TransitRoute.class);
        TransitRoute tr = tf.createTransitRoute(
            rid,
            RouteUtils.createNetworkRoute(links),
            stops,
            "bus"
        );
        line.addRoute(tr);

        // add departures
        for (int t = first; t <= last; t += headway) {
            Departure d = tf.createDeparture(
                Id.create(line.getId() + "_" + suffix + "_dep_" + t, Departure.class),
                t
            );
            Id<Vehicle> vid = Id.create(line.getId() + "_" + suffix + "_veh_" + t, Vehicle.class);
            vehicles.addVehicle(vf.createVehicle(vid, busType));
            d.setVehicleId(vid);
            tr.addDeparture(d);
        }
    }
}

[Lshanah]

See reply above

[kainagel]

glad to hear that. best wishes ...