Updates required in metrics.md file for the modified metric names #6706
Unanswered
Sidhartha-Biswal
asked this question in
Q&A
Replies: 1 comment
-
Technically the migration docs were meant for one-time 1.x to 2.0.0 migration. This specific change was a breaking change in both v1 and v2, so these docs aren't design to track such changes continuously. I am open to suggestion. At minimum we can put a disclaimer in those .md files saying that they are for specific versions, unless we want to keep maintaining the changes, which is a lot of overhead. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Hi
We are trying to uplift Jaeger to 1.65, while testing observed that there is change in metrics names. From the release page, found below breaking change commits.
#6287
jaeger_query --> jaeger_storage
jaeger_metricstore --> jaeger_storage
#6280
jaeger_cassandra --> jaeger_storage
jaeger_cassandra-archive --> jaeger_storage
jaeger_index_create --> jaeger_storage_index_create
Apart from above changes, when we have tested with 1.65 observed below metrics names also changed, is this change also expected?
jaeger_bulk_index --> jaeger_storage_bulk_index
I think metrics md files also needs to be updated with new names, currently still point to old metrics names
https://github.com/jaegertracing/jaeger/blob/v1.65.0/cmd/jaeger/docs/migration/elasticsearch-metrics.md
Beta Was this translation helpful? Give feedback.
All reactions