Send welcome email after email verification instead of at registration

[provenpeng]

Current behavior

Currently, Fief sends a welcome email immediately after user registration, before the user has verified their email address.

Problem

This approach has several issues:

1. User confusion: When users receive a welcome email before verifying their email, they might think they've already completed the verification process. This can lead to confusion when they later discover they still need to verify their email.

2. Wasted resources: Sending welcome emails to unverified addresses wastes resources, as many registrations might use temporary or incorrect email addresses that will never be verified.

3. Security concerns: Welcoming users before verification could potentially be exploited in phishing attempts, as it gives an appearance of legitimacy to unverified accounts.

4. Logical flow disruption: The natural user journey should be: register → verify → welcome. The current implementation disrupts this logical flow.

5. Potential deliverability issues: If a significant portion of welcome emails are sent to invalid addresses, it could negatively impact the sender's email reputation.

Proposed solution

Move the welcome email sending logic from the registration process to after email verification is successfully completed. This would:

• Create a more logical user journey
• Ensure welcome emails are only sent to verified users
• Reduce confusion about the verification status
• Save resources by not sending emails to potentially invalid addresses
• Improve overall security posture

Implementation approach

This would require:

1. Removing the welcome email sending from OnAfterRegisterTask
2. Adding welcome email sending logic to the email verification success flow
3. Updating relevant tests

Questions

• Are there any use cases where sending welcome emails before verification is necessary?
• Would this change affect any existing integrations?
• Should we consider making this behavior configurable?

[fief-bailiff[bot]]

Hail, @provenpeng 👋 Welcome to Fief's kingdom!

Our team will get back to you very soon to help.

In the meantime, take a minute to star our repository ⭐️

Want to support us?

Subscribe to one of our paid plan to help us continue our work and receive exclusive information and benefits! Starts at $5/month 🪙

Farewell!