Migrate source from SRCPF - LF not showing PF Dependency

[erk48188]

I migrated source from our IBM i to local folder, then tried to compile an RPGLE program which had a fair number of dependencies.

One file used by the program is a Logical File - which failed compiling because neither the Rules.MK nor the Makefile noticed a dependency on the PF.

The files in my explorer are:

• wake011l01.lf
• wake011p.pf

This is in Rules.mk:
WAKE011L01.FILE: wake011l01.lf

This is in Makefile
$(PREPATH)/WAKE011L01.FILE: QSRC/wake011l01.lf

Any help?

[erk48188]

After some debugging, I've somewhat solved my problem, but found an odd inconsistency with creating Rules.mk file using Source Orbit.

• This inconsistency is that sometimes SO would add the PF dependency to the LF entry, and sometimes it wouldn't.
• I reviewed the DDS in the SRCPF and could find no correlation - the dependency in the Rules.mk file was added with PFILE included the Library and also when the Library wasn't included. In other cases, it did not include the dependency when PFILE included the Library and other times did not include the dependency when Library was not included.
• I ended up having to edit my Rules.mk file, searching on LF, and adding the *.FILE dependency. Of the 56 instances of LFs, more than half were missing the PF dependency
• On another note - the dependency needs to be added with UPPER CASE.

If I can figure out the inconsistency of adding dependencies, I'll be closer to getting my team to move from SEU to VS Code!

Thanks.

[worksofliam]

@erk48188 this is great debugging. I have two notes for you:

1. I just pushed a release out for Source Orbit. Ensure you have the latest version from npm - unless you're using the VS Cofe extension, in which an update will be out for the end of the week.
2. If you're able to recreate it, make an issue under Source Orbit with the source code to recreate and then i can get to debugging.

I will do some investigating myself.

[erk48188]

@worksofliam A correction - there's no inconsistency.

• LF DDS with Library in PFILE (ERKLIB/ERKPF) is missing the Physical File dependency
• LF DDS without Library in PFILE (ERKPF) includes the Physical File dependency

Do you still require an issue or does the latest update (which I'll have to wait for the VS Code extension) cover this?

Thanks for all you do!

[worksofliam]

@erk48188 if you're able to share some source so I can recreate this, that would be amazing because I can have it fixed tomorrow or Monday.

You're welcome to share it here or in a new issue. Thank you