Github OIDC Setup Issue

[dukarc]

We are now looking into adding GitHub integration (OIDC + managed runners using runs-on.com as you suggested). While deploying github-oidc-provider, I got this warning:

│ "plat-gbl-dev-github-oidc-provider.terraform.tfvars.json". If you meant to use this value, add a "variable" block to
│ the configuration.
This plan has no changes:
No changes. Your infrastructure matches the configuration.

This happens for both commands:

atmos terraform plan github-oidc-provider --stack core-gbl-identity
atmos terraform plan github-oidc-provider --stack plat-gbl-dev

I tried several ways to ensure that variable is present, from adding enabled=true on several places under catalog/github-oidc-provider.yaml to adding them into components/terraform/aws-github-oidc-provider/variables.tfand even hardcoding components/terraform/aws-github-oidc-provider/main.tf. None of those attempts worked.

I also added the vars for Superadmin = true, but I am still getting the same outcome: no changes to be made.
Could you please point us on the right direction?

[milldr]

No changes. Your infrastructure matches the configuration.

Did you already deploy the provider earlier? Could you check the console to see if it's already there?

[dukarc]

Hmm I do see it .. perhaps there was a delay when Cristian was doing this last evening. Proceeding onward .. going to close this out. Thanks to all!

[Benbentwo]

│ "plat-gbl-dev-github-oidc-provider.terraform.tfvars.json". If you meant to use this value, add a "variable" block to
│ the configuration.

makes it sound like there's either no code there (vendor issue) or the tfvars generate by atmos is empty or invalid. can you double check the dir for components/terraform/github-oidc-provider isn't empty (no .tf files)

[dukarc]

@Benbentwo we have files for sure

[dukarc]

Closing out as we resolved .. think it maybe was a bad handoff. We resolved this after posting following the documentation.

[cmarquezrusso]

Just for the records, the issue is in the docs. We need to use aws-github-oidc-provider and not github-oidc-provider. Changing this fixed the issue