Offcanvas user login spins forever

[cahoskins]

I don't know when this started happening but one of my customers told me he couldn't log in last week. If you click the person icon on the top-right and try to log in, it will just spin forever.

This can be demonstrated at my staging site: https://6b5.042.myftpupload.com/

Note:

• The current theme is bootscore parent to show that my child theme is not doing anything weird.
• Every plugin except for Woocommerce is disabled
• Users can still login at /wp-login

Any ideas?

[crftwrk]

Hello,

tested your site and log in works as expected. Your user may have a very slow connection.

However, if you do not want to use the new AJAX login, simple disable it with a filter https://bootscore.me/documentation/woocommerce/#disable-ajax-login

Solved?

[cahoskins]

@crftwrk,

EDIT: I downgraded to Bootscore 6.1 (the tagged release before 6.2) and the login behavior works as expected. I guess I need to figure out what made it break :-( ? I will take a look at the 6.2 changes related to the ajax login in github. I really do want to use the new AJAX login but I'll disable it on my prod site so people can log in again.

My previous message BEFORE DOWNGRADE:

I don't believe the ajax-login is working on my site. I can reproduce this issue and I have had several others also reproduce. This is how you reproduce: from my staging site, click on the little person icon to log on. It opens the side-panel. Enter bogus credentials and click logon. It will spin and spin and 10 minutes later, it's still spinning. If I enter correct credentials, same thing.

[crftwrk]

I can confirm that your login is not working as expected https://6b5.042.myftpupload.com/. @Axos11 any idea? 👀

@cahoskins

EDIT: I downgraded to Bootscore 6.1

Please leave your staging site as it is with 6.2 for testing. For your live site, use latest 6.2 as well and restore default login with a filter in child's functions.php:

/*
 * Disable AJAX login
 */
add_filter('bootscore/wc_ajax_login', '__return_false');

[cahoskins]

@crftwrk, the autoupdater had already updated to 6.2 by the time you worked on it. I will leave it alone so it stays on 6.2.

I have a feeling that this has something to do with the REST API and not bootscore at all. Does the ajax end up calling a REST route? I made a test for the shortcode [woocommerce_my_account] and it logs in as expected. https://6b5.042.myftpupload.com/test-page/ but I think that does a post back and doesn't use ajax.

The reason why I suspect the REST is the problem is because sometimes I notice a strange message in the console about the user not logged in when it actually is. It doesn't seem to affect the site, however. This is the offending route: /wp-json/wp/v2/users/me?context=edit&_locale=user. I'm not sure how to confirm this.

[Axos11]

Hello @cahoskins ,
I looked at the issue on your staging site but it wouldn't return an response at all to the "wrong credentials" case.
I think we would have to take a look on your staging site. Otherwise I don't see any chance to figure out the issue.
As far as I know, @crftwrk has a form where you could submit the data if you like us to have a look at it.
https://bootscore.me/private-info-form/

As for your question. We are just using a custom ajax call. Thats it actually.

[cahoskins]

@crftwrk I filled out the private info. See: Cn9aXzKYPDwpKfbS5I65WXLv1QxQBaci

[crftwrk]

Thanks for sharing, but we need FTP as well.

Edit: The WP admin data is not correct.

[cahoskins]

g8JMg1bNdd97i9jA5KLenEoPMHkQd7EW

[cahoskins]

Feel free to make any changes you want. It's a staging site so I can wipe it away and regenerate it if I want.

[Axos11]

@cahoskins

it seems that godaddy does not like the way we try to determin the ip adress to prohibit spamming the endpoint.

If you replace the function bootscore_get_user_ip() with the following code you should be fine for now. Works now on staging. Will be implemented in bootscore soon i think ;)

function bootscore_get_user_ip() {
  global $user_ip;

  if (!is_null($user_ip)) { // We've already discovered the browser's IP address.
    return $user_ip;
  }

  if ( !empty($_SERVER['HTTP_CLIENT_IP']) ) {
    $user_ip = filter_var($_SERVER['HTTP_CLIENT_IP'], FILTER_VALIDATE_IP);
  } elseif ( !empty($_SERVER['HTTP_X_FORWARDED_FOR']) ) {
    $user_ip = filter_var($_SERVER['HTTP_X_FORWARDED_FOR'], FILTER_VALIDATE_IP);
  } else {
    $user_ip = filter_var($_SERVER['REMOTE_ADDR'], FILTER_VALIDATE_IP);
  }

    // If no IP was found -> Check for X-Forwarded-For (godaddy)
    if (empty($user_ip) && !empty($_SERVER['HTTP_X_FORWARDED_FOR'])) {
        $forwarded_ips = explode(',', $_SERVER['HTTP_X_FORWARDED_FOR']);
        foreach ($forwarded_ips as $ip) {
            $ip = trim($ip);
            if (filter_var($ip, FILTER_VALIDATE_IP)) {
                $user_ip = $ip;
                // The first found should be the correct one
                break;
            }
        }
    }

  return $user_ip;
}

[cahoskins]

Am I able to override this in my child theme by putting it in:

/bootscore-child/woocommerce/inc/wc-ajax-login.php ?

[Axos11]

@cahoskins Thanks for asking for the logic, that pointed out a mistake i made when rewriting my debugging code for your site.

I just added the section

    // If no IP was found -> Check for X-Forwarded-For (godaddy)
    if (empty($user_ip) && !empty($_SERVER['HTTP_X_FORWARDED_FOR'])) {
        $forwarded_ips = explode(',', $_SERVER['HTTP_X_FORWARDED_FOR']);
        foreach ($forwarded_ips as $ip) {
            $ip = trim($ip);
            if (filter_var($ip, FILTER_VALIDATE_IP)) {
                $user_ip = $ip;
                // The first found should be the correct one
                break;
            }
        }
    }

And actually it should take the first IP present in the list, not the last one.
I tested it on your site with my own ip and it was correctly detected.

Overwriting of inc files is not "that" easy as for standard template files. You would have to unregister the original version of the file and then register your file in the child theme.

[cahoskins]

RE: unregister original version and then register my file in the child theme: I'm using an example from @crftwrk that did the unregister thing for the swiper init js (see below). Can you do the same thing with php files? I'm assuming I would need a path other than "get_stylesheet_directory_uri()" .

/**
 * Dequeue swiper-init.js and enqueue custom
 */
function custom_swiper_init() {
  wp_deregister_script( 'swiper-init-js' );
  wp_dequeue_script( 'swiper-init-js' );

  wp_enqueue_script('swiper-custom-init-js', get_stylesheet_directory_uri() . '/assets/js/swiper-custom-init.js', array(), false, true);
}
add_action( 'wp_enqueue_scripts', 'custom_swiper_init', 11 );

[Axos11]

@cahoskins

i did something similar with the ajax-cart before the changes were implemented into bootscore. basically you have to remove the action in bootscore/woocommerce/wc-functions.php and then hook your own function instead of it. That issue should be addressed with the next update anyways as my PR was already confirmed

function bootscore_register_ajax_login_file() {
  if (apply_filters('bootscore/wc_ajax_login', true)) {
    require_once('inc/wc-ajax-login.php');
  }
}
add_action('after_setup_theme', 'bootscore_register_ajax_login_file');

Just look out. you have to use a remove_action in that case and look out that your removal hook runs after the registration but before the execution of the after_setup_theme hook.

[crftwrk]

Solved by #1051

@Axos11 Thank you 🙏

[cahoskins]

Thank you both. And @Axos11, do you ever sleep?