AMD Vivobook (TN3402QA) does not disable keyboard on lid-close

[berenddeschouwer]

The laptop does not disable the keyboard on lid-close. This means that squeezing the laptop (eg. in a full laptop bag) wakes up the laptop.

The laptop does suspend.

SUSE Tumbleweed, linux 6.6.11 (can try others)

Either lid-close isn't noticed, or the keyboard disable code isn't running.

Manually disabling the keyboard by enabling tablet mode results in the keyboard being re-enabled once suspend is active. Therefore I think that the BIOS (or EFI) re-enables the keyboard.

So, speculation:

• lid close isn't noticed (how do I confirm?)
• lid close is noticed, keyboard isn't disabled (is this the kernel's responsibility? acpi? bios?)
• lid close is noticed, keyboard is disabled, but BIOS re-enables it (bios setting???)

[ldrahnik]

At this moment I use AMD as well (UN5401QAB, Ubuntu 22.04 Elementary OS 7.1 Horus), I have an added device Lid Switch, and switch-lid event works. Disable functionality like suspend on LID close first, then run $ libinput debug-events and $ acpi_listen and do a close / unclose and post here outputs. Me:

$ sudo libinput debug-events
-event3   DEVICE_ADDED            Video Bus                         seat0 default group1  cap:k
-event0   DEVICE_ADDED            Lid Switch                        seat0 default group2  cap:S
-event1   DEVICE_ADDED            Power Button                      seat0 default group3  cap:k
-event5   DEVICE_ADDED            USB2.0 HD UVC WebCam: USB2.0 HD   seat0 default group4  cap:k
-event8   DEVICE_ADDED            ELAN9008:00 04F3:4065             seat0 default group5  cap:t  size 312x191mm ntouches 10 calib
-event11  DEVICE_ADDED            ELAN9008:00 04F3:4065 Stylus      seat0 default group5  cap:T  size 300x190mm calib
-event17  DEVICE_ADDED            ASUE140D:00 04F3:31B9 Mouse       seat0 default group6  cap:p left scroll-nat scroll-button
-event18  DEVICE_ADDED            ASUE140D:00 04F3:31B9 Touchpad    seat0 default group6  cap:pg  size 125x72mm tap(dl off) left scroll-nat scroll-2fg-edge click-buttonareas-clickfinger dwt-on
-event19  DEVICE_ADDED            ASUE140D:00 04F3:31B9 Keyboard    seat0 default group6  cap:k
-event4   DEVICE_ADDED            Asus WMI hotkeys                  seat0 default group7  cap:k
-event2   DEVICE_ADDED            AT Translated Set 2 keyboard      seat0 default group8  cap:k
-event16  DEVICE_ADDED            Asus WMI hotkeys                  seat0 default group9  cap:k
-event21  DEVICE_ADDED            ASUE140D:00 04F3:31B9 NumberPad   seat0 default group10 cap:kp left scroll-nat
-event0   SWITCH_TOGGLE           +0.000s	switch lid state 1
 event0   SWITCH_TOGGLE           +3.381s	switch lid state 0

and

$ acpi_listen
button/lid LID close
button/lid LID open

[berenddeschouwer]

OK, so the lid switch works.

Linux thinks the keyboard is disabled, too

-event8 SWITCH_TOGGLE +2.878s switch lid state 1
event8 SWITCH_TOGGLE +4.832s switch lid state 0
-event16 DEVICE_REMOVED AT Translated Set 2 keyboard seat0 default group7 cap:k
-event16 DEVICE_ADDED AT Translated Set 2 keyboard seat0 default group9 cap:k

[berenddeschouwer]

Confirmed the keyboard is still active with the lid closed, making it way too easy to wake up.

[ldrahnik]

@berenddeschouwer Please copy and paste the entire output of $ sudo libinput debug-events when is flip done, order of commands is important

[berenddeschouwer]

$ sudo libinput debug-events
-event3   DEVICE_ADDED            Video Bus                         seat0 default group1  cap:k
-event8   DEVICE_ADDED            Lid Switch                        seat0 default group2  cap:S
-event9   DEVICE_ADDED            Power Button                      seat0 default group3  cap:k
-event1   DEVICE_ADDED            WDHT1F01:00 2575:0911             seat0 default group4  cap:t  size 301x188mm ntouches 10 calib
-event2   DEVICE_ADDED            WDHT1F01:00 2575:0911 Stylus      seat0 default group4  cap:T  size 301x188mm calib
-event4   DEVICE_ADDED            ASUE140D:00 04F3:31BC Mouse       seat0 default group5  cap:p left scroll-nat scroll-button
-event5   DEVICE_ADDED            ASUE140D:00 04F3:31BC Touchpad    seat0 default group5  cap:pg  size 125x72mm tap(dl off) left scroll-nat scroll-2fg-edge click-buttonareas-clickfinger dwt-on dwtp-on
-event6   DEVICE_ADDED            ASUE140D:00 04F3:31BC Keyboard    seat0 default group5  cap:k
-event10  DEVICE_ADDED            Asus WMI hotkeys                  seat0 default group6  cap:k
-event16  DEVICE_ADDED            AT Translated Set 2 keyboard      seat0 default group7  cap:k
-event0   DEVICE_ADDED            Asus WMI accel tablet mode        seat0 default group8  cap:kS
-event8   SWITCH_TOGGLE           +0.000s	switch lid state 1
$$$ lid closed
$$$ lid opened
 event8   SWITCH_TOGGLE           +1.800s	switch lid state 0
-event16  DEVICE_REMOVED          AT Translated Set 2 keyboard      seat0 default group7  cap:k
-event16  DEVICE_ADDED            AT Translated Set 2 keyboard      seat0 default group9  cap:k
$$$ start typing unlock password
 event16  KEYBOARD_KEY            +3.557s	*** (-1) pressed
 event16  KEYBOARD_KEY            +3.635s	*** (-1) released
 event16  KEYBOARD_KEY            +3.715s	*** (-1) pressed
 event16  KEYBOARD_KEY            +3.794s	*** (-1) released`

Interesting that the keyboard gets removed (and re-added) after the lid is opened. I don't know if that's just a timing thing.

[ldrahnik]

@berenddeschouwer Well, so it is a not kernel-specific problem. Could you download and try another distribution? Whether the problem persists?

[berenddeschouwer]

Tried Fedora Rawhide. Same problem.

[ldrahnik]

@berenddeschouwer I work on improvement of WMI hotkeys driver which might solve your problem, its WIP yet but this branch with my description below might fix your problem already.

First, you need before installing change [asus_wmi_hotkeys.py; row 49] Asus Keyboard to Lid Switch, then add new layout configuration file with content below (find id of your keyboard which do you want to disable using xinput, it should be that one with translate in name I guess):

from libevdev import EV_SW, InputEvent

key_wmi_lid_switch_disables_keyboard = [
    InputEvent(EV_SW.SW_LID, 1),
    'xinput disable <change to your keyboard ID which do you want disable: e.g. 19>'
]

key_wmi_lid_switch_enables_keyboard = [
    InputEvent(EV_SW.SW_LID, 0),
    'xinput enable <change to your keyboard ID which do you want disable: e.g. 19>'
]


keys_wmi = [
    key_wmi_lid_switch_disables_keyboard,
    key_wmi_lid_switch_enables_keyboard
]

allowed_listen_to_devices = [
    "Asus keyboard",              # listening by default
    "Asus WMI hotkeys",           # listening by default
    "Lid Switch",                 # NOT listening by default5

[ldrahnik]

@berenddeschouwer The mentioned driver is updated about sending custom commands, so for your case it should be prepared:

• git clone
• add a new layout configuration file with the content below (first find the id of your keyboard which you want to disable using $ xinput, I guess it should be the one with translate in the name):

from libevdev import EV_SW, InputEvent

key_wmi_tablet_mode_disables_keyboard = [
    InputEvent(EV_SW.SW_LID, 1),
    'xinput disable <change to your keyboard ID which do you want disable: e.g. 19>'
]

key_wmi_tablet_mode_enables_keyboard = [
    InputEvent(EV_SW.SW_LID, 0),
    'xinput enable <change to your keyboard ID which do you want disable: e.g. 19>'
]


keys_wmi = [
    key_wmi_lid_switch_disables_keyboard,
    key_wmi_lid_switch_enables_keyboard
]

allowed_listen_to_devices = [
    "Asus keyboard",              # listening by default
    "Asus WMI hotkeys",           # listening by default
    "Lid Switch",                 # NOT listening by default
]

• install driver and select during install process newly added configuration

Please let me know about results :)

[ldrahnik]

Can be reopened

[berenddeschouwer]

I think that the problem is that the ACPI DSDT config only allows idle, and not deep sleep, as shown by /sys/power/mem_sleep:
[s2idle]

There's no S3, S4 or deep.

However, hibernate seems to work, even with an encrypted disk, and that switches the keyboard off. That also fixes my problem.

(sidenote: both Fedora and SUSE have now made it unnecessarily complicated to even test if hibernate works.)

[ldrahnik]

@berenddeschouwer You can also look what contains this file $ cat /proc/acpi/wakeup, someone solved this way the same problem with touchpad here.

[ldrahnik]

@berenddeschouwer You might be interested in this too.

[berenddeschouwer]

Some useful information.

First, on acpi wakeup

The touchpad and keyboard aren't listed in /proc/acpi/wakeup. There's only one enabled device. Disabling that didn't have an effect:
Device S-state Status Sysfs node
GPP1 S4 *disabled
GP17 S4 *enabled pci:0000:00:08.1

The touchpad and keyboard don't have specific wakeup devices in /sys I could find. They're under /sys/devices/platform/. I could find 144 'wakeup' files in /sys, but none that match for keyboard and touchpad.

The closest is /sys/devices/platform/i8042/serio0/power/wakeup (keyboard port), but changing that doesn't work.

Then DSDT and sleep

The DSDT only allows for S2idle. This is because _S3 is labelled as XS3 in the DSDT. This looks like a known thing: https://gist.github.com/raenye/d6645d7039a6136ccfb055e0f8517698

If I patch the DSDT to use _S3, proper suspend happens, and during proper suspend the keyboard and touchpad are correctly inactive. The lid and power button still work.

However, the video card doesn't wake up. I'd need to fix that somehow.
03:00.0 VGA compatible controller: Advanced Micro Devices, Inc. [AMD/ATI] Cezanne [Radeon Vega Series / Radeon Vega Mobile Series] (rev c5)

[berenddeschouwer]

I have now noticed messages like this on suspend:

[ 6345.293008] atkbd serio0: Failed to deactivate keyboard on isa0060/serio0
[ 6345.903236] atkbd serio0: Failed to enable keyboard on isa0060/serio0

I assume it's related.

There is a kernel bug for this at:

https://bugzilla.kernel.org/show_bug.cgi?id=209923