Is there an event for clients disconnecting?

[quaris628]

I see in hangar.mast there's a find_stray_craft_loop that checks for fighters whose clients have disconnected.
Is that the best way to check for disconnected clients to clean up after them, or is there an event that's triggered when clients either gracefully disconnect or time out? E.g. //client_disconnected? Or is there perhaps another more graceful/performant way to clean up after disconnected clients?

[dougreichard]

Disconnect does not have an event per say. I detect when it occurs by seeing that the client is no longer in the client list.

https://github.com/artemis-sbs/sbs_utils/blob/master/sbs_utils/gui.py#L331

This fires what I call a "FakeEvent" which is used more internally. The Story Page then emits a signal "client_disconnect"

https://github.com/artemis-sbs/sbs_utils/blob/master/sbs_utils/mast_sbs/maststorypage.py#L725

//signal/client_disconnect
//shared/signal/client_disconnect
on signal client_disconnect

Should hangar use that? Maybe. The signal may not have existed.

[dougreichard]

This code has been around for a while, but to answer the question I'm running 1.1.3.

[dougreichard]

Silly question. Is the file imported? i.e. you sure its included.

[quaris628]

Yeah, it's in hangar.mast, the rest of which works. The issue was a silly typo on my part: client_disconnected instead of client_disconnect. (I also expected a syntax error if the route label was invalid, but I can see why signals are an exception to that.)

[dougreichard]

Cool. I made the same typo a couple of times in this thread (I think I caught them) but totally get it.

Yeah - kind of hard to catch an error. You have to register, before it is emitted. Short of declaring the intent to emit, but MAST is generally a laid back language and that feels like .NET or Java. I'll think about it though.

[dougreichard]

Added #272