[Candlelight] Issues & Concerns with the Wine Glasses

[druidicmage]

Issue Title

[Candlelight] Issues with the Wine Glasses

Minecraft Version

1.20.1 Fabric

Mod

Candlelight

Mod Version

Candlelight 2.0.4

Latest Version

• Yes. I'm using the latest Version.

Issue Description

When filling glasses with wine and potions, the texture of the glasses don't really "change". They only light up slightly, and the "full" texture can only be seen at an angle.

Attempted with the following:

• Noir Wine
• Mellohi Wine
• Red Wine
• Potion of Swiftness
• Potion of Fire Resistance
• Potion of Poison

Additionally:

• All wine glass effects last for 5 minutes. This includes potion effects that are only supposed to last for 1:30 minutes, such as poison. I think this is extremely busted, especially since the texture of the full glass is always the same color, meaning you can't tell what potion it is.
• You can put things like Beer and Whiskey on the table set, and when you eat them, you don't get the effect, or the glass/mug back. It might be a good idea to prevent players from trying to do that, since pouring drinks into glasses would likely encourage them to try it, and then lose their drinks.

Steps to Reproduce

1. Pour your choice of wine or potion
2. Get results

Logs

Client Log: https://mclo.gs/8SXrcLw
Server Log: https://mclo.gs/matzJSb

Minimal Instance Test

• Yes, I've tested on a minimal instance.

Check for Similar Issues

• Yes, I have checked for similar issues.

[satisfyu]

Welcome to Minecrafts rendering logic. Theres no way to fix it.

[druidicmage]

That's a shame. The other things?

[satisfyu]

That's a shame. The other things?

I could add a blacklist for certain items. That would be the easiest method.

Another would be to adjust the logic so that items that use a container when crafted (e.g. bowls, most farm&charm food items as well as from some other mods) and then return it. To be honest, i still have no idea how i could manage this query.

[druidicmage]

I see. My main concern is the timer for the effects, the other stuff is not a huge issue.

[satisfyu]

I see. My main concern is the timer for the effects, the other stuff is not a huge issue.

I have added that it now recognises and applies not only the effect but also the effect duration.

[github-actions[bot]]

This issue hasn't seen any activity for 30 days.
To help move things forward, it's now marked as help wanted.
If you're interested in contributing, feel free to take a look!

[github-actions[bot]]

This issue has been marked as fixed and will be rolled out with the next release of the respective mod.

Thank you for your report and for being an active part of the [Let's Do] Series! ❤️