Updated from SDL2 2.30.9 to SDL2 2.32.4 and now every formula that depended on SDL2 segfaults

[thenumbernine]

Output of brew config

HOMEBREW_VERSION: 4.4.31
ORIGIN: https://github.com/Homebrew/brew
HEAD: 0046519c08cd3967e0934c82195361ac7e76c567
Last commit: 11 hours ago
Branch: stable
Core tap JSON: 15 Apr 09:05 UTC
Core cask tap JSON: 15 Apr 09:05 UTC
HOMEBREW_PREFIX: /usr/local
HOMEBREW_CASK_OPTS: []
HOMEBREW_MAKE_JOBS: 16
Homebrew Ruby: 3.3.8 => /usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/3.3.8/bin/ruby
CPU: 16-core 64-bit kabylake
Clang: 16.0.0 build 1600
Git: 2.39.5 => /Applications/Xcode.app/Contents/Developer/usr/bin/git
Curl: 8.7.1 => /usr/bin/curl
macOS: 14.7.5-x86_64
CLT: 16.2.0.0.1.1733547573
Xcode: 16.2

Output of brew doctor

Please note that these warnings are just used to help the Homebrew maintainers
with debugging if you file an issue. If everything you use Homebrew for is
working fine: please don't worry or file an issue; just ignore this. Thanks!

Warning: Some installed formulae are deprecated or disabled.
You should find replacements for the following formulae:
  icu4c@76
  mesalib-glw

Warning: Unbrewed dylibs were found in /usr/local/lib.
If you didn't put them there on purpose they could cause problems when
building Homebrew formulae and may need to be deleted.

Unexpected dylibs:
  /usr/local/lib/libcimgui_sdl.dylib
  /usr/local/lib/libclip.dylib
  /usr/local/lib/libluajit-5.1.2.1.1723681758.dylib

Warning: Unbrewed header files were found in /usr/local/include.
If you didn't put them there on purpose they could cause problems when
building Homebrew formulae and may need to be deleted.

Unexpected header files:
  /usr/local/include/cclip.h
  /usr/local/include/cimgui.h
  /usr/local/include/lua-5.0.3/*
  /usr/local/include/lua-5.1.5/*
  /usr/local/include/lua-5.2.4/*
  /usr/local/include/lua-5.3.6/*
  /usr/local/include/lua-5.4.7/*
  /usr/local/include/luajit-2.1/*

Warning: Unbrewed '.pc' files were found in /usr/local/lib/pkgconfig.
If you didn't put them there on purpose they could cause problems when
building Homebrew formulae and may need to be deleted.

Unexpected '.pc' files:
  /usr/local/lib/pkgconfig/luajit.pc

Warning: Unbrewed static libraries were found in /usr/local/lib.
If you didn't put them there on purpose they could cause problems when
building Homebrew formulae and may need to be deleted.

Unexpected static libraries:
  /usr/local/lib/libluajit-5.1-v2.1-20250117.a
  /usr/local/lib/libluajit-5.1.a

Warning: You have unlinked kegs in your Cellar.
Leaving kegs unlinked can lead to build-trouble and cause formulae that depend on
those kegs to fail to run properly once built. Run `brew link` on these:
  lua

Description of issue

I updated from SDL2 2.30.9 to SDL2 2.32.4 and now every formula that depended on SDL2 segfaults.

What other formula that depend on SDL2 are also now segfaulting? dosbox-x, fceux, ffmpeg, mgba, ppsspp, gzdoom ... probably others. It seems like every single one that depends on SDL2.

For what it's worth, SDL2 2.32.4 works fine on Windows.

Here's a minimal test case program using SDL2 to reproduce the segfault:

// clang++ -lSDL2 src/test.cpp ... crashes after SDL_SetWindowSize
#include <SDL2/SDL.h>
#include <iostream>

int main(int argc, char** argv) {
	int err = SDL_Init(SDL_INIT_VIDEO);
	if (err) {
		std::cerr << "SDL_Init failed with error code " << err << std::endl;
		exit(1);
	}

	char const * title = "test";
	int windowSizeX = 640;
	int windowSizeY = 480;
	int windowFlags = SDL_WINDOW_RESIZABLE | SDL_WINDOW_SHOWN;
	SDL_Window * window = SDL_CreateWindow(
		title,						// title
		SDL_WINDOWPOS_CENTERED,		// x
		SDL_WINDOWPOS_CENTERED,		// y
		windowSizeX,				// w
		windowSizeY,				// h
		windowFlags					// flags
	);
	std::cout << "SDL_CreateWindow = " << window << std::endl;
	if (!window) {
		std::cerr << "SDL_CreateWindow failed with error code " << SDL_GetError() << std::endl;
		exit(1);
	}

	// segfaults in SDL_SetWindowSize:
	//SDL_SetWindowSize(window, windowSizeX, windowSizeY);

	SDL_Event event;

	bool done = false;
	while (!done) {
		// segfaults in SDL_PollEvent:
		while (SDL_PollEvent(&event) > 0) {
			switch (event.type) {
			case SDL_QUIT:
				done = true;
				break;
			/*
			case SDL_WINDOWEVENT:
				switch (event.window.event) {
				case SDL_WINDOWEVENT_RESIZED:
					screenSize.x = event.window.data1;
					screenSize.y = event.window.data2;
					aspectRatio = (float)screenSize.x / (float)screenSize.y;
					onResize();
					break;
				}
				break;
			*/
			case SDL_KEYDOWN:
				if (event.key.keysym.sym == SDLK_F4 && (event.key.keysym.mod & KMOD_ALT) != 0) {
					done = true;
				}
				if (event.key.keysym.sym == SDLK_q && (event.key.keysym.mod & KMOD_GUI) != 0) {
					done = true;
				}
				break;
			}
		}
	}
	
	std::cout << "SDL_DestroyWindow()..." << std::endl;
	SDL_DestroyWindow(window);
	
	std::cout << "SDL_Quit()..." << std::endl;
	SDL_Quit();

	std::cout << "DONE!" << std::endl;

	return 0;
}

a stack trace of where it crashed:

* thread #1, queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, address=0xbad4007)
  * frame #0: 0x000000000bad4007
    frame #1: 0x00007ff81f1a5c29 AppKit`+[NSOpenGLContext currentContext] + 12
    frame #2: 0x00000001008768f9 libSDL2-2.0.0.dylib`ScheduleContextUpdates + 120
    frame #3: 0x0000000100879326 libSDL2-2.0.0.dylib`-[SDLView updateLayer] + 111
    frame #4: 0x00007ff81ef49ae4 AppKit`_NSViewUpdateLayer + 98
    frame #5: 0x00007ff81ee738c6 AppKit`+[NSAppearance _performWithCurrentAppearance:usingBlock:] + 68
    frame #6: 0x00007ff81f5abeba AppKit`__29-[NSViewBackingLayer display]_block_invoke + 126
    frame #7: 0x00007ff81eeadd5c AppKit`-[NSFocusStack performWithFocusView:inWindow:usingBlock:] + 92
    frame #8: 0x00007ff81f5ab773 AppKit`-[NSViewBackingLayer display] + 278
    frame #9: 0x00007ff823e1d051 QuartzCore`CA::Layer::display_if_needed(CA::Transaction*) + 867
    frame #10: 0x00007ff823fb53f0 QuartzCore`CA::Context::commit_transaction(CA::Transaction*, double, double*) + 758
    frame #11: 0x00007ff823dfde99 QuartzCore`CA::Transaction::commit() + 725
    frame #12: 0x00007ff81efe2a6d AppKit`__62+[CATransaction(NSCATransaction) NS_setFlushesWithDisplayLink]_block_invoke + 285
    frame #13: 0x00007ff81fad3844 AppKit`___NSRunLoopObserverCreateWithHandler_block_invoke + 41
    frame #14: 0x00007ff81b814476 CoreFoundation`__CFRUNLOOP_IS_CALLING_OUT_TO_AN_OBSERVER_CALLBACK_FUNCTION__ + 23
    frame #15: 0x00007ff81b81439a CoreFoundation`__CFRunLoopDoObservers + 493
    frame #16: 0x00007ff81b81391c CoreFoundation`__CFRunLoopRun + 850
    frame #17: 0x00007ff81b813002 CoreFoundation`CFRunLoopRunSpecific + 557
    frame #18: 0x00007ff826235a09 HIToolbox`RunCurrentEventLoopInMode + 292
    frame #19: 0x00007ff826235646 HIToolbox`ReceiveNextEventCommon + 201
    frame #20: 0x00007ff826235561 HIToolbox`_BlockUntilNextEventMatchingListInModeWithFilter + 66
    frame #21: 0x00007ff81ee86161 AppKit`_DPSNextEvent + 880
    frame #22: 0x00007ff81f79aae0 AppKit`-[NSApplication(NSEventRouting) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 1273
    frame #23: 0x000000010086daa8 libSDL2-2.0.0.dylib`Cocoa_PumpEventsUntilDate + 84
    frame #24: 0x000000010086dc7d libSDL2-2.0.0.dylib`Cocoa_PumpEvents + 59
    frame #25: 0x00000001007d9ccd libSDL2-2.0.0.dylib`SDL_PumpEventsInternal + 55
    frame #26: 0x00000001007d9dd7 libSDL2-2.0.0.dylib`SDL_WaitEventTimeout_REAL + 85
    frame #27: 0x0000000100001076 a.out`main + 390
    frame #28: 0x00007ff81b3ac345 dyld`start + 1909

The /usr/local/opt/sdl2 is in fact pointed to ../Cellar/sdl2/2.32.4 and not somewhere else:

% ls -al /usr/local/opt/sdl2
/usr/local/opt/sdl2 -> ../Cellar/sdl2/2.32.4

Here's a minimal test case to reproduce the segfault in SDL3:

// clang++ -lSDL3 src/test.cpp ... crashes in SDL_PollEvent->SDL_WaitEventTimeoutNS ... or in SDL_SetWindowSize if I uncomment it ...
#include <SDL3/SDL.h>
#include <iostream>

int main(int argc, char** argv) {
	if (!SDL_Init(SDL_INIT_VIDEO)) {
		std::cerr << "SDL_Init failed with error code " << SDL_GetError() << std::endl;
		exit(1);
	}

	char const * title = "test";
	int windowSizeX = 640;
	int windowSizeY = 480;
	int windowFlags = 0;//SDL_WINDOW_RESIZABLE | SDL_WINDOW_OPENGL;
	SDL_Window * window = SDL_CreateWindow(
		title,						// title
		windowSizeX,				// w
		windowSizeY,				// h
		windowFlags					// flags
	);
	std::cout << "SDL_CreateWindow = " << window << std::endl;
	if (!window) {
		std::cerr << "SDL_CreateWindow failed with error code " << SDL_GetError() << std::endl;
		exit(1);
	}

	// segfaults in SDL_SetWindowSize:
	//SDL_SetWindowSize(window, windowSizeX, windowSizeY);

	SDL_Event event;

	bool done = false;
	while (!done) {
		// segfaults in SDL_PollEvent:
		while (SDL_PollEvent(&event) > 0) {
			switch (event.type) {
			case SDL_EVENT_QUIT:
				done = true;
				break;
			/*
			case SDL_EVENT_WINDOW_RESIZED:
				screenSize.x = event.window.data1;
				screenSize.y = event.window.data2;
				aspectRatio = (float)screenSize.x / (float)screenSize.y;
				onResize();
				break;
			*/
			case SDL_EVENT_KEY_DOWN:
				if (event.key.key == SDLK_F4 && (event.key.mod & SDL_KMOD_ALT) != 0) {
					done = true;
				}
				if (event.key.key == SDLK_Q && (event.key.mod & SDL_KMOD_GUI) != 0) {
					done = true;
				}
				break;
			}
		}
	}
	
	std::cout << "SDL_DestroyWindow()..." << std::endl;
	SDL_DestroyWindow(window);
	
	std::cout << "SDL_Quit()..." << std::endl;
	SDL_Quit();

	std::cout << "DONE!" << std::endl;

	return 0;
}

I've rebuilt SDL2 2.32.4 on my own machine in debug mode and this is where things are going wrong:

frame #1: 0x00007ff81f1a5c29 AppKit`+[NSOpenGLContext currentContext] + 12
AppKit`+[NSOpenGLContext currentContext]:
->  0x7ff81f1a5c29 <+12>: movq   %rax, %rbx
    0x7ff81f1a5c2c <+15>: callq  0x7ff81ee595f5 ; __NSAppKitGetThreadSpecificData
    0x7ff81f1a5c31 <+20>: movq   0xe8(%rax), %rdi
    0x7ff81f1a5c38 <+27>: testq  %rdi, %rdi
(lldb) f 2
frame #2: 0x0000000100b1cd3e libSDL2-2.0d.0.dylib`ScheduleContextUpdates(data=0x0000600000699440) at SDL_cocoawindow.m:276:22
   273 	        return;
   274 	    }
   275 	
-> 276 	    currentContext = [NSOpenGLContext currentContext];
   277 	    contexts = data.nscontexts;
   278 	    @synchronized (contexts) {
   279 	        for (SDLOpenGLContext *context in contexts) {
(lldb) print currentContext
(NSOpenGLContext *) nil

[SMillerDev]

What does brew outdated say?

[thenumbernine]

Nothing, crashes persist.

[thenumbernine]

I uninstalled mesalib-glw, mesa-glu, and mesa ... and now everything is working again.