Failure in build leads to broken install

[unphased]

Output of brew config

❯ brew config
HOMEBREW_VERSION: 4.0.9
ORIGIN: https://github.com/Homebrew/brew
HEAD: 584588afb4ab557bcc0536f2794b4d043c333bb9
Last commit: 7 days ago
Core tap origin: https://github.com/Homebrew/homebrew-core
Core tap HEAD: ea17bc487111c51ca0f52f1720ce2b8d6c9ee8c1
Core tap last commit: 5 weeks ago
Core tap branch: master
Core tap JSON: 27 Mar 03:30 UTC
HOMEBREW_PREFIX: /opt/homebrew
HOMEBREW_CASK_OPTS: []
HOMEBREW_EDITOR: nvim
HOMEBREW_MAKE_JOBS: 10
Homebrew Ruby: 2.6.10 => /System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/bin/ruby
CPU: 10-core 64-bit arm_firestorm_icestorm
Clang: 14.0.0 build 1400
Git: 2.33.1 => /opt/homebrew/bin/git
Curl: 7.79.1 => /usr/bin/curl
macOS: 12.6.2-arm64
CLT: 14.2.0.0.1.1668646533
Xcode: 14.2
Rosetta 2: false

Output of brew doctor

❯ brew doctor
Please note that these warnings are just used to help the Homebrew maintainers
with debugging if you file an issue. If everything you use Homebrew for is
working fine: please don't worry or file an issue; just ignore this. Thanks!

Warning: Some installed formulae are deprecated or disabled.
You should find replacements for the following formulae:
  antibody

Warning: You have unlinked kegs in your Cellar.
Leaving kegs unlinked can lead to build-trouble and cause formulae that depend on
those kegs to fail to run properly once built. Run `brew link` on these:
  neovim

Description of issue

==> Upgrading 1 outdated package:
neovim HEAD-286777c -> HEAD-bad218c
==> Fetching dependencies for neovim: luajit, msgpack and cmake
==> Fetching luajit
==> Downloading https://ghcr.io/v2/homebrew/core/luajit/manifests/2.1.0-beta3-20230221.4
######################################################################## 100.0%
==> Downloading https://ghcr.io/v2/homebrew/core/luajit/blobs/sha256:2319bb87370f3af7e867b018cee66e4e2a47fb57a06482d504b6af3efe07beb3
==> Downloading from https://pkg-containers.githubusercontent.com/ghcr1/blobs/sha256:2319bb87370f3af7e867b018cee66e4e2a47fb57a06482d504b6af3efe07beb3?se=2023-03-27T03%3A40%3A00Z&sig=PVJMWk3EF0E4FKZO5brgBIKRNCNqoE4lrQPwVFrcMIw%3D&sp=r&spr=https&sr=b&sv=2019-
######################################################################## 100.0%
==> Fetching msgpack
==> Downloading https://ghcr.io/v2/homebrew/core/msgpack/manifests/6.0.0
######################################################################## 100.0%
==> Downloading https://ghcr.io/v2/homebrew/core/msgpack/blobs/sha256:1d14abff9537f4d85dee74c10ce6f73fafa8e8719c5be05bfda9a836cbe732ad
==> Downloading from https://pkg-containers.githubusercontent.com/ghcr1/blobs/sha256:1d14abff9537f4d85dee74c10ce6f73fafa8e8719c5be05bfda9a836cbe732ad?se=2023-03-27T03%3A40%3A00Z&sig=VJpfgqZScNclsIZfVYRKv7ypO8eicsSbTAMO%2FKQrcV0%3D&sp=r&spr=https&sr=b&sv=201
######################################################################## 100.0%
==> Fetching cmake
==> Downloading https://ghcr.io/v2/homebrew/core/cmake/manifests/3.26.1
######################################################################## 100.0%
==> Downloading https://ghcr.io/v2/homebrew/core/cmake/blobs/sha256:c2a8ee7ce8329d1a6301b0b8b0354474e8414d2ec68a75d74fb59a6c613dfb9b
==> Downloading from https://pkg-containers.githubusercontent.com/ghcr1/blobs/sha256:c2a8ee7ce8329d1a6301b0b8b0354474e8414d2ec68a75d74fb59a6c613dfb9b?se=2023-03-27T03%3A40%3A00Z&sig=jDhg8Bifmd%2B4wH06hc%2FlsjF1zRqjsu7JGbUxwaE5q%2Bo%3D&sp=r&spr=https&sr=b&sv
######################################################################## 100.0%
==> Fetching neovim
==> Downloading https://raw.githubusercontent.com/Homebrew/homebrew-core/df644e71f61d8a63aa2b22e639aaab18d2bfbe93/Formula/neovim.rb
######################################################################## 100.0%
==> Downloading https://github.com/libmpack/libmpack-lua/releases/download/1.0.8/libmpack-lua-1.0.8.tar.gz
==> Downloading from https://objects.githubusercontent.com/github-production-release-asset-2e65be/85478740/b1f22d00-96bb-11e9-9eb9-98ea3bea58c7?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIAIWNJYAX4CSVEH53A%2F20230327%2Fus-east-1%2Fs3%2Faws4_request
######################################################################## 100.0%
==> Downloading https://luarocks.org/manifests/gvvaughan/lpeg-1.0.2-1.src.rock
######################################################################## 100.0%
==> Cloning https://github.com/neovim/neovim.git
Updating /Users/slu/Library/Caches/Homebrew/neovim--git
==> Checking out branch master
Already on 'master'
Your branch is up to date with 'origin/master'.
HEAD is now at bad218cd6 vim-patch:9.0.1429: invalid memory access when ending insert mode (#22792)
==> Upgrading neovim
  HEAD-286777c -> HEAD-bad218c

==> Installing dependencies for neovim: cmake, luajit and msgpack
==> Installing neovim dependency: cmake
==> Pouring cmake--3.26.1.arm64_monterey.bottle.tar.gz
🍺  /opt/homebrew/Cellar/cmake/3.26.1: 3,188 files, 46.4MB
==> Installing neovim dependency: luajit
==> Pouring luajit--2.1.0-beta3-20230221.4.arm64_monterey.bottle.tar.gz
🍺  /opt/homebrew/Cellar/luajit/2.1.0-beta3-20230221.4: 55 files, 2.1MB
==> Installing neovim dependency: msgpack
==> Pouring msgpack--6.0.0.arm64_monterey.bottle.tar.gz
🍺  /opt/homebrew/Cellar/msgpack/6.0.0: 38 files, 220.5KB
==> Installing neovim --HEAD
Error: Failure while executing; `luarocks unpack --lua-dir=/opt/homebrew/opt/luajit mpack-1.0.8-0.rockspec --tree=/private/tmp/neovim-20230326-37754-2qmaw8/deps-build` exited with 1. Here's the output:

I ran this command: brew upgrade neovim --fetch-HEAD in an attempt to update nvim to the latest code. After the above output, the nvim executable is just gone now.

It is my understanding that if a build cannot complete due to any issues that the system should be left in the state that it was in. I guess this is not the case?

[carlocab]

It should, but I think this doesn't really work for --HEAD. Try doing brew link --HEAD neovim.

[unphased]

Thanks. I figured that wasn't going to do anything useful since the build clearly failed before it got into the meat of the rebuild. See the output of the successful run I just had

❯ brew upgrade neovim --fetch-HEAD                              lsp-zero[✦]dbd56d2[✭]1d9h45m
==> Downloading https://formulae.brew.sh/api/formula.jws.json

==> Downloading https://formulae.brew.sh/api/cask.jws.json

==> Upgrading 1 outdated package:
neovim HEAD-286777c -> HEAD-bad218c
==> Fetching neovim
==> Downloading https://raw.githubusercontent.com/Homebrew/homebrew-core/ae323cee4af4d720333d
Already downloaded: /Users/slu/Library/Caches/Homebrew/downloads/b702731e809a53e0376b43b7a4fdf26907089f5097cc7090683ccefb4691c766--neovim.rb
==> Downloading https://github.com/libmpack/libmpack-lua/releases/download/1.0.8/libmpack-lua
Already downloaded: /Users/slu/Library/Caches/Homebrew/downloads/4b91349796a66e38e93acd77e6ca14212c869090429fd88271def2be5293d83f--libmpack-lua-1.0.8.tar.gz
==> Downloading https://luarocks.org/manifests/gvvaughan/lpeg-1.0.2-1.src.rock
Already downloaded: /Users/slu/Library/Caches/Homebrew/downloads/0bc17975f0cf3981083172aa7da329b874e5780fa81494f5dd07d0665fcec23b--lpeg-1.0.2-1.src.rock
==> Cloning https://github.com/neovim/neovim.git
Updating /Users/slu/Library/Caches/Homebrew/neovim--git
==> Checking out branch master
Already on 'master'
Your branch is up to date with 'origin/master'.
HEAD is now at bad218cd6 vim-patch:9.0.1429: invalid memory access when ending insert mode (#22792)
==> Upgrading neovim
  HEAD-286777c -> HEAD-bad218c

==> luarocks make --lua-dir=/opt/homebrew/opt/luajit --tree=/private/tmp/neovim-20230327-2509
==> luarocks make --lua-dir=/opt/homebrew/opt/luajit --tree=/private/tmp/neovim-20230327-2509
==> cmake -S . -B build -DLIBLUV_LIBRARY=/opt/homebrew/opt/luv/lib/libluv.dylib -DLIBUV_LIBRA
==> cmake --build build
==> cmake --install build
==> Caveats
HEAD installs of Neovim do not include any tree-sitter parsers.
You can use the `nvim-treesitter` plugin to install them.
==> Summary
🍺  /opt/homebrew/Cellar/neovim/HEAD-bad218c: 1,725 files, 23.8MB, built in 36 seconds
==> Running `brew cleanup neovim`...
Disable this behaviour by setting HOMEBREW_NO_INSTALL_CLEANUP.
Hide these hints with HOMEBREW_NO_ENV_HINTS (see `man brew`).
Removing: /opt/homebrew/Cellar/neovim/HEAD-286777c... (1,674 files, 23.6MB)
Removing: /Users/slu/Library/Caches/Homebrew/neovim--mpack--1.0.8.tar.gz... (17.7KB)
Removing: /Users/slu/Library/Caches/Homebrew/neovim--ruby-source--HEAD.rb... (5.5KB)
Removing: /Users/slu/Library/Caches/Homebrew/neovim--lpeg--1.0.2-1.rock... (71KB)

The failure from before, which this topic is about, was a luarocks related problem with one of the initial parts of the build (preparing something related to dependencies), and the main issue I'm trying to point out is that homebrew left stuff hanging in a bad state. But yeah I am also interpreting what you wrote as, i could hopefully bring back a working system by running brew link neovim, but it's still probably a bug.

[unphased]

after running brew reinstall $(brew deps --include-build neovim) (which did a ton of stuff but thankfully did not fail) I was able to complete brew upgrade neovim --fetch-HEAD.