org-roam-bibtex-mode did not change the behavior of ivy-bibtex/helm-bibtex

[wztdream]

Hi,
I read the code of org-roam-bibtex-mode, but it seems it did not change the behavior of ivy-bibtex or helm-bibtex. Is it intended or not?

org-roam-bibtex/org-roam-bibtex.el

Lines 1113 to 1163 in 201262a

	(define-minor-mode org-roam-bibtex-mode
	"Sets an appropriate function for editing bibliography notes.
	Supports Org-ref, Helm-bibtex/Ivy-bibtex, and Citar.
	When called interactively, toggle `org-roam-bibtex-mode'. with
	prefix ARG, enable `org-roam-bibtex-mode' if ARG is positive,
	otherwise disable it.
	When called from Lisp, enable `org-roam-bibtex-mode' if ARG is
	omitted, nil, or positive. If ARG is `toggle', toggle
	`org-roam-bibtex-mode'. Otherwise, behave as if called
	interactively."
	:lighter " orb"
	:keymap org-roam-bibtex-mode-map
	:group 'org-roam-bibtex
	:require 'orb
	:global t
	;; TODO: Revert external variables to their original values rather than to
	;; their defaults
	(cond (org-roam-bibtex-mode
	(setq orb--external-vars-original-values nil)
	(let ((var-alist
	'((citar-open-note-function . citar)
	(bibtex-completion-edit-notes-function . bibtex-completion)
	;; Only for Org-ref v2
	(org-ref-notes-function . org-ref))))
	(dolist (el var-alist)
	(let* ((var (car el))
	(pkg (cdr el))
	(val (and (require pkg nil t)
	(boundp var)
	(symbol-value var))))
	(when val
	(push (cons var val) orb--external-vars-original-values)
	(set var (intern (format "orb-%s-edit-note" pkg)))))))
	(add-to-list 'bibtex-completion-find-note-functions #'orb-find-note-file)
	(add-to-list 'bibtex-completion-key-at-point-functions #'orb-get-node-citekey)
	(add-hook 'org-capture-after-finalize-hook #'orb-make-notes-cache)
	(add-hook 'org-roam-capture-new-node-hook #'orb--insert-captured-ref-h)
	(orb-make-notes-cache))
	(t
	(dolist (var-alist orb--external-vars-original-values)
	(set (car var-alist) (cdr var-alist)))
	(setq bibtex-completion-find-note-functions
	(delq #'orb-find-note-file
	bibtex-completion-find-note-functions))
	(setq bibtex-completion-key-at-point-functions
	(delq #'orb-get-node-citekey
	bibtex-completion-key-at-point-functions))
	(remove-hook 'org-roam-capture-new-node-hook #'orb--insert-captured-ref-h)
	(remove-hook 'org-capture-after-finalize-hook #'orb-make-notes-cache))))

In current version the behavior change are only happens when called org-insert-link

org-roam-bibtex/orb-ivy.el

Lines 85 to 88 in 201262a

	(let* ((ivy-actions (copy-tree ivy--actions-list))
	(ivy--actions-list
	(plist-put ivy-actions 'ivy-bibtex orb-insert--ivy-actions))
	(ivy-bibtex-default-action 'ivy-orb-insert-edit-note))

Personally I prefer change the ivy-bibtex or helm-bibtex behavior in org-roam-bibtex-mode, because this is a clear mental mode that change all bibtex related function to org-roam style.

[myshevchuk]

Hi,

I don't think I understand what change in behaviour of Helm/Ivy-bibtex you mean. Could you please elaborate, with an example?

[wztdream]

Hi,

I don't think I understand what change in behaviour of Helm/Ivy-bibtex you mean. Could you please elaborate, with an example?

Now I under stand the logic, org-roam-bibtex-mode change the value of bibtex-completion-edit-notes-function, so changed the behavior of ivy/helm-bibtex.