Skip to content

Commit b02ddb8

Browse files
authored
HELP-7947 popover trigger refs (#331)
* removed aria-expanded from triggerProps for tooltip
1 parent a18aa4a commit b02ddb8

File tree

3 files changed

+5
-9
lines changed

3 files changed

+5
-9
lines changed

lib/components/Popover/index.js

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -313,10 +313,7 @@ export default function Popover({
313313
]);
314314

315315
const triggerProps = {
316-
...getReferenceProps({
317-
ref: refs.setReference,
318-
...(children?.props || {})
319-
}),
316+
...getReferenceProps({ ref: refs.setReference }),
320317
tabIndex: "0"
321318
};
322319

@@ -349,13 +346,12 @@ export default function Popover({
349346
return (
350347
<Container
351348
inlineBlock={inlineBlock}
352-
data-testid={`${children?.props?.["data-testid"] || "popover"}-trigger`}
353349
{...props}
354350
{...triggerProps}
355351
aria-describedby={context.floatingId}
356352
>
357353
{variant === "tooltip" && (
358-
<TooltipControl {...triggerProps} active={visible} tabIndex="0">
354+
<TooltipControl active={visible} tabIndex="0">
359355
<Icon
360356
transform="grow-4"
361357
icon={["fas", "question-circle"]}

package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "orcs-design-system",
3-
"version": "3.2.35",
3+
"version": "3.2.36",
44
"engines": {
55
"node": "20.12.2"
66
},

0 commit comments

Comments
 (0)