fix: auth via ECR to be an extra (#208)

* fix: auth via ECR to be an extra

as intended in original PR.

Signed-off-by: tarilabs <matteo.mortari@gmail.com>

* linting

Signed-off-by: tarilabs <matteo.mortari@gmail.com>

* Update oras/auth/ecr.py

Co-authored-by: Vanessasaurus <814322+vsoch@users.noreply.github.com>
Signed-off-by: Matteo Mortari <matteo.mortari@gmail.com>

* implement code review feedback

Signed-off-by: tarilabs <matteo.mortari@gmail.com>

Co-authored-by: Vanessasaurus <814322+vsoch@users.noreply.github.com>

* implement review feedback by removing code comment and MD in error msg

Signed-off-by: tarilabs <matteo.mortari@gmail.com>

---------

Signed-off-by: tarilabs <matteo.mortari@gmail.com>
Signed-off-by: Matteo Mortari <matteo.mortari@gmail.com>
Co-authored-by: Vanessasaurus <814322+vsoch@users.noreply.github.com>

Author: tarilabs

CHANGELOG.md

@@ -14,6 +14,7 @@ and **Merged pull requests**. Critical items to know are:
 The versions coincide with releases on pip. Only major versions will be released as tags on Github.
 
 ## [0.0.x](https://github.com/oras-project/oras-py/tree/main) (0.0.x)
+ - fix 'authentication with ECR' to be an extra as intended (0.2.35)
  - Add support for authentication with ECR registries (0.2.34)
  - Add support for Docker credsStore and credHelpers
  - fix 'get_manifest()' method with adding 'load_configs()' calling (0.2.33)

oras/auth/ecr.py

@@ -4,7 +4,6 @@
 
 import re
 
-import boto3
 import requests
 
 import oras.auth.utils as auth_utils
@@ -54,6 +53,13 @@ def authenticate_request(
                 logger.warning(f"realm: {h.realm} did not match expected pattern.")
                 return super().request_token(h)
             region = m.group("region")
+            try:
+                import boto3
+            except ImportError as e:
+                msg = """the `boto3` dependency is required to support authentication to this registry.
+                Make sure to install the required extra "ecr", e.g.: pip install oras[ecr].
+                """
+                raise ImportError(msg) from e
             ecr = boto3.client("ecr", region_name=region)
             auth = ecr.get_authorization_token()["authorizationData"][0]
             token = auth.get("authorizationToken", "")

oras/decorator.py

@@ -52,7 +52,7 @@ def inner(*args, **kwargs):
                     return res
                 except oras.auth.AuthenticationException as e:
                     raise e
-                except requests.exceptions.SSLError:
+                except (requests.exceptions.SSLError, ImportError):
                     raise
                 except Exception as e:
                     sleep = timeout + 3**attempt

oras/version.py

@@ -2,7 +2,7 @@
 __copyright__ = "Copyright The ORAS Authors."
 __license__ = "Apache-2.0"
 
-__version__ = "0.2.34"
+__version__ = "0.2.35"
 AUTHOR = "Vanessa Sochat"
 EMAIL = "vsoch@users.noreply.github.com"
 NAME = "oras"