[GR-20336] Update GC.start to accept keyword arguments.

PullRequest: truffleruby/1216

Author: eregon

CHANGELOG.md

@@ -49,6 +49,7 @@ Bug fixes:
 * Run `END` keyword block only once at exit.
 * Implement Numeric#clone method to return self.
 * Fixed `Symbol#to_proc` to create proc with nil `source_location` (#1663).
+* Make `GC.start` work with keyword arguments.
 
 Compatibility:
 

spec/ruby/core/gc/start_spec.rb

@@ -5,4 +5,8 @@
     GC.start.should == nil
     GC.start.should == nil
   end
+
+  it "accepts keyword arguments" do
+    GC.start(full_mark: true, immediate_sweep: true).should == nil
+  end
 end

spec/tags/core/gc/start_tags.txt

@@ -1 +1,2 @@
 slow:GC.start always returns nil
+slow:GC.start accepts keyword arguments

src/main/java/org/truffleruby/core/GCNodes.java

@@ -18,24 +18,10 @@
 
 import com.oracle.truffle.api.CompilerDirectives.TruffleBoundary;
 import com.oracle.truffle.api.dsl.Specialization;
-import com.oracle.truffle.api.object.DynamicObject;
 
 @CoreModule("GC")
 public abstract class GCNodes {
 
-    @CoreMethod(names = "start", onSingleton = true)
-    public static abstract class GCStartNode extends CoreMethodArrayArgumentsNode {
-
-        @TruffleBoundary
-        @Specialization
-        protected DynamicObject vmGCStart() {
-            getContext().getMarkingService().queueMarking();
-            System.gc();
-            return nil();
-        }
-
-    }
-
     @CoreMethod(names = "count", onSingleton = true)
     public abstract static class CountNode extends CoreMethodArrayArgumentsNode {
 

src/main/java/org/truffleruby/core/VMPrimitiveNodes.java

@@ -103,6 +103,19 @@ protected Object doCatch(Object tag, DynamicObject block,
         }
     }
 
+    @Primitive(name = "vm_gc_start")
+    public static abstract class VMGCStartPrimitiveNode extends PrimitiveArrayArgumentsNode {
+
+        @TruffleBoundary
+        @Specialization
+        protected DynamicObject vmGCStart() {
+            getContext().getMarkingService().queueMarking();
+            System.gc();
+            return nil();
+        }
+
+    }
+
     // The hard #exit!
     @Primitive(name = "vm_exit", lowerFixnum = 0)
     public static abstract class VMExitNode extends PrimitiveArrayArgumentsNode {

src/main/ruby/truffleruby/core/gc.rb

@@ -39,6 +39,10 @@ def self.run(force)
     start
   end
 
+  def self.start(full_mark: true, immediate_sweep: true)
+    TrufflePrimitive.vm_gc_start()
+  end
+
   # Totally fake.
   def self.stress
     @stress_level ||= false