make ManagedRope#getBytes NeverPartOfCompilation, and fix violations

Author: Nicolas Laurent

src/main/java/org/truffleruby/cext/CExtNodes.java

@@ -942,12 +942,14 @@ public abstract static class StringPointerSizeNode extends PrimitiveArrayArgumen
 
         @Specialization(guards = "strings.isRubyString(string)")
         protected int size(Object string,
-                @CachedLibrary(limit = "2") RubyStringLibrary strings) {
+                @CachedLibrary(limit = "2") RubyStringLibrary strings,
+                @Cached RopeNodes.BytesNode getBytes) {
             final Rope rope = strings.getRope(string);
+            final byte[] bytes = getBytes.execute(rope);
             final int byteLength = rope.byteLength();
             int i = 0;
             for (; i < byteLength; i++) {
-                if (rope.get(i) == 0) {
+                if (bytes[i] == 0) {
                     return i;
                 }
             }
@@ -1209,8 +1211,9 @@ public abstract static class RbTrMbcCaseFoldNode extends CoreMethodArrayArgument
         protected Object rbTrEncMbcCaseFold(RubyEncoding enc, int flags, Object string, Object write_p, Object p,
                 @CachedLibrary(limit = "2") RubyStringLibrary strings,
                 @CachedLibrary("write_p") InteropLibrary receivers,
+                @Cached RopeNodes.BytesNode getBytes,
                 @Cached TranslateInteropExceptionNode translateInteropExceptionNode) {
-            final byte[] bytes = strings.getRope(string).getBytes();
+            final byte[] bytes = getBytes.execute(strings.getRope(string));
             final byte[] to = new byte[bytes.length];
             final IntHolder intHolder = new IntHolder();
             intHolder.value = 0;
@@ -1277,6 +1280,7 @@ public abstract static class RbEncMbLenNode extends CoreMethodArrayArgumentsNode
         @Specialization(guards = "strings.isRubyString(string)")
         protected Object rbEncMbLen(RubyEncoding enc, Object string, int p, int e,
                 @CachedLibrary(limit = "2") RubyStringLibrary strings,
+                @Cached RopeNodes.BytesNode getBytes,
                 @Cached RopeNodes.CodeRangeNode codeRangeNode,
                 @Cached ConditionProfile sameEncodingProfile) {
             final Encoding encoding = enc.encoding;
@@ -1288,7 +1292,7 @@ protected Object rbEncMbLen(RubyEncoding enc, Object string, int p, int e,
                     sameEncodingProfile.profile(encoding == ropeEncoding)
                             ? codeRangeNode.execute(rope)
                             : CodeRange.CR_UNKNOWN,
-                    strings.getRope(string).getBytes(),
+                    getBytes.execute(strings.getRope(string)),
                     p,
                     e,
                     true);
@@ -1331,6 +1335,7 @@ public abstract static class RbEncPreciseMbclenNode extends CoreMethodArrayArgum
         protected int rbEncPreciseMbclen(RubyEncoding enc, Object string, int p, int end,
                 @CachedLibrary(limit = "2") RubyStringLibrary strings,
                 @Cached RopeNodes.CalculateCharacterLengthNode calculateCharacterLengthNode,
+                @Cached RopeNodes.BytesNode getBytes,
                 @Cached ConditionProfile sameEncodingProfile) {
             final Encoding encoding = enc.encoding;
             final Rope rope = strings.getRope(string);
@@ -1341,7 +1346,8 @@ protected int rbEncPreciseMbclen(RubyEncoding enc, Object string, int p, int end
                 cr = CodeRange.CR_UNKNOWN;
             }
 
-            final int length = calculateCharacterLengthNode.characterLength(encoding, cr, rope.getBytes(), p, end);
+            final int length = calculateCharacterLengthNode
+                    .characterLength(encoding, cr, getBytes.execute(rope), p, end);
             assert end - p >= length; // assert this condition not reached: https://github.com/ruby/ruby/blob/46a5d1b4a63f624f2c5c5b6f710cc1a176c88b02/encoding.c#L1046
             return length;
         }

src/main/java/org/truffleruby/core/rope/ManagedRope.java

@@ -9,6 +9,7 @@
  */
 package org.truffleruby.core.rope;
 
+import com.oracle.truffle.api.CompilerAsserts;
 import org.jcodings.Encoding;
 
 public abstract class ManagedRope extends Rope {
@@ -45,6 +46,7 @@ protected byte getByteSlow(int index) {
 
     @Override
     public final byte[] getBytes() {
+        CompilerAsserts.neverPartOfCompilation("Use RopeNodes.ByteNodes instead, or add a @TruffleBoundary.");
         if (bytes == null) {
             bytes = getBytesSlow();
         }

src/main/java/org/truffleruby/core/rope/RopeNodes.java

@@ -958,6 +958,7 @@ protected int getByte(NativeRope rope, int index) {
             return rope.get(index) & 0xff;
         }
 
+        @TruffleBoundary
         @Specialization(guards = "rope.getRawBytes() == null")
         protected int getByte(LazyIntRope rope, int index) {
             return rope.getBytes()[index] & 0xff;
@@ -1384,11 +1385,12 @@ protected CodeRange getCodeRangeManaged(ManagedRope rope) {
 
         @Specialization
         protected CodeRange getCodeRangeNative(NativeRope rope,
+                @Cached BytesNode getBytes,
                 @Cached CalculateAttributesNode calculateAttributesNode,
                 @Cached ConditionProfile unknownCodeRangeProfile) {
             if (unknownCodeRangeProfile.profile(rope.getRawCodeRange() == CR_UNKNOWN)) {
                 final StringAttributes attributes = calculateAttributesNode
-                        .executeCalculateAttributes(rope.getEncoding(), rope.getBytes());
+                        .executeCalculateAttributes(rope.getEncoding(), getBytes.execute(rope));
                 rope.updateAttributes(attributes);
                 return attributes.getCodeRange();
             } else {
@@ -1433,12 +1435,13 @@ protected int getCharacterLengthManaged(ManagedRope rope) {
 
         @Specialization
         protected int getCharacterLengthNative(NativeRope rope,
+                @Cached BytesNode getBytes,
                 @Cached CalculateAttributesNode calculateAttributesNode,
                 @Cached ConditionProfile unknownCharacterLengthProfile) {
             if (unknownCharacterLengthProfile
                     .profile(rope.rawCharacterLength() == NativeRope.UNKNOWN_CHARACTER_LENGTH)) {
                 final StringAttributes attributes = calculateAttributesNode
-                        .executeCalculateAttributes(rope.getEncoding(), rope.getBytes());
+                        .executeCalculateAttributes(rope.getEncoding(), getBytes.execute(rope));
                 rope.updateAttributes(attributes);
                 return attributes.getCharacterLength();
             } else {

src/main/java/org/truffleruby/core/rope/RopeOperations.java

@@ -290,7 +290,7 @@ public static byte[] extractRange(Rope rope, int offset, int length) {
     }
 
     /** This method should not be used directly, because it does not cache the result in the Rope. Use
-     * {@link Rope#getBytes()} instead.
+     * {@link RopeNodes.BytesNode} or {@link Rope#getBytes()} instead.
      *
      * Performs an iterative depth first search of the Rope tree to calculate its byte[] without needing to populate the
      * byte[] for each level beneath. Every LeafRope has its byte[] populated by definition. The goal is to determine

src/main/java/org/truffleruby/core/string/StringNodes.java

@@ -2108,6 +2108,7 @@ public abstract static class DumpNode extends CoreMethodArrayArgumentsNode {
 
         @Child private RopeNodes.MakeLeafRopeNode makeLeafRopeNode = RopeNodes.MakeLeafRopeNode.create();
 
+        @TruffleBoundary
         @Specialization(guards = "isAsciiCompatible(libString.getRope(string))")
         protected RubyString dumpAsciiCompatible(Object string,
                 @Cached LogicalClassNode logicalClassNode,
@@ -3932,6 +3933,7 @@ protected Object stringFindCharacterSingleByte(Object string, int offset,
                         "!isSingleByteOptimizable(strings.getRope(string), singleByteOptimizableNode)" })
         protected Object stringFindCharacter(Object string, int offset,
                 @CachedLibrary(limit = "2") RubyStringLibrary strings,
+                @Cached RopeNodes.BytesNode getBytes,
                 @Cached RopeNodes.CalculateCharacterLengthNode calculateCharacterLengthNode,
                 @Cached RopeNodes.CodeRangeNode codeRangeNode,
                 @Cached RopeNodes.SingleByteOptimizableNode singleByteOptimizableNode) {
@@ -3942,7 +3944,7 @@ protected Object stringFindCharacter(Object string, int offset,
             final CodeRange cr = codeRangeNode.execute(rope);
 
             final int clen = calculateCharacterLengthNode
-                    .characterLength(enc, cr, rope.getBytes(), offset, offset + enc.maxLength());
+                    .characterLength(enc, cr, getBytes.execute(rope), offset, offset + enc.maxLength());
 
             return substringNode.executeSubstring(string, offset, clen);
         }