Introduce core symbols for thread statuses

Author: andrykonchin

src/main/java/org/truffleruby/core/symbol/CoreSymbols.java

@@ -47,6 +47,11 @@ public final class CoreSymbols {
     public final RubySymbol DECONSTRUCT = createRubySymbol("deconstruct");
     public final RubySymbol DECONSTRUCT_KEYS = createRubySymbol("deconstruct_keys");
 
+    public final RubySymbol RUN = createRubySymbol("run");
+    public final RubySymbol SLEEP = createRubySymbol("sleep");
+    public final RubySymbol ABORTING = createRubySymbol("aborting");
+    public final RubySymbol DEAD = createRubySymbol("dead");
+
     // Added to workaround liquid's no symbols leaked test (SecurityTest#test_does_not_permanently_add_filters_to_symbol_table)
     public final RubySymbol IMMEDIATE_SWEEP = createRubySymbol("immediate_sweep");
     public final RubySymbol IMMEDIATE_MARK = createRubySymbol("immediate_mark");

src/main/java/org/truffleruby/core/thread/ThreadNodes.java

@@ -592,19 +592,17 @@ public abstract static class ThreadSetStatusPrimitiveNode extends PrimitiveArray
         @Specialization
         Object threadSetStatus(RubyThread thread, RubySymbol status) {
             ThreadStatus current = thread.status;
-            String newName = status.getString();
 
-            if (newName.equals("run")) {
+            if (status == coreSymbols().RUN) {
                 thread.status = ThreadStatus.RUN;
-            } else if (newName.equals("sleep")) {
+            } else if (status == coreSymbols().SLEEP) {
                 thread.status = ThreadStatus.SLEEP;
-            } else if (newName.equals("aborting")) {
+            } else if (status == coreSymbols().ABORTING) {
                 thread.status = ThreadStatus.ABORTING;
-            } else if (newName.equals("dead")) {
+            } else if (status == coreSymbols().DEAD) {
                 thread.status = ThreadStatus.DEAD;
             } else {
-                throw new RaiseException(getContext(),
-                        coreExceptions().argumentError("Unknown thread status: " + newName, this));
+                throw CompilerDirectives.shouldNotReachHere("Unknown thread status: " + status);
             }
 
             String currentName = StringUtils.toLowerCase(current.name());

tool/generate-core-symbols.rb

@@ -66,6 +66,11 @@
     public final RubySymbol DECONSTRUCT = createRubySymbol("deconstruct");
     public final RubySymbol DECONSTRUCT_KEYS = createRubySymbol("deconstruct_keys");
 
+    public final RubySymbol RUN = createRubySymbol("run");
+    public final RubySymbol SLEEP = createRubySymbol("sleep");
+    public final RubySymbol ABORTING = createRubySymbol("aborting");
+    public final RubySymbol DEAD = createRubySymbol("dead");
+
     // Added to workaround liquid's no symbols leaked test (SecurityTest#test_does_not_permanently_add_filters_to_symbol_table)
     public final RubySymbol IMMEDIATE_SWEEP = createRubySymbol("immediate_sweep");
     public final RubySymbol IMMEDIATE_MARK = createRubySymbol("immediate_mark");