Skip to content

Commit f8fdca8

Browse files
committed
Polish interop documentation
1 parent 9d888f7 commit f8fdca8

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

doc/contributor/interop_implicit_api.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,9 @@ Format: `Ruby code` sends `InteropLibrary message`
2121
- `foreign_object.size` sends `getArraySize(foreign_object)`
2222
- `foreign_object.keys` sends `getMembers(foreign_object)`
2323
- `foreign_object.method_name` sends `invokeMember(foreign_object, method_name)` if member is invocable
24-
- `foreign_object.method_name` sends `readMember(foreign_object, method_name)` if member is readable
25-
- `foreign_object.method_name` sends `readMember(foreign_object, method_name)` and raises if member is not invocable or readable
26-
- `foreign_object.method_name(*arguments)` sends `invokeMember(foreign_object, method_name, *arguments)` if member is readable and invokable
24+
- `foreign_object.method_name` sends `readMember(foreign_object, method_name)` if member is readable but not invocable
25+
- `foreign_object.method_name` sends `readMember(foreign_object, method_name)` and raises if member is neither invocable nor readable
26+
- `foreign_object.method_name(*arguments)` sends `invokeMember(foreign_object, method_name, *arguments)`
2727
- `foreign_object.method_name(*arguments, &block)` sends `invokeMember(foreign_object, method_name, *arguments, block)`
2828
- `foreign_object.new(*arguments)` sends `instantiate(foreign_object, *arguments)`
2929
- `foreign_object.class` sends `readMember(foreign_object, "class")` when `foreign_object` is a `java.lang.Class`

spec/truffle/interop/special_forms_spec.rb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -152,22 +152,22 @@
152152
l.log.should include(["invokeMember", "foo"])
153153
end
154154

155-
it description['.method_name', :readMember, ['method_name'], 'if member is readable'] do
155+
it description['.method_name', :readMember, ['method_name'], 'if member is readable but not invocable'] do
156156
pfo, _, l = proxy[TruffleInteropSpecs::PolyglotMember.new]
157157
pfo.foo = :bar
158158
pfo.foo
159159
l.log.should include(["isMemberInvocable", "foo"])
160160
l.log.should include(["readMember", "foo"])
161161
end
162162

163-
it description['.method_name', :readMember, ['method_name'], 'and raises if member is not invocable or readable'] do
163+
it description['.method_name', :readMember, ['method_name'], 'and raises if member is neither invocable nor readable'] do
164164
pfo, _, l = proxy[Object.new]
165165
-> { pfo.foo }.should raise_error(NameError)
166166
l.log.should include(["isMemberInvocable", "foo"])
167167
l.log.should include(["readMember", "foo"])
168168
end
169169

170-
it description['.method_name(*arguments)', :invokeMember, ['method_name', '*arguments'], 'if member is readable and invokable'] do
170+
it description['.method_name(*arguments)', :invokeMember, ['method_name', '*arguments']] do
171171
pfo, _, l = proxy[Object.new]
172172
-> { pfo.bar(1, 2, 3) }.should raise_error(NoMethodError)
173173
l.log.should include(["invokeMember", "bar", 1, 2, 3])

0 commit comments

Comments
 (0)