Skip to content

Commit f8d527c

Browse files
committed
Use exec() when running MRI tests
* So signals sent to the jt process PID will be delivered to the test process appropriately. Otherwise, a SIGTERM or SIGKILL would only kill jt but not the test process.
1 parent a8c8314 commit f8d527c

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

tool/jt.rb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -974,11 +974,11 @@ def test_mri(*args)
974974
end
975975
end.sort - excluded_files
976976

977-
run_mri_tests(mri_args, files_to_run, runner_args)
977+
run_mri_tests(mri_args, files_to_run, runner_args, use_exec: true)
978978
end
979979
private :test_mri
980980

981-
def run_mri_tests(extra_args, test_files, runner_args, run_options = {})
981+
def run_mri_tests(extra_args, test_files, runner_args, run_options)
982982
prefix = "test/mri/tests/"
983983
abs_prefix = "#{TRUFFLERUBY_DIR}/#{prefix}"
984984
test_files = test_files.map { |file|
@@ -1063,7 +1063,7 @@ def retag(*args)
10631063
sh "ruby", "tool/parse_mri_errors.rb", output_file
10641064

10651065
puts "3. Verifying tests pass"
1066-
run_mri_tests(options, test_files, [])
1066+
run_mri_tests(options, test_files, [], use_exec: true)
10671067
end
10681068

10691069
def test_compiler(*args)

0 commit comments

Comments
 (0)