Convert IsSharedNode to DSL inlinable

Author: horakivo

src/main/java/org/truffleruby/core/array/ArrayNodes.java

@@ -480,7 +480,7 @@ protected RubyArray clear(RubyArray array,
                 @Cached IsSharedNode isSharedNode,
                 @Cached ConditionProfile sharedProfile) {
             setStoreAndSize(array,
-                    ArrayStoreLibrary.initialStorage(sharedProfile.profile(isSharedNode.executeIsShared(array))),
+                    ArrayStoreLibrary.initialStorage(sharedProfile.profile(isSharedNode.executeIsShared(this, array))),
                     0);
             return array;
         }
@@ -1142,7 +1142,8 @@ protected RubyArray initializeNoArgs(RubyArray array, NotProvided size, NotProvi
                 @Cached @Shared IsSharedNode isSharedNode,
                 @Cached @Shared ConditionProfile sharedProfile) {
             setStoreAndSize(array,
-                    ArrayStoreLibrary.initialStorage(sharedProfile.profile(isSharedNode.executeIsShared(array))), 0);
+                    ArrayStoreLibrary.initialStorage(sharedProfile.profile(isSharedNode.executeIsShared(this, array))),
+                    0);
             return array;
         }
 
@@ -1158,7 +1159,8 @@ protected RubyArray initializeOnlyBlock(
             }
 
             setStoreAndSize(array,
-                    ArrayStoreLibrary.initialStorage(sharedProfile.profile(isSharedNode.executeIsShared(array))), 0);
+                    ArrayStoreLibrary.initialStorage(sharedProfile.profile(isSharedNode.executeIsShared(this, array))),
+                    0);
             return array;
         }
 
@@ -1190,7 +1192,7 @@ protected RubyArray initializeWithSizeNoValue(RubyArray array, int size, NotProv
                 @Cached @Shared ConditionProfile sharedProfile,
                 @CachedLibrary(limit = "2") @Exclusive ArrayStoreLibrary stores) {
             final Object store;
-            if (sharedProfile.profile(isSharedNode.executeIsShared(array))) {
+            if (sharedProfile.profile(isSharedNode.executeIsShared(this, array))) {
                 store = new SharedArrayStorage(new Object[size]);
             } else {
                 store = new Object[size];
@@ -1253,7 +1255,7 @@ protected Object initializeBlock(RubyArray array, int size, Object unusedFilling
             } finally {
                 profileAndReportLoopCount(loopProfile, n);
                 Object store = arrayBuilder.finish(state, n);
-                if (sharedProfile.profile(isSharedNode.executeIsShared(array))) {
+                if (sharedProfile.profile(isSharedNode.executeIsShared(this, array))) {
                     store = stores.makeShared(store, n);
                 }
                 setStoreAndSize(array, store, n);
@@ -1836,7 +1838,7 @@ protected RubyArray replace(RubyArray array, RubyArray other,
                 @CachedLibrary(limit = "2") ArrayStoreLibrary stores) {
             final int size = other.size;
             Object store = cowNode.execute(other, 0, size);
-            if (sharedProfile.profile(isSharedNode.executeIsShared(array))) {
+            if (sharedProfile.profile(isSharedNode.executeIsShared(this, array))) {
                 store = stores.makeShared(store, size);
             }
             setStoreAndSize(array, store, size);
@@ -2297,9 +2299,7 @@ public abstract static class StoreToNativeNode extends PrimitiveArrayArgumentsNo
         protected RubyArray storeToNative(RubyArray array,
                 @Bind("array.getStore()") Object store,
                 @CachedLibrary("store") ArrayStoreLibrary stores,
-                @Cached IntValueProfile arraySizeProfile,
-                @Cached IsSharedNode isSharedNode,
-                @Cached ConditionProfile sharedProfile) {
+                @Cached IntValueProfile arraySizeProfile) {
             final int size = arraySizeProfile.profile(array.size);
             Pointer pointer = Pointer.mallocAutoRelease(getLanguage(), getContext(), size * Pointer.SIZE);
             Object newStore = new NativeArrayStorage(pointer, size);

src/main/java/org/truffleruby/language/objects/shared/IsSharedNode.java

@@ -9,6 +9,8 @@
  */
 package org.truffleruby.language.objects.shared;
 
+import com.oracle.truffle.api.dsl.GenerateInline;
+import com.oracle.truffle.api.nodes.Node;
 import org.truffleruby.language.RubyBaseNode;
 import org.truffleruby.language.RubyDynamicObject;
 import org.truffleruby.language.objects.ShapeCachingGuards;
@@ -21,30 +23,32 @@
 
 @ImportStatic(ShapeCachingGuards.class)
 @GenerateUncached
+@GenerateInline(inlineByDefault = true)
 public abstract class IsSharedNode extends RubyBaseNode {
 
     protected static final int CACHE_LIMIT = 8;
 
-    public abstract boolean executeIsShared(RubyDynamicObject object);
+    public abstract boolean executeIsShared(Node node, RubyDynamicObject object);
 
     @Specialization(
             guards = "object.getShape() == cachedShape",
             assumptions = "cachedShape.getValidAssumption()",
             limit = "CACHE_LIMIT")
-    protected boolean isShareCached(RubyDynamicObject object,
+    protected static boolean isShareCached(RubyDynamicObject object,
             @Cached("object.getShape()") Shape cachedShape,
             @Cached("cachedShape.isShared()") boolean shared) {
         return shared;
     }
 
     @Specialization(guards = "updateShape(object)")
-    protected boolean updateShapeAndIsShared(RubyDynamicObject object) {
-        return executeIsShared(object);
+    protected static boolean updateShapeAndIsShared(Node node, RubyDynamicObject object,
+            @Cached(inline = false) IsSharedNode isSharedNode) {
+        return isSharedNode.executeIsShared(node, object);
     }
 
     @Specialization(replaces = { "isShareCached", "updateShapeAndIsShared" })
-    protected boolean isSharedUncached(RubyDynamicObject object) {
-        return getLanguage().options.SHARED_OBJECTS_ENABLED && SharedObjects.isShared(object);
+    protected static boolean isSharedUncached(Node node, RubyDynamicObject object) {
+        return getLanguage(node).options.SHARED_OBJECTS_ENABLED && SharedObjects.isShared(object);
     }
 
 }

src/main/java/org/truffleruby/language/objects/shared/PropagateSharingNode.java

@@ -28,13 +28,13 @@ public static PropagateSharingNode create() {
 
     public abstract void executePropagate(RubyDynamicObject source, Object value);
 
-    @Specialization(guards = "!isSharedNode.executeIsShared(source)", limit = "1")
+    @Specialization(guards = "!isSharedNode.executeIsShared(this, source)", limit = "1")
     protected void propagateNotShared(RubyDynamicObject source, Object value,
             @Cached @Shared IsSharedNode isSharedNode) {
         // do nothing
     }
 
-    @Specialization(guards = "isSharedNode.executeIsShared(source)", limit = "1")
+    @Specialization(guards = "isSharedNode.executeIsShared(this, source)", limit = "1")
     protected void propagateShared(RubyDynamicObject source, Object value,
             @Cached @Shared IsSharedNode isSharedNode,
             @Cached WriteBarrierNode writeBarrierNode) {