Fixes

Author: chrisseaton

src/main/java/org/truffleruby/core/rope/Rope.java

@@ -158,15 +158,15 @@ public byte get(int index) {
         return getByteSlow(index);
     }
 
+    /** This is designed to not have any side effects - compare to {@link #getJavaString} - but this makes it
+     * inefficient - for debugging only */
     @Override
     public String toString() {
-        // This is designed to not have any side effects - compare to getString
         return RopeOperations.decode(encoding, RopeOperations.flattenBytes(this));
     }
 
-    /** Should only be used by the parser */
-    public final String normaliseAndGetJavaString() {
-        // This will have side effects such as flattening a ConcatString
+    /** Should only be used by the parser - it has side effects */
+    public final String getJavaString() {
         return RopeOperations.decodeRope(this);
     }
 

src/main/java/org/truffleruby/interop/PolyglotNodes.java

@@ -111,7 +111,7 @@ protected Object evalFile(Object fileName, NotProvided id,
                     throw new RaiseException(
                             getContext(),
                             coreExceptions().argumentError(
-                                    "Could not find language of file " + strings.getJavaString(fileName),
+                                    "Could not find language of file " + path,
                                     this));
                 }
                 source = Source.newBuilder(language, file).build();

src/main/java/org/truffleruby/parser/ast/ClassVarAsgnParseNode.java

@@ -47,7 +47,7 @@ public class ClassVarAsgnParseNode extends AssignableParseNode implements INameN
     public ClassVarAsgnParseNode(SourceIndexLength position, Rope name, ParseNode valueNode) {
         super(position, valueNode);
 
-        this.name = name.normaliseAndGetJavaString();
+        this.name = name.getJavaString();
     }
 
     @Override

src/main/java/org/truffleruby/parser/ast/ClassVarParseNode.java

@@ -43,7 +43,7 @@ public class ClassVarParseNode extends ParseNode implements INameNode, SideEffec
     private String name;
 
     public ClassVarParseNode(SourceIndexLength position, Rope name) {
-        this(position, name.normaliseAndGetJavaString());
+        this(position, name.getJavaString());
     }
 
     public ClassVarParseNode(SourceIndexLength position, String name) {

src/main/java/org/truffleruby/parser/ast/Colon3ParseNode.java

@@ -45,7 +45,7 @@ public class Colon3ParseNode extends ParseNode implements INameNode {
 
     public Colon3ParseNode(SourceIndexLength position, Rope name) {
         super(position);
-        this.name = name.normaliseAndGetJavaString();
+        this.name = name.getJavaString();
     }
 
     @Override

src/main/java/org/truffleruby/parser/ast/ConstDeclParseNode.java

@@ -48,7 +48,7 @@ public ConstDeclParseNode(SourceIndexLength position, Rope name, INameNode const
         super(position, valueNode);
 
         assert constNode != null || (name != null && !name.isEmpty());
-        this.name = name == null ? null : name.normaliseAndGetJavaString();
+        this.name = name == null ? null : name.getJavaString();
         this.constNode = constNode;
     }
 

src/main/java/org/truffleruby/parser/ast/ConstParseNode.java

@@ -43,7 +43,7 @@ public class ConstParseNode extends ParseNode implements INameNode {
     private String name;
 
     public ConstParseNode(SourceIndexLength position, Rope name) {
-        this(position, name.normaliseAndGetJavaString());
+        this(position, name.getJavaString());
     }
 
     public ConstParseNode(SourceIndexLength position, String name) {

src/main/java/org/truffleruby/parser/ast/GlobalAsgnParseNode.java

@@ -47,7 +47,7 @@ public class GlobalAsgnParseNode extends AssignableParseNode implements INameNod
     public GlobalAsgnParseNode(SourceIndexLength position, Rope name, ParseNode valueNode) {
         super(position, valueNode);
 
-        this.name = name.normaliseAndGetJavaString();
+        this.name = name.getJavaString();
     }
 
     @Override

src/main/java/org/truffleruby/parser/ast/GlobalVarParseNode.java

@@ -43,7 +43,7 @@ public class GlobalVarParseNode extends ParseNode implements INameNode {
     private String name;
 
     public GlobalVarParseNode(SourceIndexLength position, Rope name) {
-        this(position, name.normaliseAndGetJavaString());
+        this(position, name.getJavaString());
     }
 
     public GlobalVarParseNode(SourceIndexLength position, String name) {

src/main/java/org/truffleruby/parser/ast/InstAsgnParseNode.java

@@ -48,7 +48,7 @@ public class InstAsgnParseNode extends AssignableParseNode implements INameNode
     public InstAsgnParseNode(SourceIndexLength position, Rope name, ParseNode valueNode) {
         super(position, valueNode);
 
-        this.name = name.normaliseAndGetJavaString();
+        this.name = name.getJavaString();
     }
 
     @Override