[GR-17601] Enable Truffle Regex by default

PullRequest: truffleruby/2798

Author: eregon

CHANGELOG.md

@@ -2,6 +2,7 @@
 
 New features:
 
+* [TRegex](https://github.com/oracle/graal/tree/master/regex) is now used by default, which provides large speedups for matching regular expressions.
 
 Bug fixes:
 

mx.truffleruby/suite.py

@@ -7,7 +7,7 @@
             {
                 "name": "regex",
                 "subdir": True,
-                "version": "42c83e13dc5ef41c5ca63e76175864c3d94626e2",
+                "version": "d1b1b1f6355682ccbe7976617417397925fcf207",
                 "urls": [
                     {"url": "https://github.com/oracle/graal.git", "kind": "git"},
                     {"url": "https://curio.ssw.jku.at/nexus/content/repositories/snapshots", "kind": "binary"},
@@ -16,7 +16,7 @@
             {
                 "name": "sulong",
                 "subdir": True,
-                "version": "42c83e13dc5ef41c5ca63e76175864c3d94626e2",
+                "version": "d1b1b1f6355682ccbe7976617417397925fcf207",
                 "urls": [
                     {"url": "https://github.com/oracle/graal.git", "kind": "git"},
                     {"url": "https://curio.ssw.jku.at/nexus/content/repositories/snapshots", "kind": "binary"},

spec/ruby/language/regexp_spec.rb

@@ -115,10 +115,11 @@
     /foo.(?<=\d)/.match("fooA foo1").to_a.should == ["foo1"]
   end
 
-  # https://bugs.ruby-lang.org/issues/13671
-  it "raises a RegexpError for lookbehind with specific characters" do
-    r =  Regexp.new("(?<!dss)", Regexp::IGNORECASE)
-    -> { r =~ "✨" }.should raise_error(RegexpError)
+  ruby_bug "#13671", ""..."3.2" do # https://bugs.ruby-lang.org/issues/13671
+    it "handles a lookbehind with ss characters" do
+      r =  Regexp.new("(?<!dss)", Regexp::IGNORECASE)
+      r.should =~ "✨"
+    end
   end
 
   it "supports (?<! ) (negative lookbehind)" do

src/main/java/org/truffleruby/options/Options.java

@@ -129,7 +129,7 @@ public class Options {
     public final boolean WARN_DEPRECATED;
     /** --warn-experimental=true */
     public final boolean WARN_EXPERIMENTAL;
-    /** --use-truffle-regex=false */
+    /** --use-truffle-regex=true */
     public final boolean USE_TRUFFLE_REGEX;
     /** --warn-truffle-regex-compile-fallback=false */
     public final boolean WARN_TRUFFLE_REGEX_COMPILE_FALLBACK;

src/options.yml

@@ -146,7 +146,7 @@ EXPERT:
     WARN_EXPERIMENTAL: [[warn-experimental, -W], boolean, true, 'Sets experimental Warning category']
 
     # Controlling the regular expression engines
-    USE_TRUFFLE_REGEX: [use-truffle-regex, boolean, false, 'Use the Truffle regular expression engine for Regexp objects']
+    USE_TRUFFLE_REGEX: [use-truffle-regex, boolean, true, 'Use the Truffle regular expression engine when possible and fallback to Joni otherwise']
     WARN_TRUFFLE_REGEX_COMPILE_FALLBACK: [warn-truffle-regex-compile-fallback, boolean, false, 'Warn when a Ruby Regexp could not be compiled to a Truffle Regex and Joni is used instead']
     WARN_TRUFFLE_REGEX_MATCH_FALLBACK: [warn-truffle-regex-match-fallback, boolean, false, 'Warn every time Truffle Regex cannot be used for a Regexp match (and instead Joni is used)']
 

src/shared/java/org/truffleruby/shared/options/OptionsCatalog.java

@@ -83,7 +83,7 @@ public class OptionsCatalog {
     public static final OptionKey<Boolean> CEXTS_LOG_WARNINGS_KEY = new OptionKey<>(false);
     public static final OptionKey<Boolean> WARN_DEPRECATED_KEY = new OptionKey<>(false);
     public static final OptionKey<Boolean> WARN_EXPERIMENTAL_KEY = new OptionKey<>(true);
-    public static final OptionKey<Boolean> USE_TRUFFLE_REGEX_KEY = new OptionKey<>(false);
+    public static final OptionKey<Boolean> USE_TRUFFLE_REGEX_KEY = new OptionKey<>(true);
     public static final OptionKey<Boolean> WARN_TRUFFLE_REGEX_COMPILE_FALLBACK_KEY = new OptionKey<>(false);
     public static final OptionKey<Boolean> WARN_TRUFFLE_REGEX_MATCH_FALLBACK_KEY = new OptionKey<>(false);
     public static final OptionKey<Boolean> ARGV_GLOBALS_KEY = new OptionKey<>(false);
@@ -604,7 +604,7 @@ public class OptionsCatalog {
 
     public static final OptionDescriptor USE_TRUFFLE_REGEX = OptionDescriptor
             .newBuilder(USE_TRUFFLE_REGEX_KEY, "ruby.use-truffle-regex")
-            .help("Use the Truffle regular expression engine for Regexp objects")
+            .help("Use the Truffle regular expression engine when possible and fallback to Joni otherwise")
             .category(OptionCategory.EXPERT)
             .stability(OptionStability.EXPERIMENTAL)
             .build();