Skip to content

Commit e88b353

Browse files
committed
[GR-17457] Fix Maven description of org.graalvm.ruby:ruby-language
PullRequest: truffleruby/4557
2 parents 16303cf + ebee4e6 commit e88b353

File tree

2 files changed

+17
-18
lines changed

2 files changed

+17
-18
lines changed

mx.truffleruby/suite.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -629,7 +629,7 @@
629629
"truffle:TRUFFLE_NFI_PANAMA",
630630
"sulong:SULONG_NATIVE",
631631
],
632-
"description": "Core module of Ruby on Truffle",
632+
"description": "TruffleRuby, a high-performance embeddable Ruby implementation. This artifact includes the core language runtime without standard libraries. It is not recommended to depend on this artifact directly. Instead, use \'org.graalvm.polyglot:ruby\' to ensure all dependencies are pulled in correctly.", # pylint: disable=line-too-long
633633
"license": [
634634
"EPL-2.0", # JRuby (we choose EPL out of EPL,GPL,LGPL)
635635
"BSD-new", # Rubinius

tool/jt.rb

Lines changed: 16 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -191,7 +191,7 @@ def get_truffle_version(from: :suite)
191191
end
192192

193193
def ee?
194-
(@mx_env || @ruby_name || '').include?('ee')
194+
@mx_env.include?('ee') || @ruby_name.include?('ee')
195195
end
196196

197197
def ee_jdk?
@@ -260,14 +260,12 @@ def env_path(env)
260260
end
261261

262262
def used_ruby_is_mx_env_name?
263-
ruby_launcher # to set @ruby_name
264263
File.file?(env_path(@ruby_name))
265264
end
266265

267266
def ruby_launcher
268267
return @ruby_launcher if defined? @ruby_launcher
269268

270-
@ruby_name ||= ENV['RUBY_BIN'] || ENV['JT_ENV'] || 'jvm'
271269
ruby_launcher = if @ruby_name == 'ruby'
272270
ENV['RBENV_ROOT'] ? `rbenv which ruby`.chomp : which('ruby')
273271
elsif @ruby_name.start_with?('/')
@@ -2616,21 +2614,20 @@ def sforceimports
26162614
FileUtils.touch(build_information_path)
26172615
end
26182616

2619-
env = if (i = options.index('--env') || options.index('-e'))
2620-
options.delete_at i
2621-
options.delete_at i
2622-
else
2623-
ENV['JT_ENV'] || 'jvm'
2624-
end
2625-
@mx_env = env
2626-
raise 'Cannot use both --use and --env' if defined?(@ruby_name)
2617+
# Override @mx_env if --env is passed
2618+
if (i = options.index('--env') || options.index('-e'))
2619+
options.delete_at i
2620+
@mx_env = options.delete_at i
2621+
end
2622+
env = @mx_env
26272623

2628-
@ruby_name = if (i = options.index('--name') || options.index('-n'))
2629-
options.delete_at i
2630-
options.delete_at i
2631-
else
2632-
env
2633-
end
2624+
# Override @ruby_name from --name or --env
2625+
if (i = options.index('--name') || options.index('-n'))
2626+
options.delete_at i
2627+
@ruby_name = options.delete_at i
2628+
else
2629+
@ruby_name = env
2630+
end
26342631

26352632
name = "truffleruby-#{@ruby_name}"
26362633
mx_base_args = ['--env', env]
@@ -3310,6 +3307,8 @@ def process_pre_args(args)
33103307
@silent = false
33113308
@verbose = false
33123309
@jdk_version = ENV['JT_JDK'] || DEFAULT_JDK_VERSION
3310+
@ruby_name = ENV['RUBY_BIN'] || ENV['JT_ENV'] || 'jvm'
3311+
@mx_env = ENV['JT_ENV'] || 'jvm'
33133312

33143313
until args.empty?
33153314
arg = args.shift

0 commit comments

Comments
 (0)