[GR-16877] Fix specs to never use an arbitrary timeout for joining threads.

PullRequest: truffleruby/926

Author: eregon

spec/ruby/core/thread/value_spec.rb

@@ -18,4 +18,14 @@
     t = Thread.new { Thread.current.exit }
     t.value.should == nil
   end
+
+  it "returns when the thread finished" do
+    q = Queue.new
+    t = Thread.new {
+      q.pop
+    }
+    -> { t.value }.should block_caller
+    q.push :result
+    t.value.should == :result
+  end
 end

spec/ruby/library/socket/socket/accept_spec.rb

@@ -56,7 +56,6 @@
 
           client.connect(@server_addr)
 
-          thread.join(5)
           value = thread.value
           begin
             value.should be_an_instance_of(Array)

spec/ruby/library/socket/socket/sysaccept_spec.rb

@@ -59,8 +59,6 @@
 
           @client.connect(@server_addr)
 
-          thread.join(5)
-
           thread.value.should be_an_instance_of(Array)
         end
       end

spec/ruby/library/socket/socket/tcp_server_loop_spec.rb

@@ -45,7 +45,7 @@
       # At this point the connection has been set up but the thread may not yet
       # have returned, thus we'll need to wait a little longer for it to
       # complete.
-      thread.join(2)
+      thread.join
 
       @sock.should be_an_instance_of(Socket)
       addr.should be_an_instance_of(Addrinfo)

spec/ruby/library/socket/socket/unix_server_loop_spec.rb

@@ -48,7 +48,7 @@
           end
         end
 
-        thread.join(2)
+        thread.join
 
         @sock.should be_an_instance_of(Socket)
         addr.should be_an_instance_of(Addrinfo)

spec/ruby/optional/capi/thread_spec.rb

@@ -117,10 +117,7 @@ def call_capi_rb_thread_wakeup
       # Wake it up, causing the unblock function to be run.
       thr.wakeup
 
-      # Make sure it stopped
-      thr.join(1).should_not be_nil
-
-      # And we got a proper value
+      # Make sure it stopped and we got a proper value
       thr.value.should be_true
     end
 
@@ -139,10 +136,7 @@ def call_capi_rb_thread_wakeup
       # Wake it up, causing the unblock function to be run.
       thr.wakeup
 
-      # Make sure it stopped
-      thr.join(1).should_not be_nil
-
-      # And we got a proper value
+      # Make sure it stopped and we got a proper value
       thr.value.should be_true
     end
   end