[GR-16414] Add ENV#{filter,filter!} aliases.

PullRequest: truffleruby/890

Author: nirvdrum

CHANGELOG.md

@@ -13,8 +13,9 @@ Compatibility:
 * Implemented `Integer#{allbits?,anybits?,nobits?}`.
 * `Integer#{ceil,floor,truncate}` now accept a precision and `Integer#round` accepts a rounding mode.
 * Added missing `Enumerable#filter` and `Enumerator::Lazy#filter` aliases to the respective `select` method (#1610).
-* Implement more `Ripper` methods as no-ops (#1694).
+* Implemented more `Ripper` methods as no-ops (#1694).
 * Implemented `rb_enc_sprintf` (#1702).
+* Implemented `ENV#{filter,filter!}` aliases for `select` and `select!`.
 
 Changes:
 

spec/tags/core/env/filter_tags.txt

@@ -58,3 +58,4 @@ fails:Public methods on String should not include find_character
 fails:Public methods on String should not include shorten!
 fails:Public methods on String should not include substring
 fails:Public methods on String should not include to_sub_replacement
+fails:Public methods on ENV.singleton_class should include slice

spec/tags/truffle/methods_tags.txt

@@ -0,0 +1,45 @@
+[]
+[]=
+assoc
+clear
+delete
+delete_if
+each
+each_key
+each_pair
+each_value
+empty?
+fetch
+filter
+filter!
+has_key?
+has_value?
+include?
+index
+inspect
+invert
+keep_if
+key
+key?
+keys
+length
+member?
+rassoc
+rehash
+reject
+reject!
+replace
+select
+select!
+shift
+size
+slice
+store
+to_a
+to_h
+to_hash
+to_s
+update
+value?
+values
+values_at

spec/truffle/methods/ENV.singleton_class.txt

@@ -16,20 +16,21 @@
 # but instead of jt untag, jt purge must be used to remove tags:
 # $ jt purge spec/truffle/methods_spec.rb
 
-modules = [
-  BasicObject, Kernel, Object,
-  Module, Class,
-  Enumerable, Enumerator, Enumerator::Lazy, Range,
-  Numeric, Integer, Float,
-  Rational, Complex,
-  Array, Hash, String,
-  File, IO,
+modules = %w[
+  BasicObject Kernel Object
+  Module Class
+  Enumerable Enumerator Enumerator::Lazy Range
+  Numeric Integer Float
+  Rational Complex
+  Array Hash String
+  File IO
+  ENV.singleton_class
 ]
 
 guard -> { !defined?(SlowSpecsTagger) } do
   if RUBY_ENGINE == "ruby"
     modules.each do |mod|
-      file = File.expand_path("../methods/#{mod.name}.txt", __FILE__)
+      file = File.expand_path("../methods/#{mod}.txt", __FILE__)
       methods = ruby_exe("puts #{mod}.public_instance_methods(false).sort")
       methods = methods.lines.map { |line| line.chomp.to_sym }
       contents = methods.map { |meth| "#{meth}\n" }.join
@@ -39,8 +40,8 @@
 
   code = <<-EOR
   #{modules.inspect}.each { |m|
-    puts m.name
-    puts m.public_instance_methods(false).sort
+    puts m
+    puts eval(m).public_instance_methods(false).sort
     puts
   }
   EOR
@@ -51,10 +52,10 @@
   end
 
   modules.each do |mod|
-    describe "Public methods on #{mod.name}" do
-      file = File.expand_path("../methods/#{mod.name}.txt", __FILE__)
+    describe "Public methods on #{mod}" do
+      file = File.expand_path("../methods/#{mod}.txt", __FILE__)
       expected = File.readlines(file).map { |line| line.chomp.to_sym }
-      methods = all_methods[mod.name]
+      methods = all_methods[mod]
 
       if methods == expected
         it "are the same as on MRI" do