Implement C API rb_io_set_nonblock

Author: bjfish

CHANGELOG.md

@@ -60,6 +60,7 @@ Compatibility:
 * The `.bundle` file extension is now used for C extensions on macOS (#1819, #1837).
 * Implemented `Comparable#clamp` (#1517).
 * Implemented `rb_gc_register_mark_object` and `rb_enc_str_asciionly_p` (#1856, @chrisseaton).
+* Implemented `rb_io_set_nonblock` (#1741).
 
 Performance:
 

spec/ruby/optional/capi/ext/io_spec.c

@@ -201,6 +201,14 @@ VALUE io_spec_rb_io_close(VALUE self, VALUE io) {
   return rb_io_close(io);
 }
 
+VALUE io_spec_rb_io_set_nonblock(VALUE self, VALUE io) {
+  rb_io_t* fp;
+  GetOpenFile(io, fp);
+  rb_io_set_nonblock(fp);
+  int flags = fcntl(fp->fd, F_GETFL, 0);
+  return flags & O_NONBLOCK ? Qtrue : Qfalse;
+}
+
 /*
  * this is needed to ensure rb_io_wait_*able functions behave
  * predictably because errno may be set to unexpected values
@@ -225,6 +233,7 @@ void Init_io_spec(void) {
   rb_define_method(cls, "rb_io_check_readable", io_spec_rb_io_check_readable, 1);
   rb_define_method(cls, "rb_io_check_writable", io_spec_rb_io_check_writable, 1);
   rb_define_method(cls, "rb_io_check_closed", io_spec_rb_io_check_closed, 1);
+  rb_define_method(cls, "rb_io_set_nonblock", io_spec_rb_io_set_nonblock, 1);
   rb_define_method(cls, "rb_io_taint_check", io_spec_rb_io_taint_check, 1);
   rb_define_method(cls, "rb_io_wait_readable", io_spec_rb_io_wait_readable, 2);
   rb_define_method(cls, "rb_io_wait_writable", io_spec_rb_io_wait_writable, 1);

spec/ruby/optional/capi/io_spec.rb

@@ -151,6 +151,12 @@
     end
   end
 
+  describe "rb_io_set_nonblock" do
+    it "returns true when nonblock flag is set" do
+      @o.rb_io_set_nonblock(@io).should be_true
+    end
+  end
+
   # NOTE: unlike the name might suggest in MRI this function checks if an
   # object is frozen, *not* if it's tainted.
   describe "rb_io_taint_check" do

src/main/c/cext/ruby.c

@@ -4049,6 +4049,16 @@ int rb_cloexec_dup2(int oldfd, int newfd) {
   rb_tr_error("rb_cloexec_dup2 not implemented");
 }
 
+static int rb_fd_set_nonblock(int fd) {
+  int oflags = fcntl(fd, F_GETFL);
+  if (oflags == -1)
+    return -1;
+  if (oflags & O_NONBLOCK)
+    return 0;
+  oflags |= O_NONBLOCK;
+  return fcntl(fd, F_SETFL, oflags);
+}
+
 int rb_cloexec_pipe(int fildes[2]) {
   rb_tr_error("rb_cloexec_pipe not implemented");
 }
@@ -4586,7 +4596,9 @@ VALUE rb_io_set_write_io(VALUE io, VALUE w) {
 }
 
 void rb_io_set_nonblock(rb_io_t *fptr) {
-  rb_tr_error("rb_io_set_nonblock not implemented");
+  if (rb_fd_set_nonblock(fptr->fd) != 0) {
+    rb_sys_fail("rb_io_set_nonblock failed");
+  }
 }
 
 ssize_t rb_io_bufwrite(VALUE io, const void *buf, size_t size) {