[GR-28934] Remove TODO

Nicolas Laurent · Nicolas Laurent · commit e26ae048a5bc · 2021-01-27T19:40:03.000Z
PullRequest: truffleruby/2367
diff --git a/src/main/java/org/truffleruby/core/module/ModuleNodes.java b/src/main/java/org/truffleruby/core/module/ModuleNodes.java
@@ -1773,7 +1773,8 @@ protected RubyNode coerceToBoolean(RubyNode inherit) {
             return BooleanCastWithDefaultNodeGen.create(true, inherit);
         }
 
-        // TODO (pitr-ch 30-Mar-2016): cache lookup
+        // NOTE(norswap): We considered caching the lookup here, but determined that the resulting complexity
+        //   increase in LookupMethodNode wasn't worth it, as it would slow down the more common cases.
 
         @Specialization(guards = "inherit")
         protected boolean isMethodDefinedInherit(RubyModule module, String name, boolean inherit) {

Original file line number	Diff line number	Diff line change
`@@ -1773,7 +1773,8 @@ protected RubyNode coerceToBoolean(RubyNode inherit) {`
`1773`	`1773`	`return BooleanCastWithDefaultNodeGen.create(true, inherit);`
`1774`	`1774`	`}`
`1775`	`1775`
`1776`		`- // TODO (pitr-ch 30-Mar-2016): cache lookup`
	`1776`	`+ // NOTE(norswap): We considered caching the lookup here, but determined that the resulting complexity`
	`1777`	`+ // increase in LookupMethodNode wasn't worth it, as it would slow down the more common cases.`
`1777`	`1778`
`1778`	`1779`	`@Specialization(guards = "inherit")`
`1779`	`1780`	`protected boolean isMethodDefinedInherit(RubyModule module, String name, boolean inherit) {`