[GR-27287] Mark core and standard library as non-internal by default

PullRequest: truffleruby/2141

Author: eregon

src/main/java/org/truffleruby/core/CoreLibrary.java

@@ -123,7 +123,7 @@ public class CoreLibrary {
     private final RubyContext context;
     private final RubyLanguage language;
 
-    public final SourceSection sourceSection;
+    public final SourceSection sourceSection = initCoreSourceSection();
 
     public final RubyClass argumentErrorClass;
     public final RubyClass arrayClass;
@@ -261,14 +261,11 @@ public class CoreLibrary {
     public final String corePath;
 
     @TruffleBoundary
-    private SourceSection initCoreSourceSection(RubyContext context) {
+    private SourceSection initCoreSourceSection() {
         final Source.SourceBuilder builder = Source.newBuilder(TruffleRuby.LANGUAGE_ID, "", "(core)");
-        if (context.getOptions().CORE_AS_INTERNAL) {
-            builder.internal(true);
-        }
+        builder.internal(true);
 
         final Source source;
-
         try {
             source = builder.build();
         } catch (IOException e) {
@@ -311,7 +308,6 @@ public CoreLibrary(RubyContext context, RubyLanguage language) {
         this.language = language;
         this.coreLoadPath = buildCoreLoadPath();
         this.corePath = coreLoadPath + File.separator + "core" + File.separator;
-        this.sourceSection = initCoreSourceSection(context);
         this.node = SingletonClassNode.getUncached();
 
         // Nothing in this constructor can use RubyContext.getCoreLibrary() as we are building it!

src/main/java/org/truffleruby/options/Options.java

@@ -75,9 +75,9 @@ public class Options {
     public final boolean TRACE_CALLS;
     /** --coverage-global=false */
     public final boolean COVERAGE_GLOBAL;
-    /** --core-as-internal=true */
+    /** --core-as-internal=false */
     public final boolean CORE_AS_INTERNAL;
-    /** --stdlib-as-internal=true */
+    /** --stdlib-as-internal=false */
     public final boolean STDLIB_AS_INTERNAL;
     /** --exceptions-store-java=false */
     public final boolean EXCEPTIONS_STORE_JAVA;

src/options.yml

@@ -52,8 +52,8 @@ EXPERT:
     COVERAGE_GLOBAL: [coverage-global, boolean, false, Run coverage for all code and print results on exit]
 
     # Options helpful in for debugging, potentially also for user code
-    CORE_AS_INTERNAL: [core-as-internal, boolean, true, 'Mark core library sources as internal']
-    STDLIB_AS_INTERNAL: [stdlib-as-internal, boolean, true, 'Mark stdlib sources as internal']
+    CORE_AS_INTERNAL: [core-as-internal, boolean, false, 'Mark core library sources as internal']
+    STDLIB_AS_INTERNAL: [stdlib-as-internal, boolean, false, 'Mark stdlib sources as internal']
     LAZY_TRANSLATION_USER: [lazy-translation-user, boolean, DEFAULT_LAZY, 'Lazily translation of stdlib, gem and user source files']
 
     # Options to tweak backtraces

src/shared/java/org/truffleruby/shared/options/OptionsCatalog.java

@@ -47,8 +47,8 @@ public class OptionsCatalog {
     public static final OptionKey<Boolean> HOST_INTEROP_KEY = new OptionKey<>(true);
     public static final OptionKey<Boolean> TRACE_CALLS_KEY = new OptionKey<>(true);
     public static final OptionKey<Boolean> COVERAGE_GLOBAL_KEY = new OptionKey<>(false);
-    public static final OptionKey<Boolean> CORE_AS_INTERNAL_KEY = new OptionKey<>(true);
-    public static final OptionKey<Boolean> STDLIB_AS_INTERNAL_KEY = new OptionKey<>(true);
+    public static final OptionKey<Boolean> CORE_AS_INTERNAL_KEY = new OptionKey<>(false);
+    public static final OptionKey<Boolean> STDLIB_AS_INTERNAL_KEY = new OptionKey<>(false);
     public static final OptionKey<Boolean> LAZY_TRANSLATION_USER_KEY = new OptionKey<>(DEFAULT_LAZY_KEY.getDefaultValue());
     public static final OptionKey<Boolean> EXCEPTIONS_STORE_JAVA_KEY = new OptionKey<>(false);
     public static final OptionKey<Boolean> EXCEPTIONS_PRINT_JAVA_KEY = new OptionKey<>(false);