[GR-26844] Ignore refinements for Primitive.object_respond_to?

PullRequest: truffleruby/2080

Author: eregon

src/main/.checkstyle_checks.xml

@@ -231,6 +231,10 @@
     <property name="format" value="CompilerDirectives\.transferToInterpreterAndInvalidate\(\);\s+\w+Node\s+=\s+(?!insert\()"/>
     <property name="message" value="Lazily initialized child nodes must be explicitly inserted into the AST."/>
   </module>
+  <module name="RegexpMultiline">
+    <property name="format" value="CompilerDirectives\.transferToInterpreterAndInvalidate\(\);\s+\w+\s+=\s+(?!insert\()\w+\.create\("/>
+    <property name="message" value="Lazily initialized child nodes must be explicitly inserted into the AST."/>
+  </module>
   <module name="RegexpHeader">
     <property name="header" value='/\*\n (\* Copyright \(c\) (20[0-9][0-9], )?20[0-9][0-9] Oracle and/or its affiliates\. All rights reserved\. This|\*\*\*\*\* BEGIN LICENSE BLOCK \*\*\*\*\*)\n (\* code is released under a tri EPL/GPL/LGPL license\. You can use it,|\* Version: EPL 2\.0/GPL 2\.0/LGPL 2\.1)\n (\* redistribute it and/or modify it under the terms of the:|\*)\n (\*|\* The contents of this file are subject to the Eclipse Public)\n (\* Eclipse Public License version 2\.0|\* License Version 2\.0 \(the "License"\); you may not use this file)\n (\* GNU General Public License version 2|\* except in compliance with the License\. You may obtain a copy of)\n (\* GNU Lesser General Public License version 2\.1|\* the License at http://www.eclipse.org/legal/epl-v20.html)\n (\*/|\*)\n'/>
     <property name="fileExtensions" value="java"/>

src/main/java/org/truffleruby/core/kernel/KernelNodes.java

@@ -1559,7 +1559,7 @@ public abstract static class RespondToNode extends CoreMethodNode {
         @Child private InternalRespondToNode dispatch;
         @Child private InternalRespondToNode dispatchIgnoreVisibility;
         @Child private InternalRespondToNode dispatchRespondToMissing;
-        @Child private ReadCallerFrameNode readCallerFrame = ReadCallerFrameNode.create();
+        @Child private ReadCallerFrameNode readCallerFrame;
         @Child private DispatchNode respondToMissingNode;
         @Child private BooleanCastNode booleanCastNode;
         private final ConditionProfile ignoreVisibilityProfile = ConditionProfile.create();
@@ -1572,6 +1572,8 @@ public RespondToNode() {
             dispatchRespondToMissing = InternalRespondToNode.create();
         }
 
+        /** Callers should pass null for the frame here, unless they want to use refinements and can ensure the direct
+         * caller is a Ruby method */
         public abstract boolean executeDoesRespondTo(VirtualFrame frame, Object object, Object name,
                 boolean includeProtectedAndPrivate);
 
@@ -1600,11 +1602,7 @@ protected boolean doesRespondToString(
                 return true;
             } else if (respondToMissingProfile
                     .profile(dispatchRespondToMissing.execute(frame, object, "respond_to_missing?"))) {
-                return respondToMissing(
-                        frame,
-                        object,
-                        getSymbol(name.rope),
-                        includeProtectedAndPrivate);
+                return respondToMissing(object, getSymbol(name.rope), includeProtectedAndPrivate);
             } else {
                 return false;
             }
@@ -1630,14 +1628,13 @@ protected boolean doesRespondToSymbol(
                 return true;
             } else if (respondToMissingProfile
                     .profile(dispatchRespondToMissing.execute(frame, object, "respond_to_missing?"))) {
-                return respondToMissing(frame, object, name, includeProtectedAndPrivate);
+                return respondToMissing(object, name, includeProtectedAndPrivate);
             } else {
                 return false;
             }
         }
 
-        private boolean respondToMissing(VirtualFrame frame, Object object, RubySymbol name,
-                boolean includeProtectedAndPrivate) {
+        private boolean respondToMissing(Object object, RubySymbol name, boolean includeProtectedAndPrivate) {
             if (respondToMissingNode == null) {
                 CompilerDirectives.transferToInterpreterAndInvalidate();
                 respondToMissingNode = insert(DispatchNode.create());
@@ -1654,6 +1651,10 @@ private boolean respondToMissing(VirtualFrame frame, Object object, RubySymbol n
 
         private void useCallerRefinements(VirtualFrame frame) {
             if (frame != null) {
+                if (readCallerFrame == null) {
+                    CompilerDirectives.transferToInterpreterAndInvalidate();
+                    readCallerFrame = insert(ReadCallerFrameNode.create());
+                }
                 DeclarationContext context = RubyArguments.getDeclarationContext(readCallerFrame.execute(frame));
                 RubyArguments.setDeclarationContext(frame, context);
             }

src/main/java/org/truffleruby/core/string/StringNodes.java

@@ -465,14 +465,14 @@ protected boolean equal(RubyString a, RubyString b) {
         }
 
         @Specialization(guards = "!isRubyString(b)")
-        protected boolean equal(VirtualFrame frame, RubyString a, Object b) {
+        protected boolean equal(RubyString a, Object b) {
             if (respondToNode == null) {
                 CompilerDirectives.transferToInterpreterAndInvalidate();
                 respondToNode = insert(KernelNodesFactory.RespondToNodeFactory.create(null, null, null));
             }
 
             if (respondToNode
-                    .executeDoesRespondTo(frame, b, coreStrings().TO_STR.createInstance(getContext()), false)) {
+                    .executeDoesRespondTo(null, b, coreStrings().TO_STR.createInstance(getContext()), false)) {
                 if (objectEqualNode == null) {
                     CompilerDirectives.transferToInterpreterAndInvalidate();
                     objectEqualNode = insert(DispatchNode.create());

src/main/java/org/truffleruby/core/support/TypeNodes.java

@@ -55,7 +55,6 @@
 import com.oracle.truffle.api.dsl.ImportStatic;
 import com.oracle.truffle.api.dsl.NodeChild;
 import com.oracle.truffle.api.dsl.Specialization;
-import com.oracle.truffle.api.frame.VirtualFrame;
 import com.oracle.truffle.api.library.CachedLibrary;
 import com.oracle.truffle.api.object.DynamicObjectLibrary;
 import com.oracle.truffle.api.object.HiddenKey;
@@ -83,8 +82,9 @@ public static abstract class ObjectRespondToNode extends PrimitiveArrayArguments
                 .create(null, null, null);
 
         @Specialization
-        protected boolean objectRespondTo(VirtualFrame frame, Object object, Object name, boolean includePrivate) {
-            return respondToNode.executeDoesRespondTo(frame, object, name, includePrivate);
+        protected boolean objectRespondTo(Object object, Object name, boolean includePrivate) {
+            // Do not pass a frame here, we want to ignore refinements and not need to read the caller frame
+            return respondToNode.executeDoesRespondTo(null, object, name, includePrivate);
         }
 
     }