[GR-17457] Fix InteropLibrary methods spec

PullRequest: truffleruby/2216

Author: eregon

spec/truffle/interop/methods_spec.rb

@@ -11,26 +11,28 @@
 require_relative '../../ruby/spec_helper'
 
 describe "Truffle::Interop" do
-  it "has a method for each InteropLibrary message" do
-    all_methods = Primitive.interop_library_all_methods
-    all_methods -= %w[getFactory getUncached]
-    expected = all_methods.map do |name|
-      name = name.gsub(/([a-z])([A-Z])/) { "#{$1}_#{$2.downcase}" }
-      if name.start_with?('is_', 'has_', 'fits_')
-        name += '?'
-      end
-      if name.start_with?('is_')
-        name = name[3..-1]
-      elsif name.start_with?('get_')
-        name = name[4..-1]
-      end
-      name.to_sym
-    end.sort
+  # Run locally and in TruffleRuby's CI but not in GraalVM's CI to not prevent adding new interop messages
+  guard -> { !ENV.key?('BUILD_URL') or ENV.key?('TRUFFLERUBY_CI') } do
+    it "has a method for each InteropLibrary message" do
+      all_methods = Primitive.interop_library_all_methods
+      expected = all_methods.map do |name|
+        name = name.gsub(/([a-z])([A-Z])/) { "#{$1}_#{$2.downcase}" }
+        if name.start_with?('is_', 'has_', 'fits_')
+          name += '?'
+        end
+        if name.start_with?('is_')
+          name = name[3..-1]
+        elsif name.start_with?('get_')
+          name = name[4..-1]
+        end
+        name.to_sym
+      end.sort
 
-    actual = Truffle::Interop.methods.sort
+      actual = Truffle::Interop.methods.sort
 
-    # pp expected
-    # pp actual
-    (expected - actual).should == []
+      # pp expected
+      # pp actual
+      (expected - actual).should == []
+    end
   end
 end

src/main/java/org/truffleruby/interop/InteropNodes.java

@@ -123,7 +123,7 @@ protected RubyArray allMethodsOfInteropLibrary() {
         private static String[] publicInteropLibraryMethods() {
             List<String> methods = new ArrayList<>();
             for (Method method : InteropLibrary.class.getDeclaredMethods()) {
-                if (Modifier.isPublic(method.getModifiers())) {
+                if (Modifier.isPublic(method.getModifiers()) && !Modifier.isStatic(method.getModifiers())) {
                     if (!methods.contains(method.getName())) {
                         methods.add(method.getName());
                     }