[GR-19220] Call divmod when coercion to Float fails for sleep (#2289)

PullRequest: truffleruby/2496

Author: eregon

CHANGELOG.md

@@ -70,6 +70,7 @@ Compatibility:
 * Improved compatibility of `Signal.trap` and `Kernel#trap` (#2287, @chrisseaton).
 * Implemented `GC.stat(:total_allocated_objects)` as `0` (#2292, @chrisseaton).
 * `ObjectSpace::WeakMap` now supports immediate and frozen values as both keys and values (#2267).
+* Call `divmod` when coercion to `Float` fails for `#sleep` (#2289, @LillianZ).
 
 Performance:
 

spec/ruby/core/kernel/sleep_spec.rb

@@ -22,6 +22,12 @@
     sleep(Rational(1, 999)).should >= 0
   end
 
+  it "accepts any Object that reponds to divmod" do
+    o = Object.new
+    def o.divmod(*); [0, 0.001]; end
+    sleep(o).should >= 0
+  end
+
   it "raises an ArgumentError when passed a negative duration" do
     -> { sleep(-0.1) }.should raise_error(ArgumentError)
     -> { sleep(-1) }.should raise_error(ArgumentError)

src/main/java/org/truffleruby/core/cast/DurationToMillisecondsNode.java

@@ -9,23 +9,22 @@
  */
 package org.truffleruby.core.cast;
 
+import com.oracle.truffle.api.dsl.Cached;
 import org.truffleruby.language.Nil;
 import org.truffleruby.language.RubyContextSourceNode;
 import org.truffleruby.language.NotProvided;
 import org.truffleruby.language.RubyDynamicObject;
 import org.truffleruby.language.RubyNode;
 import org.truffleruby.language.control.RaiseException;
 
-import com.oracle.truffle.api.CompilerDirectives;
 import com.oracle.truffle.api.dsl.NodeChild;
 import com.oracle.truffle.api.dsl.Specialization;
 import com.oracle.truffle.api.profiles.ConditionProfile;
+import org.truffleruby.language.dispatch.DispatchNode;
 
 @NodeChild(value = "duration", type = RubyNode.class)
 public abstract class DurationToMillisecondsNode extends RubyContextSourceNode {
 
-    @Child NumericToFloatNode floatCastNode;
-
     private final ConditionProfile durationLessThanZeroProfile = ConditionProfile.create();
     private final boolean acceptsNil;
 
@@ -65,12 +64,14 @@ protected long durationNil(Nil duration) {
     }
 
     @Specialization
-    protected long duration(RubyDynamicObject duration) {
-        if (floatCastNode == null) {
-            CompilerDirectives.transferToInterpreterAndInvalidate();
-            floatCastNode = insert(NumericToFloatNodeGen.create());
-        }
-        return duration(floatCastNode.executeDouble(duration));
+    protected Object duration(RubyDynamicObject duration,
+            @Cached DispatchNode durationToMilliseconds,
+            @Cached ToLongNode toLongNode) {
+        final Object milliseconds = durationToMilliseconds.call(
+                coreLibrary().truffleKernelOperationsModule,
+                "convert_duration_to_milliseconds",
+                duration);
+        return validate(toLongNode.execute(milliseconds));
     }
 
     private long validate(long durationInMillis) {

src/main/java/org/truffleruby/core/cast/NumericToFloatNode.java

@@ -22,6 +22,14 @@ def self.to_enum_with_size(enum, method, size_method)
       enum.to_enum(method) { enum.send(size_method) }
     end
 
+    def self.convert_duration_to_milliseconds(duration)
+      unless duration.respond_to?(:divmod)
+        raise TypeError, "can't convert #{duration.class} into time interval"
+      end
+      a, b = duration.divmod(1)
+      ((a + b) * 1000)
+    end
+
     def self.define_hooked_variable(name, getter, setter, defined = proc { 'global-variable' })
       define_hooked_variable_with_is_defined(name, getter, setter, defined)
     end