[GR-17086] Do not translate IllegalArgumentException

PullRequest: truffleruby/2878

Author: eregon

src/launcher/java/org/truffleruby/launcher/CommandLineOptions.java

@@ -81,10 +81,6 @@ public <T> void setOption(OptionDescriptor descriptor, T value) {
         setOptionRaw(descriptor, RubyOptionTypes.valueToString(value));
     }
 
-    public <T> T getOption(OptionDescriptor descriptor) {
-        return RubyOptionTypes.parseValue(descriptor, getOptionRaw(descriptor));
-    }
-
     public <T> void appendOptionValue(OptionDescriptor descriptor, String newValue) {
         final OptionType<?> type = descriptor.getKey().getType();
 
@@ -105,7 +101,7 @@ private void setOptionRaw(OptionDescriptor descriptor, String value) {
         options.put(descriptor.getName(), value);
     }
 
-    private <T> String getOptionRaw(OptionDescriptor descriptor) {
+    public String getOptionRaw(OptionDescriptor descriptor) {
         return options.getOrDefault(
                 descriptor.getName(),
                 RubyOptionTypes.valueToString(descriptor.getKey().getDefaultValue()));

src/launcher/java/org/truffleruby/launcher/CommandLineParser.java

@@ -101,7 +101,7 @@ private boolean endOfInterpreterArguments() {
     }
 
     private void processArgv() {
-        boolean argvGlobalsOn = config.getOption(OptionsCatalog.ARGV_GLOBALS);
+        boolean argvGlobalsOn = config.getOptionRaw(OptionsCatalog.ARGV_GLOBALS).equals("true");
         ArrayList<String> arglist = new ArrayList<>();
         for (; argumentIndex < arguments.size(); argumentIndex++) {
             String arg = getCurrentArgument();

src/main/java/org/truffleruby/RubyContext.java

@@ -376,9 +376,10 @@ private Options createOptions(TruffleLanguage.Env env, LanguageOptions languageO
         if (options.OPTIONS_LOG && RubyLanguage.LOGGER.isLoggable(Level.CONFIG)) {
             for (OptionDescriptor descriptor : OptionsCatalog.allDescriptors()) {
                 assert descriptor.getName().startsWith(TruffleRuby.LANGUAGE_ID);
-                final String xName = descriptor.getName().substring(TruffleRuby.LANGUAGE_ID.length() + 1);
+                final String optionName = descriptor.getName().substring(TruffleRuby.LANGUAGE_ID.length() + 1);
                 RubyLanguage.LOGGER.config(
-                        "option " + xName + "=" + RubyOptionTypes.valueToString(options.fromDescriptor(descriptor)));
+                        "option " + optionName + "=" +
+                                RubyOptionTypes.valueToString(options.fromDescriptor(descriptor)));
             }
         }
 

src/main/java/org/truffleruby/collections/IntHashMap.java

@@ -71,12 +71,6 @@ public IntHashMap(int initialCapacity) {
     @SuppressWarnings({ "unchecked", "rawtypes" })
     public IntHashMap(int initialCapacity, float loadFactor) {
         super();
-        if (initialCapacity < 0) {
-            throw new IllegalArgumentException("Illegal Capacity: " + initialCapacity);
-        }
-        if (loadFactor <= 0) {
-            throw new IllegalArgumentException("Illegal Load: " + loadFactor);
-        }
         if (initialCapacity == 0) {
             initialCapacity = 1;
         }

src/main/java/org/truffleruby/core/exception/CoreExceptions.java

@@ -14,6 +14,7 @@
 import java.io.IOException;
 import java.util.EnumSet;
 
+import com.oracle.truffle.api.CompilerDirectives;
 import com.oracle.truffle.api.interop.InvalidBufferOffsetException;
 import com.oracle.truffle.api.interop.UnknownKeyException;
 import org.jcodings.Encoding;
@@ -1077,7 +1078,7 @@ public RubyException rangeErrorConvertToInt(long value, Node currentNode) {
         } else if (value > Integer.MAX_VALUE) {
             direction = "big";
         } else {
-            throw new IllegalArgumentException();
+            throw CompilerDirectives.shouldNotReachHere("long fitting in int");
         }
 
         return rangeError(StringUtils.format("integer %d too %s to convert to `int'", value, direction), currentNode);

src/main/java/org/truffleruby/core/format/FormatExceptionTranslator.java

@@ -9,6 +9,7 @@
  */
 package org.truffleruby.core.format;
 
+import com.oracle.truffle.api.CompilerDirectives;
 import com.oracle.truffle.api.CompilerDirectives.TruffleBoundary;
 import com.oracle.truffle.api.nodes.Node;
 import org.truffleruby.RubyContext;
@@ -49,9 +50,8 @@ public static RuntimeException translate(RubyContext context, Node currentNode,
         } else if (exception instanceof InvalidFormatException) {
             final InvalidFormatException e = (InvalidFormatException) exception;
             return new RaiseException(context, coreExceptions.argumentError(e.getMessage(), currentNode));
-
         } else {
-            throw new IllegalArgumentException();
+            throw CompilerDirectives.shouldNotReachHere(exception);
         }
     }
 

src/main/java/org/truffleruby/core/format/pack/SimplePackTreeBuilder.java

@@ -15,6 +15,7 @@
 import java.util.Deque;
 import java.util.List;
 
+import com.oracle.truffle.api.CompilerDirectives;
 import org.truffleruby.RubyLanguage;
 import org.truffleruby.core.format.FormatEncoding;
 import org.truffleruby.core.format.FormatNode;
@@ -293,7 +294,7 @@ private void appendFloatNode(int size, ByteOrder byteOrder, int count) {
                 typeNode = readNode;
                 break;
             default:
-                throw new IllegalArgumentException();
+                throw CompilerDirectives.shouldNotReachHere();
         }
 
         appendNode(sharedTreeBuilder.applyCount(
@@ -341,7 +342,7 @@ private FormatNode writeInteger(int size, ByteOrder byteOrder, FormatNode readNo
                 }
                 break;
             default:
-                throw new IllegalArgumentException(Integer.toString(size));
+                throw CompilerDirectives.shouldNotReachHere(Integer.toString(size));
         }
 
         return WriteBytesNodeGen.create(convertNode);

src/main/java/org/truffleruby/core/format/unpack/SimpleUnpackTreeBuilder.java

@@ -15,6 +15,7 @@
 import java.util.Deque;
 import java.util.List;
 
+import com.oracle.truffle.api.CompilerDirectives;
 import org.truffleruby.RubyLanguage;
 import org.truffleruby.core.format.FormatNode;
 import org.truffleruby.core.format.SharedTreeBuilder;
@@ -306,7 +307,7 @@ private void appendFloatNode(int size, ByteOrder byteOrder, int count) {
                 decodeNode = ReinterpretLongAsDoubleNodeGen.create(readNode);
                 break;
             default:
-                throw new IllegalArgumentException();
+                throw CompilerDirectives.shouldNotReachHere();
         }
 
         final FormatNode writeNode = WriteValueNodeGen.create(new OutputNode(), decodeNode);
@@ -344,7 +345,7 @@ private FormatNode createIntegerDecodeNode(int size, ByteOrder byteOrder, boolea
                 }
                 break;
             default:
-                throw new IllegalArgumentException();
+                throw CompilerDirectives.shouldNotReachHere();
         }
 
         if (!signed) {

src/main/java/org/truffleruby/core/kernel/TruffleKernelNodes.java

@@ -192,7 +192,8 @@ protected Object defineHookedVariableInnerNode(
                     name.getString(),
                     getter,
                     setter,
-                    isDefined);
+                    isDefined,
+                    this);
             return nil;
         }
 

src/main/java/org/truffleruby/core/method/MethodFilter.java

@@ -9,6 +9,7 @@
  */
 package org.truffleruby.core.method;
 
+import com.oracle.truffle.api.CompilerDirectives;
 import org.truffleruby.language.Visibility;
 import org.truffleruby.language.methods.InternalMethod;
 
@@ -57,7 +58,7 @@ public static MethodFilter by(Visibility visibility) {
             case PRIVATE:
                 return PRIVATE;
             default:
-                throw new IllegalArgumentException("unsupported visibility: " + visibility);
+                throw CompilerDirectives.shouldNotReachHere("unsupported visibility: " + visibility);
         }
     }
 }