Fix formatting and code style in specs

Author: andrykonchin

spec/ruby/core/exception/case_compare_spec.rb

@@ -26,13 +26,11 @@
   end
 
   it "returns true if receiver is generic and arg is kind of SystemCallError" do
-    unknown_error_number = Errno.constants.size
     e = SystemCallError.new('foo', @example_errno)
     SystemCallError.===(e).should == true
   end
 
   it "returns false if receiver is generic and arg is not kind of SystemCallError" do
-    unknown_error_number = Errno.constants.size
     e = Object.new
     SystemCallError.===(e).should == false
   end

spec/ruby/optional/capi/exception_spec.rb

@@ -101,7 +101,7 @@
   end
 
   describe "rb_syserr_new" do
-    it "returns system error with nil message" do
+    it "returns system error with default message when passed message is NULL" do
       exception = @s.rb_syserr_new(Errno::ENOENT::Errno, nil)
       exception.class.should == Errno::ENOENT
       exception.message.should include("No such file or directory")
@@ -110,16 +110,17 @@
 
     it "returns system error with custom message" do
       exception = @s.rb_syserr_new(Errno::ENOENT::Errno, "custom message")
+
       exception.message.should include("custom message")
       exception.class.should == Errno::ENOENT
       exception.should.is_a?(SystemCallError)
     end
   end
 
   describe "rb_syserr_new_str" do
-    it "returns system error with nil message" do
-      const = Errno::ENOENT
-      exception = @s.rb_syserr_new_str(const::Errno, nil)
+    it "returns system error with default message when passed message is nil" do
+      exception = @s.rb_syserr_new_str(Errno::ENOENT::Errno, nil)
+
       exception.message.should include("No such file or directory")
       exception.class.should == Errno::ENOENT
       exception.should.is_a?(SystemCallError)

spec/ruby/optional/capi/ext/exception_spec.c

@@ -37,11 +37,13 @@ VALUE exception_spec_rb_set_errinfo(VALUE self, VALUE exc) {
 }
 
 VALUE exception_spec_rb_syserr_new(VALUE self, VALUE num, VALUE msg) {
-  char *cstr;
-  if(msg != Qnil) {
+  int n = NUM2INT(num);
+  char *cstr = NULL;
+
+  if (msg != Qnil) {
     cstr = StringValuePtr(msg);
   }
-  int n = NUM2INT(num);
+
   return rb_syserr_new(n, cstr);
 }
 

src/main/java/org/truffleruby/core/exception/ErrnoErrorNode.java

@@ -42,6 +42,7 @@ protected RubySystemCallError errnoError(RubyClass rubyClass, int errno, Object
 
         final Object errnoDescription;
         final RubyClass errnoClass;
+
         if (errnoName == null) {
             errnoClass = getContext().getCoreLibrary().systemCallErrorClass;
             errnoDescription = nil;
@@ -52,12 +53,10 @@ protected RubySystemCallError errnoError(RubyClass rubyClass, int errno, Object
                 errnoClass = getContext().getCoreLibrary().getErrnoClass(errnoName);
             }
 
-
             errnoDescription = createString(fromJavaStringNode, ErrnoDescriptions.getDescription(errnoName),
                     Encodings.UTF_8);
         }
 
-
         final RubyString errorMessage = formatMessage(errnoDescription, errno, extraMessage);
 
         return ExceptionOperations
@@ -66,10 +65,12 @@ protected RubySystemCallError errnoError(RubyClass rubyClass, int errno, Object
 
     private RubyString formatMessage(Object errnoDescription, int errno, Object extraMessage) {
         assert extraMessage instanceof RubyString || extraMessage instanceof ImmutableRubyString;
+
         if (formatMessageNode == null) {
             CompilerDirectives.transferToInterpreterAndInvalidate();
             formatMessageNode = insert(DispatchNode.create());
         }
+
         return (RubyString) formatMessageNode.call(
                 getContext().getCoreLibrary().truffleExceptionOperationsModule,
                 "format_errno_error_message",