Thread::Backtrace::Location#absolute_path should be nil for core methods defined in Ruby

Author: eregon

spec/ruby/core/thread/backtrace/location/absolute_path_spec.rb

@@ -36,6 +36,19 @@
     end
   end
 
+  context "when used in a core method" do
+    it "returns nil" do
+      location = nil
+      tap { location = caller_locations(1, 1)[0] }
+      location.label.should == "tap"
+      if location.path.start_with?("<internal:")
+        location.absolute_path.should == nil
+      else
+        location.absolute_path.should == File.realpath(__FILE__)
+      end
+    end
+  end
+
   context "canonicalization" do
     platform_is_not :windows do
       before :each do

spec/truffle/thread/backtrace/location/absolute_path_spec.rb

@@ -27,6 +27,7 @@
 import com.oracle.truffle.api.dsl.Specialization;
 import com.oracle.truffle.api.source.Source;
 import com.oracle.truffle.api.source.SourceSection;
+import org.truffleruby.language.backtrace.BacktraceFormatter;
 
 @CoreModule(value = "Thread::Backtrace::Location", isClass = true)
 public class ThreadBacktraceLocationNodes {
@@ -47,15 +48,17 @@ public abstract static class AbsolutePathNode extends UnaryCoreMethodNode {
 
         @TruffleBoundary
         @Specialization
-        protected RubyString absolutePath(RubyBacktraceLocation threadBacktraceLocation,
+        protected Object absolutePath(RubyBacktraceLocation threadBacktraceLocation,
                 @Cached StringNodes.MakeStringNode makeStringNode) {
             final SourceSection sourceSection = getAvailableSourceSection(getContext(), threadBacktraceLocation);
 
             if (sourceSection == null) {
                 return coreStrings().UNKNOWN.createInstance(getContext());
             } else {
                 final Source source = sourceSection.getSource();
-                if (source.getPath() != null) { // A normal file
+                if (BacktraceFormatter.isRubyCore(getContext(), source)) {
+                    return nil;
+                } else if (source.getPath() != null) { // A normal file
                     final String path = getContext().getSourcePath(source);
                     final String canonicalPath = getContext().getFeatureLoader().canonicalize(path);
                     final Rope cachedRope = getContext()

src/main/java/org/truffleruby/core/thread/ThreadBacktraceLocationNodes.java

@@ -345,7 +345,7 @@ public static boolean isUserSourceSection(RubyContext context, SourceSection sou
         return isAvailable(sourceSection) && !isRubyCore(context, sourceSection.getSource());
     }
 
-    private static boolean isRubyCore(RubyContext context, Source source) {
+    public static boolean isRubyCore(RubyContext context, Source source) {
         final String path = RubyContext.getPath(source);
         return path.startsWith(context.getCoreLibrary().coreLoadPath);
     }