Skip to content

Commit d028c39

Browse files
committed
C-API specs in :next specs do not work
* Because `#ifdef RUBY_VERSION_IS_3_2` uses the real Ruby version and is not affected by `PRETEND_RUBY_VERSION`.
1 parent 28555f1 commit d028c39

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

doc/contributor/workflow.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -322,6 +322,9 @@ When working on a feature from the next version of Ruby, add the spec file in
322322
the corresponding files list in `spec/truffleruby.next-specs` so that the specs
323323
are run in CI too.
324324

325+
However this does not work for C-API specs,
326+
because those use `#ifdef RUBY_VERSION_IS_3_2` and that version cannot be faked.
327+
325328
## How to fix a failing MRI test
326329

327330
Remove the exclusion of either the file (`test/mri/failing.exclude`) or the

spec/truffleruby.next-specs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,5 @@ spec/ruby/core/module/refinements_spec.rb
3737
spec/ruby/core/module/undefined_instance_methods_spec.rb
3838
spec/ruby/core/refinement/refined_class_spec.rb
3939
spec/ruby/core/module/used_refinements_spec.rb
40-
spec/ruby/optional/capi/hash_spec.rb
4140

4241
spec/ruby/core/thread/each_caller_location_spec.rb

0 commit comments

Comments
 (0)