Fix the --warn-truffle-regex-compile-fallback warning to include caller location

Author: eregon

src/main/java/org/truffleruby/core/regexp/TRegexCache.java

@@ -21,13 +21,13 @@
 import org.jcodings.specific.USASCIIEncoding;
 import org.jcodings.specific.UTF8Encoding;
 import org.truffleruby.RubyContext;
+import org.truffleruby.core.regexp.TruffleRegexpNodes.TRegexCompileNode;
 import org.truffleruby.core.rope.CannotConvertBinaryRubyStringToJavaString;
 import org.truffleruby.core.rope.Rope;
 import org.truffleruby.core.rope.RopeBuilder;
 import org.truffleruby.core.rope.RopeOperations;
 import org.truffleruby.language.Nil;
 import org.truffleruby.language.control.DeferredRaiseException;
-import org.truffleruby.language.dispatch.DispatchNode;
 
 public final class TRegexCache {
 
@@ -60,12 +60,13 @@ public Object getBinaryRegex(boolean atStart) {
     }
 
     @TruffleBoundary
-    public Object compile(RubyContext context, RubyRegexp regexp, boolean atStart, Encoding encoding) {
+    public Object compile(RubyContext context, RubyRegexp regexp, boolean atStart, Encoding encoding,
+            TRegexCompileNode node) {
         Object tregex = compileTRegex(context, regexp, atStart, encoding);
         if (tregex == null) {
             tregex = Nil.INSTANCE;
             if (context.getOptions().WARN_TRUFFLE_REGEX_COMPILE_FALLBACK) {
-                DispatchNode.getUncached().call(
+                node.getWarnOnFallbackNode().call(
                         context.getCoreLibrary().truffleRegexpOperationsModule,
                         "warn_fallback_regex",
                         regexp,

src/main/java/org/truffleruby/core/regexp/TruffleRegexpNodes.java

@@ -254,7 +254,7 @@ protected Object usASCII(RubyRegexp regexp, boolean atStart, Encoding encoding)
             if (tregex != null) {
                 return tregex;
             } else {
-                return regexp.tregexCache.compile(getContext(), regexp, atStart, encoding);
+                return regexp.tregexCache.compile(getContext(), regexp, atStart, encoding, this);
             }
         }
 
@@ -264,7 +264,7 @@ protected Object latin1(RubyRegexp regexp, boolean atStart, Encoding encoding) {
             if (tregex != null) {
                 return tregex;
             } else {
-                return regexp.tregexCache.compile(getContext(), regexp, atStart, encoding);
+                return regexp.tregexCache.compile(getContext(), regexp, atStart, encoding, this);
             }
         }
 
@@ -274,7 +274,7 @@ protected Object utf8(RubyRegexp regexp, boolean atStart, Encoding encoding) {
             if (tregex != null) {
                 return tregex;
             } else {
-                return regexp.tregexCache.compile(getContext(), regexp, atStart, encoding);
+                return regexp.tregexCache.compile(getContext(), regexp, atStart, encoding, this);
             }
         }
 
@@ -284,7 +284,7 @@ protected Object binary(RubyRegexp regexp, boolean atStart, Encoding encoding) {
             if (tregex != null) {
                 return tregex;
             } else {
-                return regexp.tregexCache.compile(getContext(), regexp, atStart, encoding);
+                return regexp.tregexCache.compile(getContext(), regexp, atStart, encoding, this);
             }
         }
 
@@ -298,6 +298,13 @@ protected Object other(RubyRegexp regexp, boolean atStart, Encoding encoding) {
             return nil;
         }
 
+        DispatchNode getWarnOnFallbackNode() {
+            if (warnOnFallbackNode == null) {
+                CompilerDirectives.transferToInterpreterAndInvalidate();
+                warnOnFallbackNode = insert(DispatchNode.create());
+            }
+            return warnOnFallbackNode;
+        }
     }
 
     public abstract static class RegexpStatsNode extends CoreMethodArrayArgumentsNode {