[WIP][GR-14806] Update specs

PullRequest: truffleruby/4308

Author: andrykonchin

spec/mspec/lib/mspec/helpers/tmp.rb

@@ -36,7 +36,20 @@
 end
 
 def tmp(name, uniquify = true)
-  mkdir_p SPEC_TEMP_DIR unless Dir.exist? SPEC_TEMP_DIR
+  if Dir.exist? SPEC_TEMP_DIR
+    stat = File.stat(SPEC_TEMP_DIR)
+    if stat.world_writable? and !stat.sticky?
+      raise ArgumentError, "SPEC_TEMP_DIR (#{SPEC_TEMP_DIR}) is world writable but not sticky"
+    end
+  else
+    platform_is_not :windows do
+      umask = File.umask
+      if (umask & 0002) == 0 # o+w
+        raise ArgumentError, "File.umask #=> #{umask.to_s(8)} (world-writable)"
+      end
+    end
+    mkdir_p SPEC_TEMP_DIR
+  end
 
   if uniquify and !name.empty?
     slash = name.rindex "/"

spec/mspec/lib/mspec/runner/formatters/multi.rb

@@ -42,6 +42,6 @@ def aggregate_results(files)
   end
 
   def print_exception(exc, count)
-    print "\n#{count})\n#{exc}\n"
+    @err.print "\n#{count})\n#{exc}\n"
   end
 end

spec/ruby/CONTRIBUTING.md

@@ -277,13 +277,13 @@ describe :kernel_sprintf, shared: true do
 end
 
 describe "Kernel#sprintf" do
-  it_behaves_like :kernel_sprintf, -> (format, *args) {
+  it_behaves_like :kernel_sprintf, -> format, *args {
     sprintf(format, *args)
   }
 end
 
 describe "Kernel.sprintf" do
-  it_behaves_like :kernel_sprintf, -> (format, *args) {
+  it_behaves_like :kernel_sprintf, -> format, *args {
     Kernel.sprintf(format, *args)
   }
 end

spec/ruby/README.md

@@ -35,7 +35,7 @@ More precisely, every latest stable MRI release should [pass](https://github.com
 
 ### Synchronization with Ruby Implementations
 
-The specs are synchronized both ways around once a month by @eregon between ruby/spec, MRI, JRuby and TruffleRuby,
+The specs are synchronized both ways around once a month by @andrykonchin between ruby/spec, MRI, JRuby and TruffleRuby,
 using [this script](https://github.com/ruby/mspec/blob/master/tool/sync/sync-rubyspec.rb).
 Each of these repositories has a full copy of the specs under `spec/ruby` to ease editing specs.
 Any of these repositories can be used to add or edit specs, use what is most convenient for you.

spec/ruby/core/array/each_spec.rb

@@ -7,7 +7,7 @@
 # Mutating the array while it is being iterated is discouraged as it can result in confusing behavior.
 # Yet a Ruby implementation must not crash in such a case, and following the simple CRuby behavior makes sense.
 # CRuby simply reads the array storage and checks the size for every iteration;
-# like `i = 0; while i < size; yield self[i]; end`
+# like `i = 0; while i < size; yield self[i]; i += 1; end`
 
 describe "Array#each" do
   it "yields each element to the block" do

spec/ruby/core/array/plus_spec.rb

@@ -21,7 +21,7 @@
       ([1, 2, 3] + obj).should == [1, 2, 3, "x", "y"]
     end
 
-    it "raises a Typeerror if the given argument can't be converted to an array" do
+    it "raises a TypeError if the given argument can't be converted to an array" do
       -> { [1, 2, 3] + nil }.should raise_error(TypeError)
       -> { [1, 2, 3] + "abc" }.should raise_error(TypeError)
     end

spec/ruby/core/dir/chdir_spec.rb

@@ -19,14 +19,14 @@
   end
 
   it "defaults to $HOME with no arguments" do
-    if ENV['HOME']
-      Dir.chdir
-      current_dir = Dir.pwd
+    skip "$HOME not valid directory" unless ENV['HOME'] && File.directory?(ENV['HOME'])
 
-      Dir.chdir(ENV['HOME'])
-      home = Dir.pwd
-      current_dir.should == home
-    end
+    Dir.chdir
+    current_dir = Dir.pwd
+
+    Dir.chdir(ENV['HOME'])
+    home = Dir.pwd
+    current_dir.should == home
   end
 
   it "changes to the specified directory" do
@@ -70,6 +70,8 @@ def to_str;  DirSpecs.mock_dir; end
   end
 
   it "defaults to the home directory when given a block but no argument" do
+    skip "$HOME not valid directory" unless ENV['HOME'] && File.directory?(ENV['HOME'])
+
     # Windows will return a path with forward slashes for ENV["HOME"] so we have
     # to compare the route representations returned by Dir.chdir.
     current_dir = ""

spec/ruby/core/dir/shared/exist.rb

@@ -34,6 +34,7 @@
   end
 
   it "doesn't expand paths" do
+    skip "$HOME not valid directory" unless ENV['HOME'] && File.directory?(ENV['HOME'])
     Dir.send(@method, File.expand_path('~')).should be_true
     Dir.send(@method, '~').should be_false
   end

spec/ruby/core/exception/detailed_message_spec.rb

@@ -15,14 +15,6 @@ def exception.detailed_message(**)
       exception.full_message(highlight: false).should.include? "<prefix>new error<suffix>"
     end
 
-    it "accepts highlight keyword argument and adds escape control sequences" do
-      RuntimeError.new("new error").detailed_message(highlight: true).should == "\e[1mnew error (\e[1;4mRuntimeError\e[m\e[1m)\e[m"
-    end
-
-    it "allows and ignores other keyword arguments" do
-      RuntimeError.new("new error").detailed_message(foo: true).should == "new error (RuntimeError)"
-    end
-
     it "returns just a message if exception class is anonymous" do
       Class.new(RuntimeError).new("message").detailed_message.should == "message"
     end
@@ -31,13 +23,30 @@ def exception.detailed_message(**)
       RuntimeError.new("").detailed_message.should == "unhandled exception"
     end
 
-    it "returns just class name for an instance of RuntimeError subclass with empty message" do
+    it "returns just class name for an instance other than RuntimeError with empty message" do
       DetailedMessageSpec::C.new("").detailed_message.should == "DetailedMessageSpec::C"
+      StandardError.new("").detailed_message.should == "StandardError"
     end
 
     it "returns a generated class name for an instance of RuntimeError anonymous subclass with empty message" do
       klass = Class.new(RuntimeError)
       klass.new("").detailed_message.should =~ /\A#<Class:0x\h+>\z/
     end
+
+    it "accepts highlight keyword argument and adds escape control sequences" do
+      RuntimeError.new("new error").detailed_message(highlight: true).should == "\e[1mnew error (\e[1;4mRuntimeError\e[m\e[1m)\e[m"
+    end
+
+    it "accepts highlight keyword argument and adds escape control sequences for an instance of RuntimeError with empty message" do
+      RuntimeError.new("").detailed_message(highlight: true).should == "\e[1;4munhandled exception\e[m"
+    end
+
+    it "accepts highlight keyword argument and adds escape control sequences for an instance other than RuntimeError with empty message" do
+      StandardError.new("").detailed_message(highlight: true).should == "\e[1;4mStandardError\e[m"
+    end
+
+    it "allows and ignores other keyword arguments" do
+      RuntimeError.new("new error").detailed_message(foo: true).should == "new error (RuntimeError)"
+    end
   end
 end

spec/ruby/core/hash/replace_spec.rb

@@ -1,7 +1,70 @@
 require_relative '../../spec_helper'
 require_relative 'fixtures/classes'
-require_relative 'shared/replace'
 
 describe "Hash#replace" do
-  it_behaves_like :hash_replace, :replace
+  it "replaces the contents of self with other" do
+    h = { a: 1, b: 2 }
+    h.replace(c: -1, d: -2).should equal(h)
+    h.should == { c: -1, d: -2 }
+  end
+
+  it "tries to convert the passed argument to a hash using #to_hash" do
+    obj = mock('{1=>2,3=>4}')
+    obj.should_receive(:to_hash).and_return({ 1 => 2, 3 => 4 })
+
+    h = {}
+    h.replace(obj)
+    h.should == { 1 => 2, 3 => 4 }
+  end
+
+  it "calls to_hash on hash subclasses" do
+    h = {}
+    h.replace(HashSpecs::ToHashHash[1 => 2])
+    h.should == { 1 => 2 }
+  end
+
+  it "transfers the compare_by_identity flag" do
+    hash_a = { a: 1 }
+    hash_b = { b: 2 }
+    hash_b.compare_by_identity
+    hash_a.should_not.compare_by_identity?
+    hash_a.replace(hash_b)
+    hash_a.should.compare_by_identity?
+
+    hash_a = { a: 1 }
+    hash_b = { b: 2 }
+    hash_a.compare_by_identity
+    hash_a.should.compare_by_identity?
+    hash_a.replace(hash_b)
+    hash_a.should_not.compare_by_identity?
+  end
+
+  it "does not transfer default values" do
+    hash_a = {}
+    hash_b = Hash.new(5)
+    hash_a.replace(hash_b)
+    hash_a.default.should == 5
+
+    hash_a = {}
+    hash_b = Hash.new { |h, k| k * 2 }
+    hash_a.replace(hash_b)
+    hash_a.default(5).should == 10
+
+    hash_a = Hash.new { |h, k| k * 5 }
+    hash_b = Hash.new(-> { raise "Should not invoke lambda" })
+    hash_a.replace(hash_b)
+    hash_a.default.should == hash_b.default
+  end
+
+  it "raises a FrozenError if called on a frozen instance that would not be modified" do
+    -> do
+      HashSpecs.frozen_hash.replace(HashSpecs.frozen_hash)
+    end.should raise_error(FrozenError)
+  end
+
+  it "raises a FrozenError if called on a frozen instance that is modified" do
+    -> do
+      HashSpecs.frozen_hash.replace(HashSpecs.empty_frozen_hash)
+    end.should raise_error(FrozenError)
+  end
 end