Address ECJ warnings

* They happen again since org.truffleruby no longer uses "jniHeaders": True
  and so can again be compiled by ECJ and is not forced to use javac.

Author: eregon

mx.truffleruby/eclipse-settings/org.eclipse.jdt.core.prefs

@@ -1,11 +1,13 @@
 org.eclipse.jdt.core.compiler.problem.invalidJavadoc=warning
+org.eclipse.jdt.core.compiler.problem.invalidJavadocTags=disabled
 org.eclipse.jdt.core.compiler.problem.missingDeprecatedAnnotation=warning
 org.eclipse.jdt.core.compiler.problem.missingOverrideAnnotation=warning
 org.eclipse.jdt.core.compiler.problem.unusedParameter=ignore
 org.eclipse.jdt.core.compiler.problem.reportMethodCanBeStatic=ignore
 org.eclipse.jdt.core.compiler.problem.localVariableHiding=ignore
 org.eclipse.jdt.core.compiler.problem.parameterAssignment=ignore
 org.eclipse.jdt.core.compiler.problem.unusedWarningToken=ignore
+org.eclipse.jdt.core.compiler.problem.overridingPackageDefaultMethod=ignore
 org.eclipse.jdt.core.formatter.insert_space_after_opening_brace_in_array_initializer=insert
 org.eclipse.jdt.core.formatter.insert_space_before_closing_brace_in_array_initializer=insert
 org.eclipse.jdt.core.formatter.never_indent_block_comments_on_first_column=false

src/main/java/org/truffleruby/cext/ValueWrapperManager.java

@@ -215,12 +215,6 @@ public static final class HandleBlock {
 
         @SuppressWarnings("unused") private Cleanable cleanable;
 
-        private HandleBlock() {
-            base = 0;
-            cleanable = null;
-            wrappers = null;
-        }
-
         public HandleBlock(RubyContext context, RubyLanguage language, ValueWrapperManager manager) {
             HandleBlockAllocator allocator = language.handleBlockAllocator;
             long base = allocator.getFreeBlock();

src/main/java/org/truffleruby/collections/ConcurrentWeakSet.java

@@ -32,7 +32,7 @@ public Object[] toArray() {
 
     @TruffleBoundary
     public WeakSetIterator<E> iterator() {
-        return new WeakSetIterator<E>(map.keySet().iterator());
+        return new WeakSetIterator<>(map.keySet().iterator());
     }
 
     private static final class WeakSetIterator<E> implements Iterator<E> {

src/main/java/org/truffleruby/core/array/ArrayConcatNode.java

@@ -81,6 +81,7 @@ public void doExecuteVoid(VirtualFrame frame) {
         }
     }
 
+    @Override
     public RubyNode cloneUninitialized() {
         var copy = new ArrayConcatNode(cloneUninitialized(children));
         return copy.copyFlags(this);

src/main/java/org/truffleruby/core/array/library/DoubleArrayStore.java

@@ -165,7 +165,7 @@ static void sort(double[] store, int size) {
 
     @ExportMessage
     static Iterable<Object> getIterable(double[] store, int from, int length) {
-        return () -> new Iterator<Object>() {
+        return () -> new Iterator<>() {
 
             private int n = from;
 

src/main/java/org/truffleruby/core/array/library/IntegerArrayStore.java

@@ -165,7 +165,7 @@ static void sort(int[] store, int size) {
 
     @ExportMessage
     static Iterable<Object> getIterable(int[] store, int from, int length) {
-        return () -> new Iterator<Object>() {
+        return () -> new Iterator<>() {
 
             private int n = from;
 

src/main/java/org/truffleruby/core/array/library/LongArrayStore.java

@@ -186,7 +186,7 @@ static void sort(long[] store, int size) {
 
     @ExportMessage
     static Iterable<Object> getIterable(long[] store, int from, int length) {
-        return () -> new Iterator<Object>() {
+        return () -> new Iterator<>() {
 
             private int n = from;
 

src/main/java/org/truffleruby/core/array/library/NativeArrayStorage.java

@@ -221,7 +221,7 @@ protected Object[] toJavaArrayCopy(int size,
     @ExportMessage
     static Iterable<Object> getIterable(NativeArrayStorage store, int from, int length,
             @CachedLibrary("store") ArrayStoreLibrary stores) {
-        return () -> new Iterator<Object>() {
+        return () -> new Iterator<>() {
 
             private int n = from;
 

src/main/java/org/truffleruby/core/array/library/ObjectArrayStore.java

@@ -160,7 +160,7 @@ static Object[] toJavaArrayCopy(Object[] store, int length) {
 
     @ExportMessage
     static Iterable<Object> getIterable(Object[] store, int from, int length) {
-        return () -> new Iterator<Object>() {
+        return () -> new Iterator<>() {
 
             private int n = from;
 

src/main/java/org/truffleruby/core/fiber/FiberManager.java

@@ -478,10 +478,6 @@ public RubyFiber getSendingFiber() {
             return sendingFiber;
         }
 
-        public ArgumentsDescriptor getDescriptor() {
-            return descriptor;
-        }
-
         public Object[] getArgs() {
             return args;
         }