Refactor #visitLocalVariableWriteNode method

Author: andrykonchin

spec/truffle/parsing/fixtures/rescue/capturing/with_local_variable.yaml

@@ -66,7 +66,7 @@ ast: |
                                                               DeadNode
                                                                   attributes:
                                                                       flags = 0
-                                                                      reason = "YARPTranslator#visitLocalVariableWriteNode"
+                                                                      reason = "YARPTranslator#visitLocalVariableTargetNode"
                                       IntegerFixnumLiteralNode
                                           attributes:
                                               flags = 1

spec/truffle/parsing/fixtures/rescue/with_exception_and_variable.yaml

@@ -69,7 +69,7 @@ ast: |
                                                               DeadNode
                                                                   attributes:
                                                                       flags = 0
-                                                                      reason = "YARPTranslator#visitLocalVariableWriteNode"
+                                                                      reason = "YARPTranslator#visitLocalVariableTargetNode"
                                       IntegerFixnumLiteralNode
                                           attributes:
                                               flags = 1

spec/truffle/parsing/fixtures/rescue/without_exception_but_with_variable.yaml

@@ -42,7 +42,7 @@ ast: |
                                                               DeadNode
                                                                   attributes:
                                                                       flags = 0
-                                                                      reason = "YARPTranslator#visitLocalVariableWriteNode"
+                                                                      reason = "YARPTranslator#visitLocalVariableTargetNode"
                                       IntegerFixnumLiteralNode
                                           attributes:
                                               flags = 1

src/main/java/org/truffleruby/parser/YARPMultiTargetNodeTranslator.java

@@ -20,6 +20,8 @@
 import org.truffleruby.core.cast.SplatCastNodeGen;
 import org.truffleruby.language.RubyNode;
 import org.truffleruby.language.literal.NilLiteralNode;
+import org.truffleruby.language.locals.ReadLocalNode;
+import org.truffleruby.language.locals.WriteLocalNode;
 
 // Could be used in ordinal multi-assignment and for destructuring array argument in method/proc parameters:
 // - a, (b, c) = 1, [2, 3]
@@ -164,11 +166,15 @@ public AssignableNode visitSplatNode(Nodes.SplatNode node) {
     @Override
     // RequiredParameterNode is handled during destructuring method/proc arguments
     public AssignableNode visitRequiredParameterNode(Nodes.RequiredParameterNode node) {
-        // TODO: this could be done more directly but the logic of visitLocalVariableWriteNode() needs to be simpler first
-        // NOTE: depth is not supposed to be used anyway so pass 0 value.
-        final RubyNode rubyNode = yarpTranslator.visitLocalVariableWriteNode(
-                new Nodes.LocalVariableWriteNode(node.name, 0, null, node.startOffset, node.length));
-        return ((AssignableNode) rubyNode).toAssignableNode();
+        final String name = node.name;
+        final ReadLocalNode lhs = yarpTranslator.getEnvironment().findLocalVarNode(name, null);
+
+        assert lhs != null;
+
+        final RubyNode rhs = new DeadNode("YARPMultiTargetNodeTranslator#visitRequiredParameterNode");
+        final WriteLocalNode rubyNode = lhs.makeWriteNode(rhs);
+
+        return rubyNode.toAssignableNode();
     }
 
     @Override

src/main/java/org/truffleruby/parser/YARPTranslator.java

@@ -2491,30 +2491,11 @@ public RubyNode visitLocalVariableOrWriteNode(Nodes.LocalVariableOrWriteNode nod
     @Override
     public WriteLocalNode visitLocalVariableWriteNode(Nodes.LocalVariableWriteNode node) {
         final String name = node.name;
+        final ReadLocalNode lhs = environment.findLocalVarNode(name, null);
 
-        if (environment.getNeverAssignInParentScope()) {
-            environment.declareVar(name);
-        }
-
-        ReadLocalNode lhs = environment.findLocalVarNode(name, null);
-
-        // TODO: it should always be present if we use byte[][] locals
-        if (lhs == null) {
-            TranslatorEnvironment environmentToDeclareIn = environment;
-            while (!environmentToDeclareIn.hasOwnScopeForAssignments()) {
-                environmentToDeclareIn = environmentToDeclareIn.getParent();
-            }
-            environmentToDeclareIn.declareVar(name);
-
-            lhs = environment.findLocalVarNode(name, null);
-
-            if (lhs == null) {
-                throw CompilerDirectives.shouldNotReachHere();
-            }
-        }
+        assert lhs != null;
 
-        // TODO simplify once visitLocalVariableTargetNode does not reuse this method
-        final RubyNode rhs = translateNodeOrDeadNode(node.value, "YARPTranslator#visitLocalVariableWriteNode");
+        final RubyNode rhs = node.value.accept(this);
         final WriteLocalNode rubyNode = lhs.makeWriteNode(rhs);
 
         assignPositionAndFlags(node, rubyNode);
@@ -2523,9 +2504,16 @@ public WriteLocalNode visitLocalVariableWriteNode(Nodes.LocalVariableWriteNode n
 
     @Override
     public WriteLocalNode visitLocalVariableTargetNode(Nodes.LocalVariableTargetNode node) {
-        // TODO: this could be done more directly but the logic of visitLocalVariableWriteNode() needs to be simpler first
-        return visitLocalVariableWriteNode(
-                new Nodes.LocalVariableWriteNode(node.name, node.depth, null, node.startOffset, node.length));
+        final String name = node.name;
+        final ReadLocalNode lhs = environment.findLocalVarNode(name, null);
+
+        assert lhs != null;
+
+        final RubyNode rhs = new DeadNode("YARPTranslator#visitLocalVariableTargetNode");
+        final WriteLocalNode rubyNode = lhs.makeWriteNode(rhs);
+
+        assignPositionAndFlags(node, rubyNode);
+        return rubyNode;
     }
 
     @Override